[INFO] updating cached repository daemondragon/C-norme [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/daemondragon/C-norme [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/daemondragon/C-norme" "work/ex/clippy-test-run/sources/stable/gh/daemondragon/C-norme"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/daemondragon/C-norme'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/daemondragon/C-norme" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daemondragon/C-norme"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daemondragon/C-norme'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 417fd7c6ff96741b8e8b0f0492be5d65222a438f [INFO] sha for GitHub repo daemondragon/C-norme: 417fd7c6ff96741b8e8b0f0492be5d65222a438f [INFO] validating manifest of daemondragon/C-norme on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of daemondragon/C-norme on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing daemondragon/C-norme [INFO] finished frobbing daemondragon/C-norme [INFO] frobbed toml for daemondragon/C-norme written to work/ex/clippy-test-run/sources/stable/gh/daemondragon/C-norme/Cargo.toml [INFO] started frobbing daemondragon/C-norme [INFO] finished frobbing daemondragon/C-norme [INFO] frobbed toml for daemondragon/C-norme written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daemondragon/C-norme/Cargo.toml [INFO] crate daemondragon/C-norme has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting daemondragon/C-norme against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/daemondragon/C-norme:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] af2b68ac39d67e50edb8e7119fc1e9e62a0e6b884e46e4f6bae376e2e00f5b4b [INFO] running `"docker" "start" "-a" "af2b68ac39d67e50edb8e7119fc1e9e62a0e6b884e46e4f6bae376e2e00f5b4b"` [INFO] [stderr] Checking norme v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/indentation.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/indentation.rs:58:3 [INFO] [stderr] | [INFO] [stderr] 58 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/indentation.rs:88:3 [INFO] [stderr] | [INFO] [stderr] 88 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/indentation.rs:190:3 [INFO] [stderr] | [INFO] [stderr] 190 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/indentation.rs:240:3 [INFO] [stderr] | [INFO] [stderr] 240 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/indentation.rs:288:3 [INFO] [stderr] | [INFO] [stderr] 288 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/indentation.rs:353:3 [INFO] [stderr] | [INFO] [stderr] 353 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/misc.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/rules/misc.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | else if line.contains("}") && !(line.trim().len() == 1 || [INFO] [stderr] | __________________^ [INFO] [stderr] 26 | | (line.chars().filter(|c| !c.is_whitespace()).count() == 2 && line.trim_right().ends_with("\\"))) { [INFO] [stderr] 27 | | [INFO] [stderr] 28 | | if !line.ends_with(";") { [INFO] [stderr] 29 | | errors.push(format!("[{}:{}]Closing brace must be on their own line.", filename, line_number)); [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 25 | else if line.contains("}") && !(line.trim().len() == 1 || [INFO] [stderr] 26 | (line.chars().filter(|c| !c.is_whitespace()).count() == 2 && line.trim_right().ends_with("\\"))) && !line.ends_with(";") { [INFO] [stderr] 27 | errors.push(format!("[{}:{}]Closing brace must be on their own line.", filename, line_number)); [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/misc.rs:98:3 [INFO] [stderr] | [INFO] [stderr] 98 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/rules/misc.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | if in_comment { [INFO] [stderr] | _____________^ [INFO] [stderr] 72 | | if !line.trim_left().starts_with("**") { [INFO] [stderr] 73 | | errors.push(format!("[{}:{}]Comment intermediary line must start with '**'.", filename, line_number)); [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 71 | if in_comment && !line.trim_left().starts_with("**") { [INFO] [stderr] 72 | errors.push(format!("[{}:{}]Comment intermediary line must start with '**'.", filename, line_number)); [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/misc.rs:127:3 [INFO] [stderr] | [INFO] [stderr] 127 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/misc.rs:173:3 [INFO] [stderr] | [INFO] [stderr] 173 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/misc.rs:202:3 [INFO] [stderr] | [INFO] [stderr] 202 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:71:3 [INFO] [stderr] | [INFO] [stderr] 71 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:103:3 [INFO] [stderr] | [INFO] [stderr] 103 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:151:3 [INFO] [stderr] | [INFO] [stderr] 151 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/rules/preprocessor.rs:129:4 [INFO] [stderr] | [INFO] [stderr] 129 | if line.starts_with("#") { [INFO] [stderr] | _____________^ [INFO] [stderr] 130 | | if line.trim_right().ends_with("\\") { [INFO] [stderr] 131 | | in_multi_line_macro = true; [INFO] [stderr] 132 | | alignement = line.rfind("\\").unwrap(); [INFO] [stderr] 133 | | } [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | if line.starts_with("#") && line.trim_right().ends_with("\\") { [INFO] [stderr] 130 | in_multi_line_macro = true; [INFO] [stderr] 131 | alignement = line.rfind("\\").unwrap(); [INFO] [stderr] 132 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:192:3 [INFO] [stderr] | [INFO] [stderr] 192 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:253:3 [INFO] [stderr] | [INFO] [stderr] 253 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:311:3 [INFO] [stderr] | [INFO] [stderr] 311 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:354:3 [INFO] [stderr] | [INFO] [stderr] 354 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:396:3 [INFO] [stderr] | [INFO] [stderr] 396 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:60:3 [INFO] [stderr] | [INFO] [stderr] 60 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:119:3 [INFO] [stderr] | [INFO] [stderr] 119 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:179:3 [INFO] [stderr] | [INFO] [stderr] 179 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:238:3 [INFO] [stderr] | [INFO] [stderr] 238 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:275:3 [INFO] [stderr] | [INFO] [stderr] 275 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:313:3 [INFO] [stderr] | [INFO] [stderr] 313 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:366:3 [INFO] [stderr] | [INFO] [stderr] 366 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:418:3 [INFO] [stderr] | [INFO] [stderr] 418 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/naming.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/naming.rs:157:3 [INFO] [stderr] | [INFO] [stderr] 157 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/control_structures.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/control_structures.rs:61:3 [INFO] [stderr] | [INFO] [stderr] 61 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/control_structures.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/control_structures.rs:149:3 [INFO] [stderr] | [INFO] [stderr] 149 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/control_structures.rs:207:3 [INFO] [stderr] | [INFO] [stderr] 207 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/indentation.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/indentation.rs:58:3 [INFO] [stderr] | [INFO] [stderr] 58 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/indentation.rs:88:3 [INFO] [stderr] | [INFO] [stderr] 88 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/indentation.rs:190:3 [INFO] [stderr] | [INFO] [stderr] 190 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/indentation.rs:240:3 [INFO] [stderr] | [INFO] [stderr] 240 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/indentation.rs:288:3 [INFO] [stderr] | [INFO] [stderr] 288 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/indentation.rs:353:3 [INFO] [stderr] | [INFO] [stderr] 353 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/misc.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/rules/misc.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | else if line.contains("}") && !(line.trim().len() == 1 || [INFO] [stderr] | __________________^ [INFO] [stderr] 26 | | (line.chars().filter(|c| !c.is_whitespace()).count() == 2 && line.trim_right().ends_with("\\"))) { [INFO] [stderr] 27 | | [INFO] [stderr] 28 | | if !line.ends_with(";") { [INFO] [stderr] 29 | | errors.push(format!("[{}:{}]Closing brace must be on their own line.", filename, line_number)); [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 25 | else if line.contains("}") && !(line.trim().len() == 1 || [INFO] [stderr] 26 | (line.chars().filter(|c| !c.is_whitespace()).count() == 2 && line.trim_right().ends_with("\\"))) && !line.ends_with(";") { [INFO] [stderr] 27 | errors.push(format!("[{}:{}]Closing brace must be on their own line.", filename, line_number)); [INFO] [stderr] 28 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/misc.rs:98:3 [INFO] [stderr] | [INFO] [stderr] 98 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/rules/misc.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | if in_comment { [INFO] [stderr] | _____________^ [INFO] [stderr] 72 | | if !line.trim_left().starts_with("**") { [INFO] [stderr] 73 | | errors.push(format!("[{}:{}]Comment intermediary line must start with '**'.", filename, line_number)); [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 71 | if in_comment && !line.trim_left().starts_with("**") { [INFO] [stderr] 72 | errors.push(format!("[{}:{}]Comment intermediary line must start with '**'.", filename, line_number)); [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/misc.rs:127:3 [INFO] [stderr] | [INFO] [stderr] 127 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/misc.rs:173:3 [INFO] [stderr] | [INFO] [stderr] 173 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/misc.rs:202:3 [INFO] [stderr] | [INFO] [stderr] 202 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:71:3 [INFO] [stderr] | [INFO] [stderr] 71 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:103:3 [INFO] [stderr] | [INFO] [stderr] 103 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:151:3 [INFO] [stderr] | [INFO] [stderr] 151 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/rules/preprocessor.rs:129:4 [INFO] [stderr] | [INFO] [stderr] 129 | if line.starts_with("#") { [INFO] [stderr] | _____________^ [INFO] [stderr] 130 | | if line.trim_right().ends_with("\\") { [INFO] [stderr] 131 | | in_multi_line_macro = true; [INFO] [stderr] 132 | | alignement = line.rfind("\\").unwrap(); [INFO] [stderr] 133 | | } [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | if line.starts_with("#") && line.trim_right().ends_with("\\") { [INFO] [stderr] 130 | in_multi_line_macro = true; [INFO] [stderr] 131 | alignement = line.rfind("\\").unwrap(); [INFO] [stderr] 132 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:192:3 [INFO] [stderr] | [INFO] [stderr] 192 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:253:3 [INFO] [stderr] | [INFO] [stderr] 253 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:311:3 [INFO] [stderr] | [INFO] [stderr] 311 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:354:3 [INFO] [stderr] | [INFO] [stderr] 354 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/preprocessor.rs:396:3 [INFO] [stderr] | [INFO] [stderr] 396 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:60:3 [INFO] [stderr] | [INFO] [stderr] 60 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:119:3 [INFO] [stderr] | [INFO] [stderr] 119 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:179:3 [INFO] [stderr] | [INFO] [stderr] 179 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:238:3 [INFO] [stderr] | [INFO] [stderr] 238 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:275:3 [INFO] [stderr] | [INFO] [stderr] 275 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:313:3 [INFO] [stderr] | [INFO] [stderr] 313 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:366:3 [INFO] [stderr] | [INFO] [stderr] 366 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/function.rs:418:3 [INFO] [stderr] | [INFO] [stderr] 418 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/naming.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/naming.rs:157:3 [INFO] [stderr] | [INFO] [stderr] 157 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/control_structures.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/control_structures.rs:61:3 [INFO] [stderr] | [INFO] [stderr] 61 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/control_structures.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/control_structures.rs:149:3 [INFO] [stderr] | [INFO] [stderr] 149 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rules/control_structures.rs:207:3 [INFO] [stderr] | [INFO] [stderr] 207 | return errors; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | if line.contains("\t") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rules/indentation.rs:133:8 [INFO] [stderr] | [INFO] [stderr] 133 | if line.len() != 0 && current_indentation != needed_indentation { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:219:25 [INFO] [stderr] | [INFO] [stderr] 219 | if !line.ends_with(";") && !line.ends_with("\\"){ [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:219:49 [INFO] [stderr] | [INFO] [stderr] 219 | if !line.ends_with(";") && !line.ends_with("\\"){ [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:223:33 [INFO] [stderr] | [INFO] [stderr] 223 | let left_part = line.split(";").next().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/rules/indentation.rs:265:7 [INFO] [stderr] | [INFO] [stderr] 265 | if nb_comma <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using nb_comma == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: the variable `actual_between` is used as a loop counter. Consider using `for (actual_between, item) in line.split(",").enumerate()` or similar iterators [INFO] [stderr] --> src/rules/indentation.rs:269:19 [INFO] [stderr] | [INFO] [stderr] 269 | for between in line.split(",") { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:269:30 [INFO] [stderr] | [INFO] [stderr] 269 | for between in line.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/rules/indentation.rs:333:8 [INFO] [stderr] | [INFO] [stderr] 333 | if !line.contains("{") && line.trim().len() > 0 && !(!have_typedef && line.contains("}")) && (!line.contains("typedef") || line.split_whitespace().count() > 2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(!line.contains("typedef") || line.split_whitespace().count() > 2) && (have_typedef || !line.contains("}")) && line.trim().len() > 0 && !line.contains("{")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:317:21 [INFO] [stderr] | [INFO] [stderr] 317 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:320:21 [INFO] [stderr] | [INFO] [stderr] 320 | if line.contains("}") && level > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:325:21 [INFO] [stderr] | [INFO] [stderr] 325 | !(line.contains("(") || line.contains(",") || line.contains(")") || [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:325:43 [INFO] [stderr] | [INFO] [stderr] 325 | !(line.contains("(") || line.contains(",") || line.contains(")") || [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:325:65 [INFO] [stderr] | [INFO] [stderr] 325 | !(line.contains("(") || line.contains(",") || line.contains(")") || [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:333:23 [INFO] [stderr] | [INFO] [stderr] 333 | if !line.contains("{") && line.trim().len() > 0 && !(!have_typedef && line.contains("}")) && (!line.contains("typedef") || line.split_whitespace().count() > 2) { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rules/indentation.rs:333:31 [INFO] [stderr] | [INFO] [stderr] 333 | if !line.contains("{") && line.trim().len() > 0 && !(!have_typedef && line.contains("}")) && (!line.contains("typedef") || line.split_whitespace().count() > 2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:333:89 [INFO] [stderr] | [INFO] [stderr] 333 | if !line.contains("{") && line.trim().len() > 0 && !(!have_typedef && line.contains("}")) && (!line.contains("typedef") || line.split_whitespace().count() > 2) { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/rules/indentation.rs:336:9 [INFO] [stderr] | [INFO] [stderr] 336 | if indentation <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using indentation == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:344:22 [INFO] [stderr] | [INFO] [stderr] 344 | if line.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | if line.contains("{") && !(line.trim().len() == 1 || [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:22:94 [INFO] [stderr] | [INFO] [stderr] 22 | (line.chars().filter(|c| !c.is_whitespace()).count() == 2 && line.trim_right().ends_with("\\"))) { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | else if line.contains("}") && !(line.trim().len() == 1 || [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:26:95 [INFO] [stderr] | [INFO] [stderr] 26 | (line.chars().filter(|c| !c.is_whitespace()).count() == 2 && line.trim_right().ends_with("\\"))) { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | if !line.ends_with(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:152:22 [INFO] [stderr] | [INFO] [stderr] 152 | if line.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | if line.contains(",") && [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:160:18 [INFO] [stderr] | [INFO] [stderr] 160 | !line.split(",").last().unwrap().trim().is_empty() { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:195:66 [INFO] [stderr] | [INFO] [stderr] 195 | if line.trim_left().starts_with("static ") && (!line.contains("(") || line.contains("=")) && !line.contains("static const") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:195:88 [INFO] [stderr] | [INFO] [stderr] 195 | if line.trim_left().starts_with("static ") && (!line.contains("(") || line.contains("=")) && !line.contains("static const") { [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:19:36 [INFO] [stderr] | [INFO] [stderr] 19 | if line.trim_left().starts_with("#") && !line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:19:62 [INFO] [stderr] | [INFO] [stderr] 19 | if line.trim_left().starts_with("#") && !line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:94:24 [INFO] [stderr] | [INFO] [stderr] 94 | if line.starts_with("#") && [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:129:24 [INFO] [stderr] | [INFO] [stderr] 129 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:130:36 [INFO] [stderr] | [INFO] [stderr] 130 | if line.trim_right().ends_with("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:132:30 [INFO] [stderr] | [INFO] [stderr] 132 | alignement = line.rfind("\\").unwrap(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:137:36 [INFO] [stderr] | [INFO] [stderr] 137 | if line.trim_right().ends_with("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:138:23 [INFO] [stderr] | [INFO] [stderr] 138 | match line.rfind("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:175:24 [INFO] [stderr] | [INFO] [stderr] 175 | if line.starts_with("#") && line.contains("def") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:181:40 [INFO] [stderr] | [INFO] [stderr] 181 | let macro_name = macro_name.split("(").next().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:219:24 [INFO] [stderr] | [INFO] [stderr] 219 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:225:22 [INFO] [stderr] | [INFO] [stderr] 225 | if line.contains("(") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:227:24 [INFO] [stderr] | [INFO] [stderr] 227 | line = line.split("(").nth(1).unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:229:23 [INFO] [stderr] | [INFO] [stderr] 229 | line = line.split(")").next().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:232:28 [INFO] [stderr] | [INFO] [stderr] 232 | for arg in line.split(",").map(|x| x.trim()).filter(|x| !x.is_empty()) { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:243:22 [INFO] [stderr] | [INFO] [stderr] 243 | if line.contains(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:247:29 [INFO] [stderr] | [INFO] [stderr] 247 | in_macro =line.contains("\\"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:281:24 [INFO] [stderr] | [INFO] [stderr] 281 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:282:22 [INFO] [stderr] | [INFO] [stderr] 282 | if line.contains("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rules/preprocessor.rs:296:29 [INFO] [stderr] | [INFO] [stderr] 296 | if !multiline_macro && line.trim().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:299:43 [INFO] [stderr] | [INFO] [stderr] 299 | if multiline_macro && !line.contains("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:341:24 [INFO] [stderr] | [INFO] [stderr] 341 | if line.starts_with("#") && line.contains("include") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:342:22 [INFO] [stderr] | [INFO] [stderr] 342 | if line.contains("\"") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:345:27 [INFO] [stderr] | [INFO] [stderr] 345 | else if line.contains("<") && have_seen_local_include [INFO] [stderr] | ^^^ help: try using a char instead: `'<'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:378:37 [INFO] [stderr] | [INFO] [stderr] 378 | let header_guard = filename.split("/").last().unwrap().replace(".", "_").to_uppercase() + "_"; [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | if line.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/rules/function.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | let mut dont_have_code = line.trim().is_empty() || line.trim_left().starts_with("//") || in_multi_line_comment; [INFO] [stderr] | _________________^ [INFO] [stderr] 32 | | if line.contains("/*") { [INFO] [stderr] 33 | | in_multi_line_comment = true; [INFO] [stderr] 34 | | dont_have_code = line.trim_left().starts_with("/*"); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let dont_have_code = if line.contains("/*") { ..; line.trim_left().starts_with("/*") } else { line.trim().is_empty() || line.trim_left().starts_with("//") || in_multi_line_comment };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | if line.contains("}") && indentation > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:94:41 [INFO] [stderr] | [INFO] [stderr] 94 | if indentation == 0 && line.contains("(") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:95:23 [INFO] [stderr] | [INFO] [stderr] 95 | line = line.split("(").nth(1).unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | if line.contains(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | line = line.split(")").next().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:147:21 [INFO] [stderr] | [INFO] [stderr] 147 | if line.contains("}") && indentation > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/rules/function.rs:160:6 [INFO] [stderr] | [INFO] [stderr] 160 | let mut dont_have_code = line.trim_left().starts_with("//") || in_multi_line_comment ; [INFO] [stderr] | _____________________^ [INFO] [stderr] 161 | | if line.contains("/*") { [INFO] [stderr] 162 | | in_multi_line_comment = true; [INFO] [stderr] 163 | | dont_have_code = line.trim_left().starts_with("/*"); [INFO] [stderr] 164 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let dont_have_code = if line.contains("/*") { ..; line.trim_left().starts_with("/*") } else { line.trim_left().starts_with("//") || in_multi_line_comment };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:205:21 [INFO] [stderr] | [INFO] [stderr] 205 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:208:21 [INFO] [stderr] | [INFO] [stderr] 208 | if line.contains("}") && indentation > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:213:36 [INFO] [stderr] | [INFO] [stderr] 213 | if line.trim_left().starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:231:44 [INFO] [stderr] | [INFO] [stderr] 231 | in_macro = line.trim_right().ends_with("\\"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:265:24 [INFO] [stderr] | [INFO] [stderr] 265 | if line.starts_with("{"){ [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:302:21 [INFO] [stderr] | [INFO] [stderr] 302 | if line.contains("(") && !line.starts_with("#") && !line.ends_with("\\") && [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:302:47 [INFO] [stderr] | [INFO] [stderr] 302 | if line.contains("(") && !line.starts_with("#") && !line.ends_with("\\") && [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:302:71 [INFO] [stderr] | [INFO] [stderr] 302 | if line.contains("(") && !line.starts_with("#") && !line.ends_with("\\") && [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rules/function.rs:303:5 [INFO] [stderr] | [INFO] [stderr] 303 | !line.trim_left().starts_with("//") & &!line.trim_left().starts_with("**") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `!line.trim_left().starts_with("**")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:339:21 [INFO] [stderr] | [INFO] [stderr] 339 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:342:21 [INFO] [stderr] | [INFO] [stderr] 342 | if line.contains("}") && indentation > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:347:22 [INFO] [stderr] | [INFO] [stderr] 347 | if line.contains("(") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:349:42 [INFO] [stderr] | [INFO] [stderr] 349 | parameters_indentation = line.split("(").next().unwrap().len() + 1; [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:359:47 [INFO] [stderr] | [INFO] [stderr] 359 | if in_function_parameters && line.contains(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:396:21 [INFO] [stderr] | [INFO] [stderr] 396 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:399:21 [INFO] [stderr] | [INFO] [stderr] 399 | if line.contains("}") && indentation > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:402:36 [INFO] [stderr] | [INFO] [stderr] 402 | if line.trim_left().starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:406:41 [INFO] [stderr] | [INFO] [stderr] 406 | if indentation <= 0 && line.contains(")") && line.contains(";") [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:406:63 [INFO] [stderr] | [INFO] [stderr] 406 | if indentation <= 0 && line.contains(")") && line.contains(";") [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:407:23 [INFO] [stderr] | [INFO] [stderr] 407 | && !line.contains("=") && !in_macro { [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:412:44 [INFO] [stderr] | [INFO] [stderr] 412 | in_macro = line.trim_right().ends_with("\\"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | if line.contains("}") && indentation > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:54:36 [INFO] [stderr] | [INFO] [stderr] 54 | if in_typedef && line.contains(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | if line.contains("}") && indentation > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:130:37 [INFO] [stderr] | [INFO] [stderr] 130 | if line.trim_left().starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:131:45 [INFO] [stderr] | [INFO] [stderr] 131 | in_macro = line.trim_right().ends_with("\\"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:134:23 [INFO] [stderr] | [INFO] [stderr] 134 | if line.contains(";") && !line.contains("}") && (!line.contains("(") || line.contains("=")) && [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:134:46 [INFO] [stderr] | [INFO] [stderr] 134 | if line.contains(";") && !line.contains("}") && (!line.contains("(") || line.contains("=")) && [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:134:70 [INFO] [stderr] | [INFO] [stderr] 134 | if line.contains(";") && !line.contains("}") && (!line.contains("(") || line.contains("=")) && [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:134:92 [INFO] [stderr] | [INFO] [stderr] 134 | if line.contains(";") && !line.contains("}") && (!line.contains("(") || line.contains("=")) && [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:137:35 [INFO] [stderr] | [INFO] [stderr] 137 | let macro_name = line.split("=").next().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:146:45 [INFO] [stderr] | [INFO] [stderr] 146 | in_macro = line.trim_right().ends_with("\\"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/control_structures.rs:22:63 [INFO] [stderr] | [INFO] [stderr] 22 | if line.trim_left().starts_with(element) && line.contains("(") && !line.contains(&(String::from(*element) + " (")) { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/control_structures.rs:53:64 [INFO] [stderr] | [INFO] [stderr] 53 | if line.trim_left().starts_with(element) && !line.contains("(") && !line.contains(&(String::from(*element) + ";")) { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/control_structures.rs:129:22 [INFO] [stderr] | [INFO] [stderr] 129 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/control_structures.rs:132:48 [INFO] [stderr] | [INFO] [stderr] 132 | if switch_indentation > 0 && line.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/control_structures.rs:181:22 [INFO] [stderr] | [INFO] [stderr] 181 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/control_structures.rs:184:48 [INFO] [stderr] | [INFO] [stderr] 184 | if switch_indentation > 0 && line.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:73:32 [INFO] [stderr] | [INFO] [stderr] 73 | for entry in path.read_dir().expect(&format!("Something went wrong opening {}", pathname)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Something went wrong opening {}", pathname))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | fn verify(rules: &Vec>, filenames: &[String]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Box]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | file.read_to_string(&mut content).expect(&format!("Something went wrong reading {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Something went wrong reading {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `norme`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | if line.contains("\t") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rules/indentation.rs:133:8 [INFO] [stderr] | [INFO] [stderr] 133 | if line.len() != 0 && current_indentation != needed_indentation { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:219:25 [INFO] [stderr] | [INFO] [stderr] 219 | if !line.ends_with(";") && !line.ends_with("\\"){ [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:219:49 [INFO] [stderr] | [INFO] [stderr] 219 | if !line.ends_with(";") && !line.ends_with("\\"){ [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:223:33 [INFO] [stderr] | [INFO] [stderr] 223 | let left_part = line.split(";").next().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/rules/indentation.rs:265:7 [INFO] [stderr] | [INFO] [stderr] 265 | if nb_comma <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using nb_comma == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: the variable `actual_between` is used as a loop counter. Consider using `for (actual_between, item) in line.split(",").enumerate()` or similar iterators [INFO] [stderr] --> src/rules/indentation.rs:269:19 [INFO] [stderr] | [INFO] [stderr] 269 | for between in line.split(",") { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:269:30 [INFO] [stderr] | [INFO] [stderr] 269 | for between in line.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/rules/indentation.rs:333:8 [INFO] [stderr] | [INFO] [stderr] 333 | if !line.contains("{") && line.trim().len() > 0 && !(!have_typedef && line.contains("}")) && (!line.contains("typedef") || line.split_whitespace().count() > 2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(!line.contains("typedef") || line.split_whitespace().count() > 2) && (have_typedef || !line.contains("}")) && line.trim().len() > 0 && !line.contains("{")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:317:21 [INFO] [stderr] | [INFO] [stderr] 317 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:320:21 [INFO] [stderr] | [INFO] [stderr] 320 | if line.contains("}") && level > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:325:21 [INFO] [stderr] | [INFO] [stderr] 325 | !(line.contains("(") || line.contains(",") || line.contains(")") || [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:325:43 [INFO] [stderr] | [INFO] [stderr] 325 | !(line.contains("(") || line.contains(",") || line.contains(")") || [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:325:65 [INFO] [stderr] | [INFO] [stderr] 325 | !(line.contains("(") || line.contains(",") || line.contains(")") || [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:333:23 [INFO] [stderr] | [INFO] [stderr] 333 | if !line.contains("{") && line.trim().len() > 0 && !(!have_typedef && line.contains("}")) && (!line.contains("typedef") || line.split_whitespace().count() > 2) { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rules/indentation.rs:333:31 [INFO] [stderr] | [INFO] [stderr] 333 | if !line.contains("{") && line.trim().len() > 0 && !(!have_typedef && line.contains("}")) && (!line.contains("typedef") || line.split_whitespace().count() > 2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:333:89 [INFO] [stderr] | [INFO] [stderr] 333 | if !line.contains("{") && line.trim().len() > 0 && !(!have_typedef && line.contains("}")) && (!line.contains("typedef") || line.split_whitespace().count() > 2) { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/rules/indentation.rs:336:9 [INFO] [stderr] | [INFO] [stderr] 336 | if indentation <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using indentation == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/indentation.rs:344:22 [INFO] [stderr] | [INFO] [stderr] 344 | if line.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | if line.contains("{") && !(line.trim().len() == 1 || [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:22:94 [INFO] [stderr] | [INFO] [stderr] 22 | (line.chars().filter(|c| !c.is_whitespace()).count() == 2 && line.trim_right().ends_with("\\"))) { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | else if line.contains("}") && !(line.trim().len() == 1 || [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:26:95 [INFO] [stderr] | [INFO] [stderr] 26 | (line.chars().filter(|c| !c.is_whitespace()).count() == 2 && line.trim_right().ends_with("\\"))) { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | if !line.ends_with(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:152:22 [INFO] [stderr] | [INFO] [stderr] 152 | if line.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | if line.contains(",") && [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:160:18 [INFO] [stderr] | [INFO] [stderr] 160 | !line.split(",").last().unwrap().trim().is_empty() { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:195:66 [INFO] [stderr] | [INFO] [stderr] 195 | if line.trim_left().starts_with("static ") && (!line.contains("(") || line.contains("=")) && !line.contains("static const") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/misc.rs:195:88 [INFO] [stderr] | [INFO] [stderr] 195 | if line.trim_left().starts_with("static ") && (!line.contains("(") || line.contains("=")) && !line.contains("static const") { [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:19:36 [INFO] [stderr] | [INFO] [stderr] 19 | if line.trim_left().starts_with("#") && !line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:19:62 [INFO] [stderr] | [INFO] [stderr] 19 | if line.trim_left().starts_with("#") && !line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:94:24 [INFO] [stderr] | [INFO] [stderr] 94 | if line.starts_with("#") && [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:129:24 [INFO] [stderr] | [INFO] [stderr] 129 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:130:36 [INFO] [stderr] | [INFO] [stderr] 130 | if line.trim_right().ends_with("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:132:30 [INFO] [stderr] | [INFO] [stderr] 132 | alignement = line.rfind("\\").unwrap(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:137:36 [INFO] [stderr] | [INFO] [stderr] 137 | if line.trim_right().ends_with("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:138:23 [INFO] [stderr] | [INFO] [stderr] 138 | match line.rfind("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:175:24 [INFO] [stderr] | [INFO] [stderr] 175 | if line.starts_with("#") && line.contains("def") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:181:40 [INFO] [stderr] | [INFO] [stderr] 181 | let macro_name = macro_name.split("(").next().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:219:24 [INFO] [stderr] | [INFO] [stderr] 219 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:225:22 [INFO] [stderr] | [INFO] [stderr] 225 | if line.contains("(") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:227:24 [INFO] [stderr] | [INFO] [stderr] 227 | line = line.split("(").nth(1).unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:229:23 [INFO] [stderr] | [INFO] [stderr] 229 | line = line.split(")").next().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:232:28 [INFO] [stderr] | [INFO] [stderr] 232 | for arg in line.split(",").map(|x| x.trim()).filter(|x| !x.is_empty()) { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:243:22 [INFO] [stderr] | [INFO] [stderr] 243 | if line.contains(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:247:29 [INFO] [stderr] | [INFO] [stderr] 247 | in_macro =line.contains("\\"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:281:24 [INFO] [stderr] | [INFO] [stderr] 281 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:282:22 [INFO] [stderr] | [INFO] [stderr] 282 | if line.contains("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rules/preprocessor.rs:296:29 [INFO] [stderr] | [INFO] [stderr] 296 | if !multiline_macro && line.trim().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:299:43 [INFO] [stderr] | [INFO] [stderr] 299 | if multiline_macro && !line.contains("\\") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:341:24 [INFO] [stderr] | [INFO] [stderr] 341 | if line.starts_with("#") && line.contains("include") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:342:22 [INFO] [stderr] | [INFO] [stderr] 342 | if line.contains("\"") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:345:27 [INFO] [stderr] | [INFO] [stderr] 345 | else if line.contains("<") && have_seen_local_include [INFO] [stderr] | ^^^ help: try using a char instead: `'<'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/preprocessor.rs:378:37 [INFO] [stderr] | [INFO] [stderr] 378 | let header_guard = filename.split("/").last().unwrap().replace(".", "_").to_uppercase() + "_"; [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | if line.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/rules/function.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | let mut dont_have_code = line.trim().is_empty() || line.trim_left().starts_with("//") || in_multi_line_comment; [INFO] [stderr] | _________________^ [INFO] [stderr] 32 | | if line.contains("/*") { [INFO] [stderr] 33 | | in_multi_line_comment = true; [INFO] [stderr] 34 | | dont_have_code = line.trim_left().starts_with("/*"); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let dont_have_code = if line.contains("/*") { ..; line.trim_left().starts_with("/*") } else { line.trim().is_empty() || line.trim_left().starts_with("//") || in_multi_line_comment };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | if line.contains("}") && indentation > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:94:41 [INFO] [stderr] | [INFO] [stderr] 94 | if indentation == 0 && line.contains("(") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:95:23 [INFO] [stderr] | [INFO] [stderr] 95 | line = line.split("(").nth(1).unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | if line.contains(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | line = line.split(")").next().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:147:21 [INFO] [stderr] | [INFO] [stderr] 147 | if line.contains("}") && indentation > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/rules/function.rs:160:6 [INFO] [stderr] | [INFO] [stderr] 160 | let mut dont_have_code = line.trim_left().starts_with("//") || in_multi_line_comment ; [INFO] [stderr] | _____________________^ [INFO] [stderr] 161 | | if line.contains("/*") { [INFO] [stderr] 162 | | in_multi_line_comment = true; [INFO] [stderr] 163 | | dont_have_code = line.trim_left().starts_with("/*"); [INFO] [stderr] 164 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let dont_have_code = if line.contains("/*") { ..; line.trim_left().starts_with("/*") } else { line.trim_left().starts_with("//") || in_multi_line_comment };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:205:21 [INFO] [stderr] | [INFO] [stderr] 205 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:208:21 [INFO] [stderr] | [INFO] [stderr] 208 | if line.contains("}") && indentation > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:213:36 [INFO] [stderr] | [INFO] [stderr] 213 | if line.trim_left().starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:231:44 [INFO] [stderr] | [INFO] [stderr] 231 | in_macro = line.trim_right().ends_with("\\"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:265:24 [INFO] [stderr] | [INFO] [stderr] 265 | if line.starts_with("{"){ [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:302:21 [INFO] [stderr] | [INFO] [stderr] 302 | if line.contains("(") && !line.starts_with("#") && !line.ends_with("\\") && [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:302:47 [INFO] [stderr] | [INFO] [stderr] 302 | if line.contains("(") && !line.starts_with("#") && !line.ends_with("\\") && [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:302:71 [INFO] [stderr] | [INFO] [stderr] 302 | if line.contains("(") && !line.starts_with("#") && !line.ends_with("\\") && [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/rules/function.rs:303:5 [INFO] [stderr] | [INFO] [stderr] 303 | !line.trim_left().starts_with("//") & &!line.trim_left().starts_with("**") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `!line.trim_left().starts_with("**")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:339:21 [INFO] [stderr] | [INFO] [stderr] 339 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:342:21 [INFO] [stderr] | [INFO] [stderr] 342 | if line.contains("}") && indentation > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:347:22 [INFO] [stderr] | [INFO] [stderr] 347 | if line.contains("(") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:349:42 [INFO] [stderr] | [INFO] [stderr] 349 | parameters_indentation = line.split("(").next().unwrap().len() + 1; [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:359:47 [INFO] [stderr] | [INFO] [stderr] 359 | if in_function_parameters && line.contains(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:396:21 [INFO] [stderr] | [INFO] [stderr] 396 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:399:21 [INFO] [stderr] | [INFO] [stderr] 399 | if line.contains("}") && indentation > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:402:36 [INFO] [stderr] | [INFO] [stderr] 402 | if line.trim_left().starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:406:41 [INFO] [stderr] | [INFO] [stderr] 406 | if indentation <= 0 && line.contains(")") && line.contains(";") [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:406:63 [INFO] [stderr] | [INFO] [stderr] 406 | if indentation <= 0 && line.contains(")") && line.contains(";") [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:407:23 [INFO] [stderr] | [INFO] [stderr] 407 | && !line.contains("=") && !in_macro { [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/function.rs:412:44 [INFO] [stderr] | [INFO] [stderr] 412 | in_macro = line.trim_right().ends_with("\\"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | if line.contains("}") && indentation > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:54:36 [INFO] [stderr] | [INFO] [stderr] 54 | if in_typedef && line.contains(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | if line.contains("}") && indentation > 0 { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:130:37 [INFO] [stderr] | [INFO] [stderr] 130 | if line.trim_left().starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:131:45 [INFO] [stderr] | [INFO] [stderr] 131 | in_macro = line.trim_right().ends_with("\\"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:134:23 [INFO] [stderr] | [INFO] [stderr] 134 | if line.contains(";") && !line.contains("}") && (!line.contains("(") || line.contains("=")) && [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:134:46 [INFO] [stderr] | [INFO] [stderr] 134 | if line.contains(";") && !line.contains("}") && (!line.contains("(") || line.contains("=")) && [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:134:70 [INFO] [stderr] | [INFO] [stderr] 134 | if line.contains(";") && !line.contains("}") && (!line.contains("(") || line.contains("=")) && [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:134:92 [INFO] [stderr] | [INFO] [stderr] 134 | if line.contains(";") && !line.contains("}") && (!line.contains("(") || line.contains("=")) && [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:137:35 [INFO] [stderr] | [INFO] [stderr] 137 | let macro_name = line.split("=").next().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/naming.rs:146:45 [INFO] [stderr] | [INFO] [stderr] 146 | in_macro = line.trim_right().ends_with("\\"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/control_structures.rs:22:63 [INFO] [stderr] | [INFO] [stderr] 22 | if line.trim_left().starts_with(element) && line.contains("(") && !line.contains(&(String::from(*element) + " (")) { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/control_structures.rs:53:64 [INFO] [stderr] | [INFO] [stderr] 53 | if line.trim_left().starts_with(element) && !line.contains("(") && !line.contains(&(String::from(*element) + ";")) { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/control_structures.rs:129:22 [INFO] [stderr] | [INFO] [stderr] 129 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/control_structures.rs:132:48 [INFO] [stderr] | [INFO] [stderr] 132 | if switch_indentation > 0 && line.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/control_structures.rs:181:22 [INFO] [stderr] | [INFO] [stderr] 181 | if line.contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rules/control_structures.rs:184:48 [INFO] [stderr] | [INFO] [stderr] 184 | if switch_indentation > 0 && line.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:73:32 [INFO] [stderr] | [INFO] [stderr] 73 | for entry in path.read_dir().expect(&format!("Something went wrong opening {}", pathname)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Something went wrong opening {}", pathname))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | fn verify(rules: &Vec>, filenames: &[String]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Box]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | file.read_to_string(&mut content).expect(&format!("Something went wrong reading {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Something went wrong reading {}", filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `norme`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "af2b68ac39d67e50edb8e7119fc1e9e62a0e6b884e46e4f6bae376e2e00f5b4b"` [INFO] running `"docker" "rm" "-f" "af2b68ac39d67e50edb8e7119fc1e9e62a0e6b884e46e4f6bae376e2e00f5b4b"` [INFO] [stdout] af2b68ac39d67e50edb8e7119fc1e9e62a0e6b884e46e4f6bae376e2e00f5b4b