[INFO] updating cached repository dabbotorg/orchestrator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dabbotorg/orchestrator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dabbotorg/orchestrator" "work/ex/clippy-test-run/sources/stable/gh/dabbotorg/orchestrator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dabbotorg/orchestrator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dabbotorg/orchestrator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dabbotorg/orchestrator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dabbotorg/orchestrator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2bae09a8c0ab600f20c5beb2b7712a48623f2091 [INFO] sha for GitHub repo dabbotorg/orchestrator: 2bae09a8c0ab600f20c5beb2b7712a48623f2091 [INFO] validating manifest of dabbotorg/orchestrator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dabbotorg/orchestrator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dabbotorg/orchestrator [INFO] finished frobbing dabbotorg/orchestrator [INFO] frobbed toml for dabbotorg/orchestrator written to work/ex/clippy-test-run/sources/stable/gh/dabbotorg/orchestrator/Cargo.toml [INFO] started frobbing dabbotorg/orchestrator [INFO] finished frobbing dabbotorg/orchestrator [INFO] frobbed toml for dabbotorg/orchestrator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dabbotorg/orchestrator/Cargo.toml [INFO] crate dabbotorg/orchestrator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dabbotorg/orchestrator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dabbotorg/orchestrator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 166d8ea5841e6ddf5480853b7033075dc8be8fac0181847ed1319ef58c0334cf [INFO] running `"docker" "start" "-a" "166d8ea5841e6ddf5480853b7033075dc8be8fac0181847ed1319ef58c0334cf"` [INFO] [stderr] Checking kankyo v0.2.0 [INFO] [stderr] Checking redis v0.8.0 [INFO] [stderr] Checking env_logger v0.5.3 [INFO] [stderr] Checking orchestrator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/shards.rs:7:17 [INFO] [stderr] | [INFO] [stderr] 7 | const CLUSTER: &'static str = "shards:cluster"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/shards.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | const MASTER: &'static str = "shards:master"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/shards.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | rng [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/shards.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | let rng = (lower..upper).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/shards.rs:7:17 [INFO] [stderr] | [INFO] [stderr] 7 | const CLUSTER: &'static str = "shards:cluster"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/shards.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | const MASTER: &'static str = "shards:master"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/shards.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | rng [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/shards.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | let rng = (lower..upper).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.19s [INFO] running `"docker" "inspect" "166d8ea5841e6ddf5480853b7033075dc8be8fac0181847ed1319ef58c0334cf"` [INFO] running `"docker" "rm" "-f" "166d8ea5841e6ddf5480853b7033075dc8be8fac0181847ed1319ef58c0334cf"` [INFO] [stdout] 166d8ea5841e6ddf5480853b7033075dc8be8fac0181847ed1319ef58c0334cf