[INFO] updating cached repository daa84/neovim-lib [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/daa84/neovim-lib [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/daa84/neovim-lib" "work/ex/clippy-test-run/sources/stable/gh/daa84/neovim-lib"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/daa84/neovim-lib'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/daa84/neovim-lib" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daa84/neovim-lib"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daa84/neovim-lib'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6acb51bb32cc2eea1e8c468693f71bcd0b7d3532 [INFO] sha for GitHub repo daa84/neovim-lib: 6acb51bb32cc2eea1e8c468693f71bcd0b7d3532 [INFO] validating manifest of daa84/neovim-lib on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of daa84/neovim-lib on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing daa84/neovim-lib [INFO] finished frobbing daa84/neovim-lib [INFO] frobbed toml for daa84/neovim-lib written to work/ex/clippy-test-run/sources/stable/gh/daa84/neovim-lib/Cargo.toml [INFO] started frobbing daa84/neovim-lib [INFO] finished frobbing daa84/neovim-lib [INFO] frobbed toml for daa84/neovim-lib written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daa84/neovim-lib/Cargo.toml [INFO] crate daa84/neovim-lib has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting daa84/neovim-lib against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/daa84/neovim-lib:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 15b4434b60c32597872f6cf03f4ce1ad82749d225f33ddaf2731a72ec65c5529 [INFO] running `"docker" "start" "-a" "15b4434b60c32597872f6cf03f4ce1ad82749d225f33ddaf2731a72ec65c5529"` [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking serde_bytes v0.10.4 [INFO] [stderr] Checking rmpv v0.4.0 [INFO] [stderr] Checking neovim-lib v0.5.4 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/rpc/model.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/rpc/model.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/rpc/client.rs:215:50 [INFO] [stderr] | [INFO] [stderr] 215 | fn send_error_to_callers(queue: &Queue, err: &Box) { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `&Error` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/async.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | cb: Option) + Send + 'static>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `neovim::UiAttachOptions` [INFO] [stderr] --> src/neovim.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn new() -> UiAttachOptions { [INFO] [stderr] 47 | | UiAttachOptions { [INFO] [stderr] 48 | | options: Vec::new(), [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/rpc/client.rs:215:50 [INFO] [stderr] | [INFO] [stderr] 215 | fn send_error_to_callers(queue: &Queue, err: &Box) { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `&Error` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/async.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | cb: Option) + Send + 'static>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `neovim::UiAttachOptions` [INFO] [stderr] --> src/neovim.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn new() -> UiAttachOptions { [INFO] [stderr] 47 | | UiAttachOptions { [INFO] [stderr] 48 | | options: Vec::new(), [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> tests/lib.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | if let Ok(_) = std::fs::metadata(&socket_path) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 77 | | break; [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____________- help: try this: `if std::fs::metadata(&socket_path).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/lib.rs:88:10 [INFO] [stderr] | [INFO] [stderr] 88 | .expect(&format!("Unable to connect to neovim's unix socket at {:?}", [INFO] [stderr] | __________^ [INFO] [stderr] 89 | | &socket_path)); [INFO] [stderr] | |_______________________________________^ help: try this: `unwrap_or_else(|_| panic!("Unable to connect to neovim's unix socket at {:?}", &socket_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.90s [INFO] running `"docker" "inspect" "15b4434b60c32597872f6cf03f4ce1ad82749d225f33ddaf2731a72ec65c5529"` [INFO] running `"docker" "rm" "-f" "15b4434b60c32597872f6cf03f4ce1ad82749d225f33ddaf2731a72ec65c5529"` [INFO] [stdout] 15b4434b60c32597872f6cf03f4ce1ad82749d225f33ddaf2731a72ec65c5529