[INFO] updating cached repository da-x/tetris-demo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/da-x/tetris-demo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/da-x/tetris-demo" "work/ex/clippy-test-run/sources/stable/gh/da-x/tetris-demo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/da-x/tetris-demo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/da-x/tetris-demo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/da-x/tetris-demo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/da-x/tetris-demo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a99316437fac129c1420db25bdda01658beef6ec [INFO] sha for GitHub repo da-x/tetris-demo: a99316437fac129c1420db25bdda01658beef6ec [INFO] validating manifest of da-x/tetris-demo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of da-x/tetris-demo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing da-x/tetris-demo [INFO] finished frobbing da-x/tetris-demo [INFO] frobbed toml for da-x/tetris-demo written to work/ex/clippy-test-run/sources/stable/gh/da-x/tetris-demo/Cargo.toml [INFO] started frobbing da-x/tetris-demo [INFO] finished frobbing da-x/tetris-demo [INFO] frobbed toml for da-x/tetris-demo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/da-x/tetris-demo/Cargo.toml [INFO] crate da-x/tetris-demo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting da-x/tetris-demo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/da-x/tetris-demo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 169f19afd9d472c6ee1d2bc65bd5e6e76e02a8560ca767bc745ce6463a6e30c7 [INFO] running `"docker" "start" "-a" "169f19afd9d472c6ee1d2bc65bd5e6e76e02a8560ca767bc745ce6463a6e30c7"` [INFO] [stderr] Checking piston-float v0.2.0 [INFO] [stderr] Checking piston-shaders_graphics2d v0.2.1 [INFO] [stderr] Checking piston-shaders_graphics2d v0.1.0 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Checking gfx_core v0.5.1 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Checking x11-dl v2.17.5 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking piston-viewport v0.2.0 [INFO] [stderr] Checking vecmath v0.2.0 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking pistoncore-input v0.15.0 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Compiling glutin v0.7.4 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Checking piston2d-graphics v0.19.0 [INFO] [stderr] Checking pistoncore-window v0.24.0 [INFO] [stderr] Checking pistoncore-event_loop v0.27.0 [INFO] [stderr] Checking piston v0.27.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking piston2d-opengl_graphics v0.37.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking gfx v0.13.0 [INFO] [stderr] Checking gfx_device_gl v0.12.0 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking piston-gfx_texture v0.20.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.35.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.33.0 [INFO] [stderr] Checking piston_window v0.61.0 [INFO] [stderr] Checking tetris-demo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/main.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | let __ = 0; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/main.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | let __ = 0; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / if offset.0 >= 0 && offset.0 < self.dim_x() as isize { [INFO] [stderr] 51 | | if offset.1 >= 0 && offset.1 < self.dim_y() as isize { [INFO] [stderr] 52 | | return true; [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 50 | if offset.0 >= 0 && offset.0 < self.dim_x() as isize && offset.1 >= 0 && offset.1 < self.dim_y() as isize { [INFO] [stderr] 51 | return true; [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/main.rs:261:18 [INFO] [stderr] | [INFO] [stderr] 261 | let xx = 01; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 261 | let xx = 1; [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 261 | let xx = 0o1; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / if offset.0 >= 0 && offset.0 < self.dim_x() as isize { [INFO] [stderr] 51 | | if offset.1 >= 0 && offset.1 < self.dim_y() as isize { [INFO] [stderr] 52 | | return true; [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 50 | if offset.0 >= 0 && offset.0 < self.dim_x() as isize && offset.1 >= 0 && offset.1 < self.dim_y() as isize { [INFO] [stderr] 51 | return true; [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/main.rs:261:18 [INFO] [stderr] | [INFO] [stderr] 261 | let xx = 01; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 261 | let xx = 1; [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 261 | let xx = 0o1; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is used to index `spec` [INFO] [stderr] --> src/main.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | for y in 0 .. spec.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 66 | for (y, ) in spec.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:87:62 [INFO] [stderr] | [INFO] [stderr] 87 | copy.cells[y as usize][x as usize] = cell.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `cell` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | self.cells[y][x].map(|color| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 116 | || let code = match color { [INFO] [stderr] 117 | || Color::Red => [1.0, 0.0, 0.0, 1.0], [INFO] [stderr] 118 | || Color::Green => [0.0, 1.0, 0.0, 1.0], [INFO] [stderr] ... || [INFO] [stderr] 135 | || draw(code, inner); [INFO] [stderr] 136 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(color) = self.cells[y][x] { ... }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:168:43 [INFO] [stderr] | [INFO] [stderr] 168 | fn with_eliminate_lines(&self, lines: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:307:37 [INFO] [stderr] | [INFO] [stderr] 307 | fn new_falling(possible_pieces: &Vec) -> Falling { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Board]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:337:36 [INFO] [stderr] | [INFO] [stderr] 337 | if completed.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!completed.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:372:17 [INFO] [stderr] | [INFO] [stderr] 372 | self.board.as_merged(falling.offset, &rotated_piece).map(|_| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 373 | || falling.piece = rotated_piece; [INFO] [stderr] 374 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(_) = self.board.as_merged(falling.offset, &rotated_piece) { falling.piece = rotated_piece; }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:418:35 [INFO] [stderr] | [INFO] [stderr] 418 | let c = &Context::new_abs(res[0] as f64, res[1] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(res[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:418:50 [INFO] [stderr] | [INFO] [stderr] 418 | let c = &Context::new_abs(res[0] as f64, res[1] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(res[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:445:9 [INFO] [stderr] | [INFO] [stderr] 445 | / match args { [INFO] [stderr] 446 | | Button::Keyboard(key) => { self.on_key(key); } [INFO] [stderr] 447 | | _ => {}, [INFO] [stderr] 448 | | } [INFO] [stderr] | |_________^ help: try this: `if let Button::Keyboard(key) = args { self.on_key(key); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:451:31 [INFO] [stderr] | [INFO] [stderr] 451 | fn on_key(&mut self, key: &Key) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is used to index `spec` [INFO] [stderr] --> src/main.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | for y in 0 .. spec.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 66 | for (y, ) in spec.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:87:62 [INFO] [stderr] | [INFO] [stderr] 87 | copy.cells[y as usize][x as usize] = cell.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `cell` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | self.cells[y][x].map(|color| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 116 | || let code = match color { [INFO] [stderr] 117 | || Color::Red => [1.0, 0.0, 0.0, 1.0], [INFO] [stderr] 118 | || Color::Green => [0.0, 1.0, 0.0, 1.0], [INFO] [stderr] ... || [INFO] [stderr] 135 | || draw(code, inner); [INFO] [stderr] 136 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(color) = self.cells[y][x] { ... }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:168:43 [INFO] [stderr] | [INFO] [stderr] 168 | fn with_eliminate_lines(&self, lines: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:307:37 [INFO] [stderr] | [INFO] [stderr] 307 | fn new_falling(possible_pieces: &Vec) -> Falling { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Board]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:337:36 [INFO] [stderr] | [INFO] [stderr] 337 | if completed.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!completed.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:372:17 [INFO] [stderr] | [INFO] [stderr] 372 | self.board.as_merged(falling.offset, &rotated_piece).map(|_| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 373 | || falling.piece = rotated_piece; [INFO] [stderr] 374 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(_) = self.board.as_merged(falling.offset, &rotated_piece) { falling.piece = rotated_piece; }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:418:35 [INFO] [stderr] | [INFO] [stderr] 418 | let c = &Context::new_abs(res[0] as f64, res[1] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(res[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:418:50 [INFO] [stderr] | [INFO] [stderr] 418 | let c = &Context::new_abs(res[0] as f64, res[1] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(res[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:445:9 [INFO] [stderr] | [INFO] [stderr] 445 | / match args { [INFO] [stderr] 446 | | Button::Keyboard(key) => { self.on_key(key); } [INFO] [stderr] 447 | | _ => {}, [INFO] [stderr] 448 | | } [INFO] [stderr] | |_________^ help: try this: `if let Button::Keyboard(key) = args { self.on_key(key); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:451:31 [INFO] [stderr] | [INFO] [stderr] 451 | fn on_key(&mut self, key: &Key) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 08s [INFO] running `"docker" "inspect" "169f19afd9d472c6ee1d2bc65bd5e6e76e02a8560ca767bc745ce6463a6e30c7"` [INFO] running `"docker" "rm" "-f" "169f19afd9d472c6ee1d2bc65bd5e6e76e02a8560ca767bc745ce6463a6e30c7"` [INFO] [stdout] 169f19afd9d472c6ee1d2bc65bd5e6e76e02a8560ca767bc745ce6463a6e30c7