[INFO] updating cached repository dUmich/genomesBygenes [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dUmich/genomesBygenes [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dUmich/genomesBygenes" "work/ex/clippy-test-run/sources/stable/gh/dUmich/genomesBygenes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dUmich/genomesBygenes'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dUmich/genomesBygenes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dUmich/genomesBygenes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dUmich/genomesBygenes'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0c7dce94d255c05efd0accbd5c4d81641ef737e5 [INFO] sha for GitHub repo dUmich/genomesBygenes: 0c7dce94d255c05efd0accbd5c4d81641ef737e5 [INFO] validating manifest of dUmich/genomesBygenes on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dUmich/genomesBygenes on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dUmich/genomesBygenes [INFO] finished frobbing dUmich/genomesBygenes [INFO] frobbed toml for dUmich/genomesBygenes written to work/ex/clippy-test-run/sources/stable/gh/dUmich/genomesBygenes/Cargo.toml [INFO] started frobbing dUmich/genomesBygenes [INFO] finished frobbing dUmich/genomesBygenes [INFO] frobbed toml for dUmich/genomesBygenes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dUmich/genomesBygenes/Cargo.toml [INFO] crate dUmich/genomesBygenes has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dUmich/genomesBygenes against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dUmich/genomesBygenes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0ed8944bd38fd1c38994239352f739b953b200045b7cbf14700766cca38f9b0b [INFO] running `"docker" "start" "-a" "0ed8944bd38fd1c38994239352f739b953b200045b7cbf14700766cca38f9b0b"` [INFO] [stderr] Checking csv-core v0.1.2 [INFO] [stderr] Checking clap v2.24.2 [INFO] [stderr] Checking jobsteal v0.5.1 [INFO] [stderr] Checking twox-hash v1.1.0 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking csv v1.0.0-beta.3 [INFO] [stderr] Checking intersections v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/find_genomes.rs:117:17 [INFO] [stderr] | [INFO] [stderr] 117 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/find_genomes.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | product: product, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `product` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/find_genomes.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | prev_gene: prev_gene, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_gene` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/find_genomes.rs:252:25 [INFO] [stderr] | [INFO] [stderr] 252 | blast_iter: blast_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `blast_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/find_genomes.rs:253:25 [INFO] [stderr] | [INFO] [stderr] 253 | gff_iter: gff_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `gff_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/find_genomes.rs:117:17 [INFO] [stderr] | [INFO] [stderr] 117 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/find_genomes.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | product: product, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `product` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/find_genomes.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | prev_gene: prev_gene, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_gene` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/find_genomes.rs:252:25 [INFO] [stderr] | [INFO] [stderr] 252 | blast_iter: blast_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `blast_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/find_genomes.rs:253:25 [INFO] [stderr] | [INFO] [stderr] 253 | gff_iter: gff_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `gff_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/find_genomes.rs:175:21 [INFO] [stderr] | [INFO] [stderr] 175 | const GFF_POSTFIX: &'static str = ".gff"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/find_genomes.rs:176:23 [INFO] [stderr] | [INFO] [stderr] 176 | const BLAST_POSTFIX: &'static str = ".bla"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/find_genomes.rs:178:25 [INFO] [stderr] | [INFO] [stderr] 178 | const OPTIONAL_PREFIX: &'static str = "R_"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/find_genomes.rs:175:21 [INFO] [stderr] | [INFO] [stderr] 175 | const GFF_POSTFIX: &'static str = ".gff"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/find_genomes.rs:176:23 [INFO] [stderr] | [INFO] [stderr] 176 | const BLAST_POSTFIX: &'static str = ".bla"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/find_genomes.rs:178:25 [INFO] [stderr] | [INFO] [stderr] 178 | const OPTIONAL_PREFIX: &'static str = "R_"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/find_genomes.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | fn next(&mut self) -> Option, Gene, Range)>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/find_genomes.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | }, start..(end + 1)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/find_genomes.rs:158:24 [INFO] [stderr] | [INFO] [stderr] 158 | (accn, line.s_start..(line.s_end + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `line.s_start..=line.s_end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/find_genomes.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | fn next(&mut self) -> Option, Gene, Range)>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/find_genomes.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | }, start..(end + 1)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `start..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/find_genomes.rs:158:24 [INFO] [stderr] | [INFO] [stderr] 158 | (accn, line.s_start..(line.s_end + 1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `line.s_start..=line.s_end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.87s [INFO] running `"docker" "inspect" "0ed8944bd38fd1c38994239352f739b953b200045b7cbf14700766cca38f9b0b"` [INFO] running `"docker" "rm" "-f" "0ed8944bd38fd1c38994239352f739b953b200045b7cbf14700766cca38f9b0b"` [INFO] [stdout] 0ed8944bd38fd1c38994239352f739b953b200045b7cbf14700766cca38f9b0b