[INFO] updating cached repository d6y/onthehour [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/d6y/onthehour [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/d6y/onthehour" "work/ex/clippy-test-run/sources/stable/gh/d6y/onthehour"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/d6y/onthehour'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/d6y/onthehour" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d6y/onthehour"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d6y/onthehour'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 13be7473195c725cd19d2a1e3895245d48be8b33 [INFO] sha for GitHub repo d6y/onthehour: 13be7473195c725cd19d2a1e3895245d48be8b33 [INFO] validating manifest of d6y/onthehour on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of d6y/onthehour on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing d6y/onthehour [INFO] finished frobbing d6y/onthehour [INFO] frobbed toml for d6y/onthehour written to work/ex/clippy-test-run/sources/stable/gh/d6y/onthehour/Cargo.toml [INFO] started frobbing d6y/onthehour [INFO] finished frobbing d6y/onthehour [INFO] frobbed toml for d6y/onthehour written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d6y/onthehour/Cargo.toml [INFO] crate d6y/onthehour has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting d6y/onthehour against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/d6y/onthehour:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ded6957a2f3e2faf67e2d16799ac03b56e739107d66cbfcc7ca0f93784e9a101 [INFO] running `"docker" "start" "-a" "ded6957a2f3e2faf67e2d16799ac03b56e739107d66cbfcc7ca0f93784e9a101"` [INFO] [stderr] Compiling serde v1.0.60 [INFO] [stderr] Compiling Inflector v0.11.3 [INFO] [stderr] Compiling nom v1.2.4 [INFO] [stderr] Compiling thread_local v0.3.6 [INFO] [stderr] Compiling memchr v2.0.2 [INFO] [stderr] Compiling regex-syntax v0.6.4 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Compiling serde_derive v1.0.60 [INFO] [stderr] Compiling aho-corasick v0.6.9 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Compiling mime_guess v1.8.4 [INFO] [stderr] Compiling tweetust v0.9.0 [INFO] [stderr] Compiling rayon v0.7.1 [INFO] [stderr] Checking multipart v0.12.0 [INFO] [stderr] Compiling ring v0.9.7 [INFO] [stderr] Compiling regex v1.1.0 [INFO] [stderr] Compiling parse-zoneinfo v0.2.0 [INFO] [stderr] Checking oauthcli v1.0.6 [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking envy v0.3.3 [INFO] [stderr] Compiling chrono-tz v0.5.0 [INFO] [stderr] Checking onthehour v3.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | tweet_message [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | let tweet_message = match uk.time().hour() { [INFO] [stderr] | _________________________^ [INFO] [stderr] 73 | | 0 => "It's midnight".to_string(), [INFO] [stderr] 74 | | _ => uk.format("It's %-l o'clock (%H:00)").to_string(), [INFO] [stderr] 75 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:65:26 [INFO] [stderr] | [INFO] [stderr] 65 | .map_err(|error| SendTweetError::TwitterError(error)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SendTweetError::TwitterError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | tweet_message [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | let tweet_message = match uk.time().hour() { [INFO] [stderr] | _________________________^ [INFO] [stderr] 73 | | 0 => "It's midnight".to_string(), [INFO] [stderr] 74 | | _ => uk.format("It's %-l o'clock (%H:00)").to_string(), [INFO] [stderr] 75 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:65:26 [INFO] [stderr] | [INFO] [stderr] 65 | .map_err(|error| SendTweetError::TwitterError(error)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SendTweetError::TwitterError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 02s [INFO] running `"docker" "inspect" "ded6957a2f3e2faf67e2d16799ac03b56e739107d66cbfcc7ca0f93784e9a101"` [INFO] running `"docker" "rm" "-f" "ded6957a2f3e2faf67e2d16799ac03b56e739107d66cbfcc7ca0f93784e9a101"` [INFO] [stdout] ded6957a2f3e2faf67e2d16799ac03b56e739107d66cbfcc7ca0f93784e9a101