[INFO] updating cached repository d3zd3z/borp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/d3zd3z/borp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/d3zd3z/borp" "work/ex/clippy-test-run/sources/stable/gh/d3zd3z/borp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/d3zd3z/borp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/d3zd3z/borp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d3zd3z/borp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d3zd3z/borp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] faa660ad7fb7d1684f9a5ad6b7b0603c1d420e85 [INFO] sha for GitHub repo d3zd3z/borp: faa660ad7fb7d1684f9a5ad6b7b0603c1d420e85 [INFO] validating manifest of d3zd3z/borp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of d3zd3z/borp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing d3zd3z/borp [INFO] finished frobbing d3zd3z/borp [INFO] frobbed toml for d3zd3z/borp written to work/ex/clippy-test-run/sources/stable/gh/d3zd3z/borp/Cargo.toml [INFO] started frobbing d3zd3z/borp [INFO] finished frobbing d3zd3z/borp [INFO] frobbed toml for d3zd3z/borp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d3zd3z/borp/Cargo.toml [INFO] crate d3zd3z/borp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting d3zd3z/borp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/d3zd3z/borp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ca73f08f9d0c5527e84daa5c72615d24297a9280c159381ba134ac2fda18d433 [INFO] running `"docker" "start" "-a" "ca73f08f9d0c5527e84daa5c72615d24297a9280c159381ba134ac2fda18d433"` [INFO] [stderr] Checking data-encoding v1.2.0 [INFO] [stderr] Checking hostname v0.1.3 [INFO] [stderr] Checking borp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lock.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lock.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lock.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lock.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lock.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lock.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lock.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lock.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lock.rs:262:30 [INFO] [stderr] | [INFO] [stderr] 262 | Roster::Empty => return Ok(()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lock.rs:262:30 [INFO] [stderr] | [INFO] [stderr] 262 | Roster::Empty => return Ok(()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lock.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | / match self.roster { [INFO] [stderr] 246 | | Roster::Exclusive(_) => { [INFO] [stderr] 247 | | // Be sure to take away this roster lock so that we don't remove it upon drop. [INFO] [stderr] 248 | | self.roster = Roster::Empty; [INFO] [stderr] ... | [INFO] [stderr] 251 | | _ => (), [INFO] [stderr] 252 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 245 | if let Roster::Exclusive(_) = self.roster { [INFO] [stderr] 246 | // Be sure to take away this roster lock so that we don't remove it upon drop. [INFO] [stderr] 247 | self.roster = Roster::Empty; [INFO] [stderr] 248 | panic!("Incoherent lock files, exclusive roster without lock dir"); [INFO] [stderr] 249 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lock.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | / match self.roster { [INFO] [stderr] 246 | | Roster::Exclusive(_) => { [INFO] [stderr] 247 | | // Be sure to take away this roster lock so that we don't remove it upon drop. [INFO] [stderr] 248 | | self.roster = Roster::Empty; [INFO] [stderr] ... | [INFO] [stderr] 251 | | _ => (), [INFO] [stderr] 252 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 245 | if let Roster::Exclusive(_) = self.roster { [INFO] [stderr] 246 | // Be sure to take away this roster lock so that we don't remove it upon drop. [INFO] [stderr] 247 | self.roster = Roster::Empty; [INFO] [stderr] 248 | panic!("Incoherent lock files, exclusive roster without lock dir"); [INFO] [stderr] 249 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.18s [INFO] running `"docker" "inspect" "ca73f08f9d0c5527e84daa5c72615d24297a9280c159381ba134ac2fda18d433"` [INFO] running `"docker" "rm" "-f" "ca73f08f9d0c5527e84daa5c72615d24297a9280c159381ba134ac2fda18d433"` [INFO] [stdout] ca73f08f9d0c5527e84daa5c72615d24297a9280c159381ba134ac2fda18d433