[INFO] updating cached repository d3z/passwords
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/d3z/passwords
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/d3z/passwords" "work/ex/clippy-test-run/sources/stable/gh/d3z/passwords"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/d3z/passwords'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/d3z/passwords" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d3z/passwords"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d3z/passwords'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d4e4361c4039b248064a0c1bbc6a4a4f94298e3f
[INFO] sha for GitHub repo d3z/passwords: d4e4361c4039b248064a0c1bbc6a4a4f94298e3f
[INFO] validating manifest of d3z/passwords on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of d3z/passwords on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing d3z/passwords
[INFO] finished frobbing d3z/passwords
[INFO] frobbed toml for d3z/passwords written to work/ex/clippy-test-run/sources/stable/gh/d3z/passwords/Cargo.toml
[INFO] started frobbing d3z/passwords
[INFO] finished frobbing d3z/passwords
[INFO] frobbed toml for d3z/passwords written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d3z/passwords/Cargo.toml
[INFO] crate d3z/passwords has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting d3z/passwords against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/d3z/passwords:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 96d9533ef2fe6b50904854f6d0b4d97314f411d86deb5b082b40d98efefe95c2
[INFO] running `"docker" "start" "-a" "96d9533ef2fe6b50904854f6d0b4d97314f411d86deb5b082b40d98efefe95c2"`
[INFO] [stderr]     Checking genpass v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:50:21
[INFO] [stderr]    |
[INFO] [stderr] 50 |         Ok(file) => return file.to_string(),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:51:19
[INFO] [stderr]    |
[INFO] [stderr] 51 |         Err(_) => return "/usr/share/dict/words".to_string(),
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"/usr/share/dict/words".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 | /     return buf.lines()
[INFO] [stderr] 62 | |               .map(|line| line.expect("Can't read line"))
[INFO] [stderr] 63 | |               .collect();
[INFO] [stderr]    | |_________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 61 |     buf.lines()
[INFO] [stderr] 62 |               .map(|line| line.expect("Can't read line"))
[INFO] [stderr] 63 |               .collect()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 |     return password_vec.join(separator).to_lowercase();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `password_vec.join(separator).to_lowercase()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:50:21
[INFO] [stderr]    |
[INFO] [stderr] 50 |         Ok(file) => return file.to_string(),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:51:19
[INFO] [stderr]    |
[INFO] [stderr] 51 |         Err(_) => return "/usr/share/dict/words".to_string(),
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"/usr/share/dict/words".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 | /     return buf.lines()
[INFO] [stderr] 62 | |               .map(|line| line.expect("Can't read line"))
[INFO] [stderr] 63 | |               .collect();
[INFO] [stderr]    | |_________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 61 |     buf.lines()
[INFO] [stderr] 62 |               .map(|line| line.expect("Can't read line"))
[INFO] [stderr] 63 |               .collect()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 |     return password_vec.join(separator).to_lowercase();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `password_vec.join(separator).to_lowercase()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.36s
[INFO] running `"docker" "inspect" "96d9533ef2fe6b50904854f6d0b4d97314f411d86deb5b082b40d98efefe95c2"`
[INFO] running `"docker" "rm" "-f" "96d9533ef2fe6b50904854f6d0b4d97314f411d86deb5b082b40d98efefe95c2"`
[INFO] [stdout] 96d9533ef2fe6b50904854f6d0b4d97314f411d86deb5b082b40d98efefe95c2