[INFO] updating cached repository d-dorazio/aoc2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/d-dorazio/aoc2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/d-dorazio/aoc2018" "work/ex/clippy-test-run/sources/stable/gh/d-dorazio/aoc2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/d-dorazio/aoc2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/d-dorazio/aoc2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d-dorazio/aoc2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d-dorazio/aoc2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b57d495a9f132f37add865776b002ed6a43047e6 [INFO] sha for GitHub repo d-dorazio/aoc2018: b57d495a9f132f37add865776b002ed6a43047e6 [INFO] validating manifest of d-dorazio/aoc2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of d-dorazio/aoc2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing d-dorazio/aoc2018 [INFO] finished frobbing d-dorazio/aoc2018 [INFO] frobbed toml for d-dorazio/aoc2018 written to work/ex/clippy-test-run/sources/stable/gh/d-dorazio/aoc2018/Cargo.toml [INFO] started frobbing d-dorazio/aoc2018 [INFO] finished frobbing d-dorazio/aoc2018 [INFO] frobbed toml for d-dorazio/aoc2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/d-dorazio/aoc2018/Cargo.toml [INFO] crate d-dorazio/aoc2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting d-dorazio/aoc2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/d-dorazio/aoc2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 616148b53bccde3aeeb1cda11e633d554049e4fd94c288b9502c3dc9f20bb5fe [INFO] running `"docker" "start" "-a" "616148b53bccde3aeeb1cda11e633d554049e4fd94c288b9502c3dc9f20bb5fe"` [INFO] [stderr] Checking aoc2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/day17.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | / let mut has_overflown = false; [INFO] [stderr] 115 | | [INFO] [stderr] 116 | | if self.grid[y + 1][left_boundary] == Cell::Sand { [INFO] [stderr] 117 | | has_overflown = self.irrigate(y, left_boundary); [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let has_overflown = if self.grid[y + 1][left_boundary] == Cell::Sand { self.irrigate(y, left_boundary) } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/day17.rs:225:5 [INFO] [stderr] | [INFO] [stderr] 225 | / let mut xs = 0..=0; [INFO] [stderr] 226 | | [INFO] [stderr] 227 | | if first_coord_id == "x" { [INFO] [stderr] 228 | | xs = first_n..=first_n; [INFO] [stderr] 229 | | } else { [INFO] [stderr] 230 | | ys = first_n..=first_n; [INFO] [stderr] 231 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let xs = if first_coord_id == "x" { first_n..=first_n } else { ..; 0..=0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day17.rs:220:46 [INFO] [stderr] | [INFO] [stderr] 220 | let mut first_part = parts.next()?.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day17.rs:233:47 [INFO] [stderr] | [INFO] [stderr] 233 | let mut second_part = parts.next()?.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/day17.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | / let mut has_overflown = false; [INFO] [stderr] 115 | | [INFO] [stderr] 116 | | if self.grid[y + 1][left_boundary] == Cell::Sand { [INFO] [stderr] 117 | | has_overflown = self.irrigate(y, left_boundary); [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let has_overflown = if self.grid[y + 1][left_boundary] == Cell::Sand { self.irrigate(y, left_boundary) } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/day17.rs:225:5 [INFO] [stderr] | [INFO] [stderr] 225 | / let mut xs = 0..=0; [INFO] [stderr] 226 | | [INFO] [stderr] 227 | | if first_coord_id == "x" { [INFO] [stderr] 228 | | xs = first_n..=first_n; [INFO] [stderr] 229 | | } else { [INFO] [stderr] 230 | | ys = first_n..=first_n; [INFO] [stderr] 231 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let xs = if first_coord_id == "x" { first_n..=first_n } else { ..; 0..=0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day17.rs:220:46 [INFO] [stderr] | [INFO] [stderr] 220 | let mut first_part = parts.next()?.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day17.rs:233:47 [INFO] [stderr] | [INFO] [stderr] 233 | let mut second_part = parts.next()?.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.12s [INFO] running `"docker" "inspect" "616148b53bccde3aeeb1cda11e633d554049e4fd94c288b9502c3dc9f20bb5fe"` [INFO] running `"docker" "rm" "-f" "616148b53bccde3aeeb1cda11e633d554049e4fd94c288b9502c3dc9f20bb5fe"` [INFO] [stdout] 616148b53bccde3aeeb1cda11e633d554049e4fd94c288b9502c3dc9f20bb5fe