[INFO] updating cached repository czak/retronix.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/czak/retronix.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/czak/retronix.rs" "work/ex/clippy-test-run/sources/stable/gh/czak/retronix.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/czak/retronix.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/czak/retronix.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/czak/retronix.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/czak/retronix.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b695215b8dc9eb8554b0919ff87da3137783f9d4 [INFO] sha for GitHub repo czak/retronix.rs: b695215b8dc9eb8554b0919ff87da3137783f9d4 [INFO] validating manifest of czak/retronix.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of czak/retronix.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing czak/retronix.rs [INFO] finished frobbing czak/retronix.rs [INFO] frobbed toml for czak/retronix.rs written to work/ex/clippy-test-run/sources/stable/gh/czak/retronix.rs/Cargo.toml [INFO] started frobbing czak/retronix.rs [INFO] finished frobbing czak/retronix.rs [INFO] frobbed toml for czak/retronix.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/czak/retronix.rs/Cargo.toml [INFO] crate czak/retronix.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting czak/retronix.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/czak/retronix.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3dfe459cac2a67705507e58b222a7f7338ea3c22d00458ea2d6df7b1f00577d6 [INFO] running `"docker" "start" "-a" "3dfe459cac2a67705507e58b222a7f7338ea3c22d00458ea2d6df7b1f00577d6"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking retronix v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game/states/play_state/models.rs:95:33 [INFO] [stderr] | [INFO] [stderr] 95 | self.fill_ratio = 1.0 - remaining_sea_fields as f64 / total_sea_fields as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(remaining_sea_fields)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/game/states/play_state/mod.rs:248:43 [INFO] [stderr] | [INFO] [stderr] 248 | if enemy.hit_check(|position| { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 249 | | *position == self.player.position || self.board[position] == Field::Sand [INFO] [stderr] 250 | | }) { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game/states/play_state/mod.rs:364:25 [INFO] [stderr] | [INFO] [stderr] 364 | let c = match field { [INFO] [stderr] | _________________________^ [INFO] [stderr] 365 | | &Field::Land => '█', [INFO] [stderr] 366 | | &Field::Sea => '░', [INFO] [stderr] 367 | | &Field::Sand => '▒', [INFO] [stderr] 368 | | _ => '?', [INFO] [stderr] 369 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 364 | let c = match *field { [INFO] [stderr] 365 | Field::Land => '█', [INFO] [stderr] 366 | Field::Sea => '░', [INFO] [stderr] 367 | Field::Sand => '▒', [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/game/mod.rs:89:36 [INFO] [stderr] | [INFO] [stderr] 89 | fn current_state(&mut self) -> &mut Box { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut State` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game/states/play_state/models.rs:95:33 [INFO] [stderr] | [INFO] [stderr] 95 | self.fill_ratio = 1.0 - remaining_sea_fields as f64 / total_sea_fields as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(remaining_sea_fields)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/game/states/play_state/mod.rs:248:43 [INFO] [stderr] | [INFO] [stderr] 248 | if enemy.hit_check(|position| { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 249 | | *position == self.player.position || self.board[position] == Field::Sand [INFO] [stderr] 250 | | }) { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game/states/play_state/mod.rs:364:25 [INFO] [stderr] | [INFO] [stderr] 364 | let c = match field { [INFO] [stderr] | _________________________^ [INFO] [stderr] 365 | | &Field::Land => '█', [INFO] [stderr] 366 | | &Field::Sea => '░', [INFO] [stderr] 367 | | &Field::Sand => '▒', [INFO] [stderr] 368 | | _ => '?', [INFO] [stderr] 369 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 364 | let c = match *field { [INFO] [stderr] 365 | Field::Land => '█', [INFO] [stderr] 366 | Field::Sea => '░', [INFO] [stderr] 367 | Field::Sand => '▒', [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/game/mod.rs:89:36 [INFO] [stderr] | [INFO] [stderr] 89 | fn current_state(&mut self) -> &mut Box { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&mut State` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.07s [INFO] running `"docker" "inspect" "3dfe459cac2a67705507e58b222a7f7338ea3c22d00458ea2d6df7b1f00577d6"` [INFO] running `"docker" "rm" "-f" "3dfe459cac2a67705507e58b222a7f7338ea3c22d00458ea2d6df7b1f00577d6"` [INFO] [stdout] 3dfe459cac2a67705507e58b222a7f7338ea3c22d00458ea2d6df7b1f00577d6