[INFO] updating cached repository cyplo/rustback [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cyplo/rustback [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cyplo/rustback" "work/ex/clippy-test-run/sources/stable/gh/cyplo/rustback"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cyplo/rustback'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cyplo/rustback" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cyplo/rustback"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cyplo/rustback'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 65900c95e8fed47f1558facbc8bd7e02746906a3 [INFO] sha for GitHub repo cyplo/rustback: 65900c95e8fed47f1558facbc8bd7e02746906a3 [INFO] validating manifest of cyplo/rustback on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cyplo/rustback on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cyplo/rustback [INFO] finished frobbing cyplo/rustback [INFO] frobbed toml for cyplo/rustback written to work/ex/clippy-test-run/sources/stable/gh/cyplo/rustback/Cargo.toml [INFO] started frobbing cyplo/rustback [INFO] finished frobbing cyplo/rustback [INFO] frobbed toml for cyplo/rustback written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cyplo/rustback/Cargo.toml [INFO] crate cyplo/rustback has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cyplo/rustback against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cyplo/rustback:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 43f683d3d604cc60e5b89cd8e5f053c484431720a57106a4ce14b0f8397d141d [INFO] running `"docker" "start" "-a" "43f683d3d604cc60e5b89cd8e5f053c484431720a57106a4ce14b0f8397d141d"` [INFO] [stderr] Checking dir-diff v0.3.1 [INFO] [stderr] Checking bakare v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/backup.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn file_version(&self, path: &Path) -> Version { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `what` [INFO] [stderr] --> src/restore.rs:34:41 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn restore_as_of_version(&self, what: WhatToRestore, version: Version) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^ help: consider using `_what` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `version` [INFO] [stderr] --> src/restore.rs:34:62 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn restore_as_of_version(&self, what: WhatToRestore, version: Version) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^^^^ help: consider using `_version` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `next` [INFO] [stderr] --> src/storage.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | fn next(self) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Index` [INFO] [stderr] --> src/storage.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | struct Index<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/storage.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `store` [INFO] [stderr] --> src/storage.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | fn store(&mut self, source_path: &'a str, hash: Hash) -> (Version, String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `latest_version_for_path` [INFO] [stderr] --> src/storage.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | fn latest_version_for_path(&self, path: &str) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/storage.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | self.file_paths.get(path).map_or(None, |entry| Some(entry.version)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `self.file_paths.get(path).and_then(|entry| Some(entry.version))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/backup.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn file_version(&self, path: &Path) -> Version { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `what` [INFO] [stderr] --> src/restore.rs:34:41 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn restore_as_of_version(&self, what: WhatToRestore, version: Version) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^ help: consider using `_what` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `version` [INFO] [stderr] --> src/restore.rs:34:62 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn restore_as_of_version(&self, what: WhatToRestore, version: Version) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^^^^ help: consider using `_version` instead [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/storage.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | self.file_paths.get(path).map_or(None, |entry| Some(entry.version)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `self.file_paths.get(path).and_then(|entry| Some(entry.version))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> tests/system_tests.rs:87:12 [INFO] [stderr] | [INFO] [stderr] 87 | Ok(File::create(self.directory.path().join(filename))?.write_all(text.as_bytes())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 87 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.63s [INFO] running `"docker" "inspect" "43f683d3d604cc60e5b89cd8e5f053c484431720a57106a4ce14b0f8397d141d"` [INFO] running `"docker" "rm" "-f" "43f683d3d604cc60e5b89cd8e5f053c484431720a57106a4ce14b0f8397d141d"` [INFO] [stdout] 43f683d3d604cc60e5b89cd8e5f053c484431720a57106a4ce14b0f8397d141d