[INFO] updating cached repository cyplo/genpass [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cyplo/genpass [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cyplo/genpass" "work/ex/clippy-test-run/sources/stable/gh/cyplo/genpass"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cyplo/genpass'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cyplo/genpass" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cyplo/genpass"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cyplo/genpass'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 464b8cb025b9817b206d6a3a61f7ed1917694d86 [INFO] sha for GitHub repo cyplo/genpass: 464b8cb025b9817b206d6a3a61f7ed1917694d86 [INFO] validating manifest of cyplo/genpass on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cyplo/genpass on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cyplo/genpass [INFO] finished frobbing cyplo/genpass [INFO] frobbed toml for cyplo/genpass written to work/ex/clippy-test-run/sources/stable/gh/cyplo/genpass/Cargo.toml [INFO] started frobbing cyplo/genpass [INFO] finished frobbing cyplo/genpass [INFO] frobbed toml for cyplo/genpass written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cyplo/genpass/Cargo.toml [INFO] crate cyplo/genpass has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cyplo/genpass against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cyplo/genpass:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 862b2e52991b77af0a24706277b0cd9f15cc546f61c37762a7ceb51e7da99a23 [INFO] running `"docker" "start" "-a" "862b2e52991b77af0a24706277b0cd9f15cc546f61c37762a7ceb51e7da99a23"` [INFO] [stderr] Checking genpass v0.2.4 (/opt/crater/workdir) [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commandline.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | const LENGTH_OPTION_NAME: &'static str = "length"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commandline.rs:6:39 [INFO] [stderr] | [INFO] [stderr] 6 | const INCLUDE_LOWERCASE_OPTION_NAME: &'static str = "include-lowercase"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commandline.rs:7:39 [INFO] [stderr] | [INFO] [stderr] 7 | const INCLUDE_UPPERCASE_OPTION_NAME: &'static str = "include-uppercase"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commandline.rs:8:35 [INFO] [stderr] | [INFO] [stderr] 8 | const INCLUDE_DIGIT_OPTION_NAME: &'static str = "include-digit"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commandline.rs:9:37 [INFO] [stderr] | [INFO] [stderr] 9 | const INCLUDE_SPECIAL_OPTION_NAME: &'static str = "include-special"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commandline.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | const DEFAULT_LENGTH: &'static str = "32"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/alphabet.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | const LOWERCASE_CHARS: &'static str = "abcdefghijklmnopqrstuvwxyz"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/alphabet.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | const UPPERCASE_CHARS: &'static str = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/alphabet.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | const DIGITS_CHARS: &'static str = "1234567890"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/alphabet.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | const SPECIAL_CHARS: &'static str = "~!@#$%^&*()-=_+{}[]|\';/.,?><"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Checking quickcheck v0.6.2 [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commandline.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | const LENGTH_OPTION_NAME: &'static str = "length"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commandline.rs:6:39 [INFO] [stderr] | [INFO] [stderr] 6 | const INCLUDE_LOWERCASE_OPTION_NAME: &'static str = "include-lowercase"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commandline.rs:7:39 [INFO] [stderr] | [INFO] [stderr] 7 | const INCLUDE_UPPERCASE_OPTION_NAME: &'static str = "include-uppercase"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commandline.rs:8:35 [INFO] [stderr] | [INFO] [stderr] 8 | const INCLUDE_DIGIT_OPTION_NAME: &'static str = "include-digit"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commandline.rs:9:37 [INFO] [stderr] | [INFO] [stderr] 9 | const INCLUDE_SPECIAL_OPTION_NAME: &'static str = "include-special"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commandline.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | const DEFAULT_LENGTH: &'static str = "32"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/alphabet.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | const LOWERCASE_CHARS: &'static str = "abcdefghijklmnopqrstuvwxyz"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/alphabet.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | const UPPERCASE_CHARS: &'static str = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/alphabet.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | const DIGITS_CHARS: &'static str = "1234567890"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/alphabet.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | const SPECIAL_CHARS: &'static str = "~!@#$%^&*()-=_+{}[]|\';/.,?><"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/alphabet.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | .map(|code| char::from(code)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `char::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/generator.rs:141:16 [INFO] [stderr] | [INFO] [stderr] 141 | || seed.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `seed.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.62s [INFO] running `"docker" "inspect" "862b2e52991b77af0a24706277b0cd9f15cc546f61c37762a7ceb51e7da99a23"` [INFO] running `"docker" "rm" "-f" "862b2e52991b77af0a24706277b0cd9f15cc546f61c37762a7ceb51e7da99a23"` [INFO] [stdout] 862b2e52991b77af0a24706277b0cd9f15cc546f61c37762a7ceb51e7da99a23