[INFO] updating cached repository cyndis/pn [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cyndis/pn [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cyndis/pn" "work/ex/clippy-test-run/sources/stable/gh/cyndis/pn"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cyndis/pn'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cyndis/pn" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cyndis/pn"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cyndis/pn'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 03f73bb970b0587eecdbb20e075506018e5abef9 [INFO] sha for GitHub repo cyndis/pn: 03f73bb970b0587eecdbb20e075506018e5abef9 [INFO] validating manifest of cyndis/pn on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cyndis/pn on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cyndis/pn [INFO] finished frobbing cyndis/pn [INFO] frobbed toml for cyndis/pn written to work/ex/clippy-test-run/sources/stable/gh/cyndis/pn/Cargo.toml [INFO] started frobbing cyndis/pn [INFO] finished frobbing cyndis/pn [INFO] frobbed toml for cyndis/pn written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cyndis/pn/Cargo.toml [INFO] crate cyndis/pn has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cyndis/pn against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cyndis/pn:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e27a2f822facb62d21a30936e0c681133d231e5444bb72ef2835dbc42cac5eb0 [INFO] running `"docker" "start" "-a" "e27a2f822facb62d21a30936e0c681133d231e5444bb72ef2835dbc42cac5eb0"` [INFO] [stderr] Checking da v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | nodes: nodes [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | nodes: nodes [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `nodes` [INFO] [stderr] --> src/main.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | let nodes = vec![ [INFO] [stderr] | ^^^^^ help: consider using `_nodes` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:30:72 [INFO] [stderr] | [INFO] [stderr] 30 | let mut in_datas = self.nodes.iter().map(|n| (0..n.len()).map(|x| None).collect::>()) [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:105:31 [INFO] [stderr] | [INFO] [stderr] 105 | UrB(k, ref m, ref x) if !m.is_empty() && k % 2 == 0 => [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | Mr(i) => pr.map(|_| Matched).collect(), [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:161:27 [INFO] [stderr] | [INFO] [stderr] 161 | fn init(ports: usize, i: &()) -> (BmmState, BmmState) { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_output` [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | fn is_output(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_matched` [INFO] [stderr] --> src/main.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | fn is_matched(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Vc3State` [INFO] [stderr] --> src/main.rs:153:1 [INFO] [stderr] | [INFO] [stderr] 153 | struct Vc3State(BmmState, BmmState); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:94:65 [INFO] [stderr] | [INFO] [stderr] 94 | BmmInput::Black => BmmState::UrB(1, HashSet::new(), (1..ports+1).collect()) [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(1..=ports)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | let pr = 1..(ports+1); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `1..=ports` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused variable: `nodes` [INFO] [stderr] --> src/main.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | let nodes = vec![ [INFO] [stderr] | ^^^^^ help: consider using `_nodes` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:30:72 [INFO] [stderr] | [INFO] [stderr] 30 | let mut in_datas = self.nodes.iter().map(|n| (0..n.len()).map(|x| None).collect::>()) [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:105:31 [INFO] [stderr] | [INFO] [stderr] 105 | UrB(k, ref m, ref x) if !m.is_empty() && k % 2 == 0 => [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | Mr(i) => pr.map(|_| Matched).collect(), [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:161:27 [INFO] [stderr] | [INFO] [stderr] 161 | fn init(ports: usize, i: &()) -> (BmmState, BmmState) { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_output` [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | fn is_output(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_matched` [INFO] [stderr] --> src/main.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | fn is_matched(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Vc3State` [INFO] [stderr] --> src/main.rs:153:1 [INFO] [stderr] | [INFO] [stderr] 153 | struct Vc3State(BmmState, BmmState); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:94:65 [INFO] [stderr] | [INFO] [stderr] 94 | BmmInput::Black => BmmState::UrB(1, HashSet::new(), (1..ports+1).collect()) [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(1..=ports)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | let pr = 1..(ports+1); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `1..=ports` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.87s [INFO] running `"docker" "inspect" "e27a2f822facb62d21a30936e0c681133d231e5444bb72ef2835dbc42cac5eb0"` [INFO] running `"docker" "rm" "-f" "e27a2f822facb62d21a30936e0c681133d231e5444bb72ef2835dbc42cac5eb0"` [INFO] [stdout] e27a2f822facb62d21a30936e0c681133d231e5444bb72ef2835dbc42cac5eb0