[INFO] updating cached repository cygni/snakebot-client-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cygni/snakebot-client-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cygni/snakebot-client-rust" "work/ex/clippy-test-run/sources/stable/gh/cygni/snakebot-client-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cygni/snakebot-client-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cygni/snakebot-client-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cygni/snakebot-client-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cygni/snakebot-client-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 557b688fba5630ffaba04ff233d4063f8d3542a5
[INFO] sha for GitHub repo cygni/snakebot-client-rust: 557b688fba5630ffaba04ff233d4063f8d3542a5
[INFO] validating manifest of cygni/snakebot-client-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cygni/snakebot-client-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cygni/snakebot-client-rust
[INFO] finished frobbing cygni/snakebot-client-rust
[INFO] frobbed toml for cygni/snakebot-client-rust written to work/ex/clippy-test-run/sources/stable/gh/cygni/snakebot-client-rust/Cargo.toml
[INFO] started frobbing cygni/snakebot-client-rust
[INFO] finished frobbing cygni/snakebot-client-rust
[INFO] frobbed toml for cygni/snakebot-client-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cygni/snakebot-client-rust/Cargo.toml
[INFO] crate cygni/snakebot-client-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cygni/snakebot-client-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cygni/snakebot-client-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9efede36eb7b71fd3edabfd854c4117bf53e7ae9e1b93614c27248747823fcdc
[INFO] running `"docker" "start" "-a" "9efede36eb7b71fd3edabfd854c4117bf53e7ae9e1b93614c27248747823fcdc"`
[INFO] [stderr]     Checking serde v1.0.45
[INFO] [stderr]     Checking target_info v0.1.0
[INFO] [stderr]     Checking rustc_version v0.2.2
[INFO] [stderr]     Checking flate2 v1.0.1
[INFO] [stderr]    Compiling serde_derive v1.0.45
[INFO] [stderr]     Checking serde-hjson v0.8.1
[INFO] [stderr]     Checking log v0.4.1
[INFO] [stderr]     Checking toml v0.4.6
[INFO] [stderr]     Checking serde_json v1.0.17
[INFO] [stderr]     Checking serde-value v0.5.2
[INFO] [stderr]     Checking serde_yaml v0.7.4
[INFO] [stderr]     Checking mio v0.6.14
[INFO] [stderr]     Checking ws v0.7.6
[INFO] [stderr]     Checking config v0.8.0
[INFO] [stderr]     Checking log4rs v0.8.0
[INFO] [stderr]     Checking snakebot_rust v1.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:27:20
[INFO] [stderr]    |
[INFO] [stderr] 27 | const LOG_TARGET: &'static str = "client";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:28:21
[INFO] [stderr]    |
[INFO] [stderr] 28 | const CONFIG_FILE: &'static str = "snake.conf";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:29:22
[INFO] [stderr]    |
[INFO] [stderr] 29 | const DEFAULT_HOST: &'static str = "snake.cygni.se";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:30:22
[INFO] [stderr]    |
[INFO] [stderr] 30 | const DEFAULT_PORT: &'static str = "80";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:31:28
[INFO] [stderr]    |
[INFO] [stderr] 31 | const DEFAULT_SNAKE_NAME: &'static str = "default-rust-snake-name";
[INFO] [stderr]    |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:32:23
[INFO] [stderr]    |
[INFO] [stderr] 32 | const DEFAULT_VENUE: &'static str = "training";
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:27:20
[INFO] [stderr]    |
[INFO] [stderr] 27 | const LOG_TARGET: &'static str = "client";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:28:21
[INFO] [stderr]    |
[INFO] [stderr] 28 | const CONFIG_FILE: &'static str = "snake.conf";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:29:22
[INFO] [stderr]    |
[INFO] [stderr] 29 | const DEFAULT_HOST: &'static str = "snake.cygni.se";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:30:22
[INFO] [stderr]    |
[INFO] [stderr] 30 | const DEFAULT_PORT: &'static str = "80";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:31:28
[INFO] [stderr]    |
[INFO] [stderr] 31 | const DEFAULT_SNAKE_NAME: &'static str = "default-rust-snake-name";
[INFO] [stderr]    |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:32:23
[INFO] [stderr]    |
[INFO] [stderr] 32 | const DEFAULT_VENUE: &'static str = "training";
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/client.rs:94:5
[INFO] [stderr]     |
[INFO] [stderr] 94  | /     match token {
[INFO] [stderr] 95  | |       HEARTBEAT_TOKEN => {
[INFO] [stderr] 96  | |         self.ws.timeout(HEARTBEAT_INTERVAL, HEARTBEAT_TOKEN)?;
[INFO] [stderr] 97  | |         if let Some(ref player_id) = self.player_id {
[INFO] [stderr] ...   |
[INFO] [stderr] 103 | |       _ => {}
[INFO] [stderr] 104 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 94  |     if let HEARTBEAT_TOKEN = token {
[INFO] [stderr] 95  |   self.ws.timeout(HEARTBEAT_INTERVAL, HEARTBEAT_TOKEN)?;
[INFO] [stderr] 96  |   if let Some(ref player_id) = self.player_id {
[INFO] [stderr] 97  |     self.send_message(OutboundMessage::HeartBeatRequest {
[INFO] [stderr] 98  |       receiving_player_id: player_id,
[INFO] [stderr] 99  |     })?;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/snake.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 | /         match *message {
[INFO] [stderr] 55 | |             InboundMessage::GameStarting { .. } => {
[INFO] [stderr] 56 | |                 // Reset snake state here
[INFO] [stderr] 57 | |             }
[INFO] [stderr] ...  |
[INFO] [stderr] 61 | |             }
[INFO] [stderr] 62 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 54 |         if let InboundMessage::GameStarting { .. } = *message {
[INFO] [stderr] 55 |     // Reset snake state here
[INFO] [stderr] 56 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/client.rs:94:5
[INFO] [stderr]     |
[INFO] [stderr] 94  | /     match token {
[INFO] [stderr] 95  | |       HEARTBEAT_TOKEN => {
[INFO] [stderr] 96  | |         self.ws.timeout(HEARTBEAT_INTERVAL, HEARTBEAT_TOKEN)?;
[INFO] [stderr] 97  | |         if let Some(ref player_id) = self.player_id {
[INFO] [stderr] ...   |
[INFO] [stderr] 103 | |       _ => {}
[INFO] [stderr] 104 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 94  |     if let HEARTBEAT_TOKEN = token {
[INFO] [stderr] 95  |   self.ws.timeout(HEARTBEAT_INTERVAL, HEARTBEAT_TOKEN)?;
[INFO] [stderr] 96  |   if let Some(ref player_id) = self.player_id {
[INFO] [stderr] 97  |     self.send_message(OutboundMessage::HeartBeatRequest {
[INFO] [stderr] 98  |       receiving_player_id: player_id,
[INFO] [stderr] 99  |     })?;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/snake.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 | /         match *message {
[INFO] [stderr] 55 | |             InboundMessage::GameStarting { .. } => {
[INFO] [stderr] 56 | |                 // Reset snake state here
[INFO] [stderr] 57 | |             }
[INFO] [stderr] ...  |
[INFO] [stderr] 61 | |             }
[INFO] [stderr] 62 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 54 |         if let InboundMessage::GameStarting { .. } = *message {
[INFO] [stderr] 55 |     // Reset snake state here
[INFO] [stderr] 56 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/utils.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         (((x0 - x1).pow(2) + (y0 - y1).pow(2)) as f64).sqrt()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((x0 - x1).pow(2) + (y0 - y1).pow(2))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/utils.rs:74:30
[INFO] [stderr]    |
[INFO] [stderr] 74 |     pub fn to_movement_delta(&self) -> Coordinate {
[INFO] [stderr]    |                              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/utils.rs:91:42
[INFO] [stderr]    |
[INFO] [stderr] 91 |         self.snake_infos.iter().find(|s| &s.id == id)
[INFO] [stderr]    |                                          -----^^^^^^
[INFO] [stderr]    |                                          |
[INFO] [stderr]    |                                          help: use the left value directly: `s.id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/main.rs:86:12
[INFO] [stderr]    |
[INFO] [stderr] 86 |       if let Err(_) = log4rs::init_file("log4rs.toml", Default::default()) {
[INFO] [stderr]    |  _____-      ^^^^^^
[INFO] [stderr] 87 | |         log4rs::init_file("../log4rs.toml", Default::default()).unwrap();
[INFO] [stderr] 88 | |     }
[INFO] [stderr]    | |_____- help: try this: `if log4rs::init_file("log4rs.toml", Default::default()).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/utils.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         (((x0 - x1).pow(2) + (y0 - y1).pow(2)) as f64).sqrt()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((x0 - x1).pow(2) + (y0 - y1).pow(2))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/utils.rs:74:30
[INFO] [stderr]    |
[INFO] [stderr] 74 |     pub fn to_movement_delta(&self) -> Coordinate {
[INFO] [stderr]    |                              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/utils.rs:91:42
[INFO] [stderr]    |
[INFO] [stderr] 91 |         self.snake_infos.iter().find(|s| &s.id == id)
[INFO] [stderr]    |                                          -----^^^^^^
[INFO] [stderr]    |                                          |
[INFO] [stderr]    |                                          help: use the left value directly: `s.id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/main.rs:86:12
[INFO] [stderr]    |
[INFO] [stderr] 86 |       if let Err(_) = log4rs::init_file("log4rs.toml", Default::default()) {
[INFO] [stderr]    |  _____-      ^^^^^^
[INFO] [stderr] 87 | |         log4rs::init_file("../log4rs.toml", Default::default()).unwrap();
[INFO] [stderr] 88 | |     }
[INFO] [stderr]    | |_____- help: try this: `if log4rs::init_file("log4rs.toml", Default::default()).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 35.00s
[INFO] running `"docker" "inspect" "9efede36eb7b71fd3edabfd854c4117bf53e7ae9e1b93614c27248747823fcdc"`
[INFO] running `"docker" "rm" "-f" "9efede36eb7b71fd3edabfd854c4117bf53e7ae9e1b93614c27248747823fcdc"`
[INFO] [stdout] 9efede36eb7b71fd3edabfd854c4117bf53e7ae9e1b93614c27248747823fcdc