[INFO] updating cached repository cwyn/dijkstra [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cwyn/dijkstra [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cwyn/dijkstra" "work/ex/clippy-test-run/sources/stable/gh/cwyn/dijkstra"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cwyn/dijkstra'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cwyn/dijkstra" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cwyn/dijkstra"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cwyn/dijkstra'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c6d258c51a8ea9a2a65ff3a8c150dd717b72da5a [INFO] sha for GitHub repo cwyn/dijkstra: c6d258c51a8ea9a2a65ff3a8c150dd717b72da5a [INFO] validating manifest of cwyn/dijkstra on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cwyn/dijkstra on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cwyn/dijkstra [INFO] finished frobbing cwyn/dijkstra [INFO] frobbed toml for cwyn/dijkstra written to work/ex/clippy-test-run/sources/stable/gh/cwyn/dijkstra/Cargo.toml [INFO] started frobbing cwyn/dijkstra [INFO] finished frobbing cwyn/dijkstra [INFO] frobbed toml for cwyn/dijkstra written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cwyn/dijkstra/Cargo.toml [INFO] crate cwyn/dijkstra has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cwyn/dijkstra against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cwyn/dijkstra:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7b4de5508aa049288b2c7eca0821d685e6e7cb8de3e16efaf197f9db98f39418 [INFO] running `"docker" "start" "-a" "7b4de5508aa049288b2c7eca0821d685e6e7cb8de3e16efaf197f9db98f39418"` [INFO] [stderr] Checking dijkstra v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | return graph; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `graph` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | / if e[0] == min_node { [INFO] [stderr] 56 | | if dist[min_node as usize] < std::u32::MAX { [INFO] [stderr] 57 | | let alt: u32 = dist[min_node as usize] + e[2]; [INFO] [stderr] 58 | | if alt < dist[e[1] as usize] { [INFO] [stderr] ... | [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 55 | if e[0] == min_node && dist[min_node as usize] < std::u32::MAX { [INFO] [stderr] 56 | let alt: u32 = dist[min_node as usize] + e[2]; [INFO] [stderr] 57 | if alt < dist[e[1] as usize] { [INFO] [stderr] 58 | dist[e[1] as usize] = alt; [INFO] [stderr] 59 | } [INFO] [stderr] 60 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | return graph; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `graph` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | / if e[0] == min_node { [INFO] [stderr] 56 | | if dist[min_node as usize] < std::u32::MAX { [INFO] [stderr] 57 | | let alt: u32 = dist[min_node as usize] + e[2]; [INFO] [stderr] 58 | | if alt < dist[e[1] as usize] { [INFO] [stderr] ... | [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 55 | if e[0] == min_node && dist[min_node as usize] < std::u32::MAX { [INFO] [stderr] 56 | let alt: u32 = dist[min_node as usize] + e[2]; [INFO] [stderr] 57 | if alt < dist[e[1] as usize] { [INFO] [stderr] 58 | dist[e[1] as usize] = alt; [INFO] [stderr] 59 | } [INFO] [stderr] 60 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:37:11 [INFO] [stderr] | [INFO] [stderr] 37 | while univisted(visited) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `univisted(visited)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:37:11 [INFO] [stderr] | [INFO] [stderr] 37 | while univisted(visited) == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `univisted(visited)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "7b4de5508aa049288b2c7eca0821d685e6e7cb8de3e16efaf197f9db98f39418"` [INFO] running `"docker" "rm" "-f" "7b4de5508aa049288b2c7eca0821d685e6e7cb8de3e16efaf197f9db98f39418"` [INFO] [stdout] 7b4de5508aa049288b2c7eca0821d685e6e7cb8de3e16efaf197f9db98f39418