[INFO] updating cached repository cwmoo740/rust-practice
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cwmoo740/rust-practice
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cwmoo740/rust-practice" "work/ex/clippy-test-run/sources/stable/gh/cwmoo740/rust-practice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cwmoo740/rust-practice'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cwmoo740/rust-practice" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cwmoo740/rust-practice"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cwmoo740/rust-practice'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2019c3724eee1ed27fa2e5a97c9f0e4629111500
[INFO] sha for GitHub repo cwmoo740/rust-practice: 2019c3724eee1ed27fa2e5a97c9f0e4629111500
[INFO] validating manifest of cwmoo740/rust-practice on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cwmoo740/rust-practice on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cwmoo740/rust-practice
[INFO] finished frobbing cwmoo740/rust-practice
[INFO] frobbed toml for cwmoo740/rust-practice written to work/ex/clippy-test-run/sources/stable/gh/cwmoo740/rust-practice/Cargo.toml
[INFO] started frobbing cwmoo740/rust-practice
[INFO] finished frobbing cwmoo740/rust-practice
[INFO] frobbed toml for cwmoo740/rust-practice written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cwmoo740/rust-practice/Cargo.toml
[INFO] crate cwmoo740/rust-practice has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cwmoo740/rust-practice against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cwmoo740/rust-practice:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d8ea9abae15f5cfc60ff7abf6eb761686de9533ce2722d08c20466f15fc63a14
[INFO] running `"docker" "start" "-a" "d8ea9abae15f5cfc60ff7abf6eb761686de9533ce2722d08c20466f15fc63a14"`
[INFO] [stderr]     Checking rust_practice v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]  --> src/stock_picking.rs:2:8
[INFO] [stderr]   |
[INFO] [stderr] 2 |     if stocks.len() == 0 || stocks.len() == 1 {
[INFO] [stderr]   |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stocks.is_empty()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/stock_picking.rs:15:10
[INFO] [stderr]    |
[INFO] [stderr] 15 |         .ok_or("error lol".to_owned())
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "error lol".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/stock_picking.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     result
[INFO] [stderr] 13 | |         .last()
[INFO] [stderr] 14 | |         .map(|x| *x)
[INFO] [stderr]    | |____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]    |
[INFO] [stderr] 12 |     result
[INFO] [stderr] 13 |         .last().cloned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]  --> src/merge_sort.rs:4:31
[INFO] [stderr]   |
[INFO] [stderr] 4 |         let mut left = result[lower..(mid + 1)].iter().peekable();
[INFO] [stderr]   |                               ^^^^^^^^^^^^^^^^ help: use: `lower..=mid`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]  --> src/merge_sort.rs:5:32
[INFO] [stderr]   |
[INFO] [stderr] 5 |         let mut right = result[(mid + 1)..(upper + 1)].iter().peekable();
[INFO] [stderr]   |                                ^^^^^^^^^^^^^^^^^^^^^^ help: use: `((mid + 1)..=upper)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/merge_sort.rs:20:12
[INFO] [stderr]    |
[INFO] [stderr] 20 |     result[lower..(upper + 1)].clone_from_slice(&out[..]);
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^ help: use: `lower..=upper`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/merge_sort.rs:23:15
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn recurse(x: &Vec<usize>, lower: usize, upper: usize, result: &mut Vec<usize>) {
[INFO] [stderr]    |               ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/merge_sort.rs:34:17
[INFO] [stderr]    |
[INFO] [stderr] 34 | pub fn solve(x: &Vec<usize>) -> Vec<usize> {
[INFO] [stderr]    |                 ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 34 | pub fn solve(x: &[usize]) -> Vec<usize> {
[INFO] [stderr]    |                 ^^^^^^^^
[INFO] [stderr] help: change `x.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 37 |         return x.to_owned();
[INFO] [stderr]    |                ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/scheduling.rs:1:20
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub fn solve(jobs: &Vec<&Job>) -> usize {
[INFO] [stderr]   |                    ^^^^^^^^^^ help: change this to: `&[&Job]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]  --> src/scheduling.rs:2:8
[INFO] [stderr]   |
[INFO] [stderr] 2 |     if jobs.len() == 0 {
[INFO] [stderr]   |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `jobs.is_empty()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cracking_coding/permutations_in_string.rs:11:22
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn is_anagram(chars: &Vec<usize>, pattern: &Vec<usize>) -> bool {
[INFO] [stderr]    |                      ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cracking_coding/permutations_in_string.rs:11:44
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn is_anagram(chars: &Vec<usize>, pattern: &Vec<usize>) -> bool {
[INFO] [stderr]    |                                            ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]   --> src/cracking_coding/permutations_in_string.rs:45:59
[INFO] [stderr]    |
[INFO] [stderr] 45 | pub fn solve(pattern: &str, text: &str, alphabet: Option<&HashMap<char, usize>>) -> Vec<usize> {
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]    |
[INFO] [stderr] 45 | pub fn solve<S: ::std::hash::BuildHasher + Default>(pattern: &str, text: &str, alphabet: Option<&HashMap<char, usize, S>>) -> Vec<usize> {
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                              ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: ...and use generic constructor
[INFO] [stderr]    |
[INFO] [stderr] 51 |     let mut default_alphabet: HashMap<char, usize> = HashMap::default();
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/cracking_coding/permutations_in_string.rs:48:42
[INFO] [stderr]    |
[INFO] [stderr] 48 |       } else if pattern.len() > text.len() {
[INFO] [stderr]    |  __________________________________________^
[INFO] [stderr] 49 | |         return Vec::new();
[INFO] [stderr] 50 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/cracking_coding/permutations_in_string.rs:46:46
[INFO] [stderr]    |
[INFO] [stderr] 46 |       if pattern.len() == 0 || text.len() == 0 {
[INFO] [stderr]    |  ______________________________________________^
[INFO] [stderr] 47 | |         return Vec::new();
[INFO] [stderr] 48 | |     } else if pattern.len() > text.len() {
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/cracking_coding/permutations_in_string.rs:46:8
[INFO] [stderr]    |
[INFO] [stderr] 46 |     if pattern.len() == 0 || text.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pattern.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/cracking_coding/permutations_in_string.rs:46:30
[INFO] [stderr]    |
[INFO] [stderr] 46 |     if pattern.len() == 0 || text.len() == 0 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rust_practice`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]  --> src/stock_picking.rs:2:8
[INFO] [stderr]   |
[INFO] [stderr] 2 |     if stocks.len() == 0 || stocks.len() == 1 {
[INFO] [stderr]   |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stocks.is_empty()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/stock_picking.rs:15:10
[INFO] [stderr]    |
[INFO] [stderr] 15 |         .ok_or("error lol".to_owned())
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "error lol".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/stock_picking.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     result
[INFO] [stderr] 13 | |         .last()
[INFO] [stderr] 14 | |         .map(|x| *x)
[INFO] [stderr]    | |____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]    |
[INFO] [stderr] 12 |     result
[INFO] [stderr] 13 |         .last().cloned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/stock_picking.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |         assert_eq!(result.unwrap(), 0f32);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/stock_picking.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |         assert_eq!(result.unwrap(), 0f32);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/stock_picking.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         assert_eq!(result.unwrap(), 4f32);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/stock_picking.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         assert_eq!(result.unwrap(), 4f32);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/stock_picking.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         assert_eq!(result.unwrap(), 5f32);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/stock_picking.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         assert_eq!(result.unwrap(), 5f32);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/stock_picking.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 |         assert_eq!(result.unwrap(), 0f32);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/stock_picking.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 |         assert_eq!(result.unwrap(), 0f32);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]  --> src/merge_sort.rs:4:31
[INFO] [stderr]   |
[INFO] [stderr] 4 |         let mut left = result[lower..(mid + 1)].iter().peekable();
[INFO] [stderr]   |                               ^^^^^^^^^^^^^^^^ help: use: `lower..=mid`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]  --> src/merge_sort.rs:5:32
[INFO] [stderr]   |
[INFO] [stderr] 5 |         let mut right = result[(mid + 1)..(upper + 1)].iter().peekable();
[INFO] [stderr]   |                                ^^^^^^^^^^^^^^^^^^^^^^ help: use: `((mid + 1)..=upper)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/merge_sort.rs:20:12
[INFO] [stderr]    |
[INFO] [stderr] 20 |     result[lower..(upper + 1)].clone_from_slice(&out[..]);
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^ help: use: `lower..=upper`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/merge_sort.rs:23:15
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn recurse(x: &Vec<usize>, lower: usize, upper: usize, result: &mut Vec<usize>) {
[INFO] [stderr]    |               ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/merge_sort.rs:34:17
[INFO] [stderr]    |
[INFO] [stderr] 34 | pub fn solve(x: &Vec<usize>) -> Vec<usize> {
[INFO] [stderr]    |                 ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 34 | pub fn solve(x: &[usize]) -> Vec<usize> {
[INFO] [stderr]    |                 ^^^^^^^^
[INFO] [stderr] help: change `x.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 37 |         return x.to_owned();
[INFO] [stderr]    |                ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/scheduling.rs:1:20
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub fn solve(jobs: &Vec<&Job>) -> usize {
[INFO] [stderr]   |                    ^^^^^^^^^^ help: change this to: `&[&Job]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]  --> src/scheduling.rs:2:8
[INFO] [stderr]   |
[INFO] [stderr] 2 |     if jobs.len() == 0 {
[INFO] [stderr]   |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `jobs.is_empty()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cracking_coding/permutations_in_string.rs:11:22
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn is_anagram(chars: &Vec<usize>, pattern: &Vec<usize>) -> bool {
[INFO] [stderr]    |                      ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cracking_coding/permutations_in_string.rs:11:44
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn is_anagram(chars: &Vec<usize>, pattern: &Vec<usize>) -> bool {
[INFO] [stderr]    |                                            ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]   --> src/cracking_coding/permutations_in_string.rs:45:59
[INFO] [stderr]    |
[INFO] [stderr] 45 | pub fn solve(pattern: &str, text: &str, alphabet: Option<&HashMap<char, usize>>) -> Vec<usize> {
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]    |
[INFO] [stderr] 45 | pub fn solve<S: ::std::hash::BuildHasher + Default>(pattern: &str, text: &str, alphabet: Option<&HashMap<char, usize, S>>) -> Vec<usize> {
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                              ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: ...and use generic constructor
[INFO] [stderr]    |
[INFO] [stderr] 51 |     let mut default_alphabet: HashMap<char, usize> = HashMap::default();
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/cracking_coding/permutations_in_string.rs:48:42
[INFO] [stderr]    |
[INFO] [stderr] 48 |       } else if pattern.len() > text.len() {
[INFO] [stderr]    |  __________________________________________^
[INFO] [stderr] 49 | |         return Vec::new();
[INFO] [stderr] 50 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/cracking_coding/permutations_in_string.rs:46:46
[INFO] [stderr]    |
[INFO] [stderr] 46 |       if pattern.len() == 0 || text.len() == 0 {
[INFO] [stderr]    |  ______________________________________________^
[INFO] [stderr] 47 | |         return Vec::new();
[INFO] [stderr] 48 | |     } else if pattern.len() > text.len() {
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/cracking_coding/permutations_in_string.rs:46:8
[INFO] [stderr]    |
[INFO] [stderr] 46 |     if pattern.len() == 0 || text.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pattern.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/cracking_coding/permutations_in_string.rs:46:30
[INFO] [stderr]    |
[INFO] [stderr] 46 |     if pattern.len() == 0 || text.len() == 0 {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 5 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rust_practice`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "d8ea9abae15f5cfc60ff7abf6eb761686de9533ce2722d08c20466f15fc63a14"`
[INFO] running `"docker" "rm" "-f" "d8ea9abae15f5cfc60ff7abf6eb761686de9533ce2722d08c20466f15fc63a14"`
[INFO] [stdout] d8ea9abae15f5cfc60ff7abf6eb761686de9533ce2722d08c20466f15fc63a14