[INFO] updating cached repository cwmiller/rustboy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cwmiller/rustboy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cwmiller/rustboy" "work/ex/clippy-test-run/sources/stable/gh/cwmiller/rustboy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cwmiller/rustboy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cwmiller/rustboy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cwmiller/rustboy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cwmiller/rustboy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f681f6ff841d38c272d2a2a6e10860e1b99747d5 [INFO] sha for GitHub repo cwmiller/rustboy: f681f6ff841d38c272d2a2a6e10860e1b99747d5 [INFO] validating manifest of cwmiller/rustboy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cwmiller/rustboy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cwmiller/rustboy [INFO] finished frobbing cwmiller/rustboy [INFO] frobbed toml for cwmiller/rustboy written to work/ex/clippy-test-run/sources/stable/gh/cwmiller/rustboy/Cargo.toml [INFO] started frobbing cwmiller/rustboy [INFO] finished frobbing cwmiller/rustboy [INFO] frobbed toml for cwmiller/rustboy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cwmiller/rustboy/Cargo.toml [INFO] crate cwmiller/rustboy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cwmiller/rustboy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cwmiller/rustboy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba51ac550e017aca34e96e45c9a71361f985b4e8c617a665ad5f7b91d93fa885 [INFO] running `"docker" "start" "-a" "ba51ac550e017aca34e96e45c9a71361f985b4e8c617a665ad5f7b91d93fa885"` [INFO] [stderr] Compiling minifb v0.9.1 [INFO] [stderr] Checking dylib v0.0.1 [INFO] [stderr] Checking x11-dl v2.2.1 [INFO] [stderr] Checking rustboy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bus.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | start_addr: start_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cartridge/mbc1.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | rom_banks: rom_banks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rom_banks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cartridge/mbc1.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | ram_banks: ram_banks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ram_banks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cartridge/mod.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | mapper: mapper, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cpu/instructions/mod.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | let q = (0b00001000 & opcode) >> 3; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bus.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | start_addr: start_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cartridge/mbc1.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | rom_banks: rom_banks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rom_banks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cartridge/mbc1.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | ram_banks: ram_banks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ram_banks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cartridge/mod.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | mapper: mapper, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cpu/instructions/mod.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | let q = (0b00001000 & opcode) >> 3; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bus.rs:137:40 [INFO] [stderr] | [INFO] [stderr] 137 | IO_IF_ADDR => self.io_if | 0b11100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/cartridge/mbc1.rs:75:31 [INFO] [stderr] | [INFO] [stderr] 75 | ram_data: vec![0; (ram_banks * 0x2000)], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/bits.rs:95:23 [INFO] [stderr] | [INFO] [stderr] 95 | let carry = val & 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/bits.rs:123:23 [INFO] [stderr] | [INFO] [stderr] 123 | let carry = val & 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/bits.rs:138:25 [INFO] [stderr] | [INFO] [stderr] 138 | let shifted = val & 0b10000000 | val >> 1; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/bits.rs:167:30 [INFO] [stderr] | [INFO] [stderr] 167 | let shifted = val >> 1 & 0b01111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cpu/instructions/mod.rs:342:5 [INFO] [stderr] | [INFO] [stderr] 342 | instruction [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cpu/instructions/mod.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | / if !prefixed { [INFO] [stderr] 244 | | match (x, y, z, q, p) { [INFO] [stderr] 245 | | // X=0, Z=0 [INFO] [stderr] 246 | | (0, 0, 0, _, _) => Some(Nop), [INFO] [stderr] ... | [INFO] [stderr] 339 | | } [INFO] [stderr] 340 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/mod.rs:229:14 [INFO] [stderr] | [INFO] [stderr] 229 | let x = (0b11000000 & opcode) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/mod.rs:230:14 [INFO] [stderr] | [INFO] [stderr] 230 | let y = (0b00111000 & opcode) >> 3; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/mod.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | let z = 0b00000111 & opcode; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/mod.rs:233:14 [INFO] [stderr] | [INFO] [stderr] 233 | let q = (0b00001000 & opcode) >> 3; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/registers.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | pub const FLAG_Z: u8 = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/registers.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | pub const FLAG_N: u8 = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/registers.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | pub const FLAG_H: u8 = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/registers.rs:45:24 [INFO] [stderr] | [INFO] [stderr] 45 | pub const FLAG_C: u8 = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | Joypad = 0b00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | Serial = 0b00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | Timer = 0b00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | Stat = 0b00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | VBlank = 0b00000001 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/joypad.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | const PIN_15 = 0b100000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/joypad.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | const PIN_14 = 0b010000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/joypad.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | const PIN_13 = 0b001000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/joypad.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | const PIN_12 = 0b000100, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/joypad.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | const PIN_11 = 0b000010, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/joypad.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | const PIN_10 = 0b000001 [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lcd.rs:76:36 [INFO] [stderr] | [INFO] [stderr] 76 | Shade::White => 0x9CBD0F, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x009C_BD0F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lcd.rs:77:36 [INFO] [stderr] | [INFO] [stderr] 77 | Shade::LightGray => 0x8CAD0F, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x008C_AD0F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lcd.rs:78:36 [INFO] [stderr] | [INFO] [stderr] 78 | Shade::DarkGray => 0x306230, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0030_6230` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lcd.rs:79:36 [INFO] [stderr] | [INFO] [stderr] 79 | Shade::Black => 0x0F380F [INFO] [stderr] | ^^^^^^^^ help: consider: `0x000F_380F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lcd.rs:182:28 [INFO] [stderr] | [INFO] [stderr] 182 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 183 | | if self.ly < 144 && self.draw_pending { [INFO] [stderr] 184 | | if self.lcdc.contains(LCDC_BG_DISPLAY) { [INFO] [stderr] 185 | | self.draw_background_line(screen_buffer); [INFO] [stderr] ... | [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 182 | } else if self.ly < 144 && self.draw_pending { [INFO] [stderr] 183 | if self.lcdc.contains(LCDC_BG_DISPLAY) { [INFO] [stderr] 184 | self.draw_background_line(screen_buffer); [INFO] [stderr] 185 | } [INFO] [stderr] 186 | [INFO] [stderr] 187 | self.draw_pending = false; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Khz` [INFO] [stderr] --> src/timer.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / enum_from_primitive! { [INFO] [stderr] 10 | | #[derive(Copy, Clone)] [INFO] [stderr] 11 | | enum TacFrequency { [INFO] [stderr] 12 | | Khz4 = 0, [INFO] [stderr] ... | [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/timer.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | ADDR_TAC => 0b11111000 | ((self.tac_enabled as u8) << 2) | (self.tac_freq as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:72:14 [INFO] [stderr] | [INFO] [stderr] 72 | *i = 0xFFFFFF; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bus.rs:137:40 [INFO] [stderr] | [INFO] [stderr] 137 | IO_IF_ADDR => self.io_if | 0b11100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/cartridge/mbc1.rs:75:31 [INFO] [stderr] | [INFO] [stderr] 75 | ram_data: vec![0; (ram_banks * 0x2000)], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/bits.rs:95:23 [INFO] [stderr] | [INFO] [stderr] 95 | let carry = val & 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/bits.rs:123:23 [INFO] [stderr] | [INFO] [stderr] 123 | let carry = val & 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/bits.rs:138:25 [INFO] [stderr] | [INFO] [stderr] 138 | let shifted = val & 0b10000000 | val >> 1; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/bits.rs:167:30 [INFO] [stderr] | [INFO] [stderr] 167 | let shifted = val >> 1 & 0b01111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:13:20 [INFO] [stderr] | [INFO] [stderr] 13 | cpu.regs.set_a(0b01111111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:17:30 [INFO] [stderr] | [INFO] [stderr] 17 | assert_eq!(cpu.regs.a(), 0b11111110); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | cpu.regs.set_a(0b11111111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:29:30 [INFO] [stderr] | [INFO] [stderr] 29 | assert_eq!(cpu.regs.a(), 0b11111111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | cpu.regs.set_a(0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:63:20 [INFO] [stderr] | [INFO] [stderr] 63 | cpu.regs.set_a(0b01000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | assert_eq!(cpu.regs.a(), 0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:75:20 [INFO] [stderr] | [INFO] [stderr] 75 | cpu.regs.set_a(0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:93:30 [INFO] [stderr] | [INFO] [stderr] 93 | assert_eq!(cpu.regs.a(), 0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:101:20 [INFO] [stderr] | [INFO] [stderr] 101 | cpu.regs.set_a(0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:105:30 [INFO] [stderr] | [INFO] [stderr] 105 | assert_eq!(cpu.regs.a(), 0b01000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:131:30 [INFO] [stderr] | [INFO] [stderr] 131 | assert_eq!(cpu.regs.a(), 0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:139:20 [INFO] [stderr] | [INFO] [stderr] 139 | cpu.regs.set_a(0b00000010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:168:20 [INFO] [stderr] | [INFO] [stderr] 168 | cpu.regs.set_a(0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:182:20 [INFO] [stderr] | [INFO] [stderr] 182 | cpu.regs.set_a(0b00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:186:30 [INFO] [stderr] | [INFO] [stderr] 186 | assert_eq!(cpu.regs.a(), 0b00000010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:213:20 [INFO] [stderr] | [INFO] [stderr] 213 | cpu.regs.set_a(0b00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:217:30 [INFO] [stderr] | [INFO] [stderr] 217 | assert_eq!(cpu.regs.a(), 0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:227:20 [INFO] [stderr] | [INFO] [stderr] 227 | cpu.regs.set_a(0b00000010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:258:20 [INFO] [stderr] | [INFO] [stderr] 258 | cpu.regs.set_a(0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:272:20 [INFO] [stderr] | [INFO] [stderr] 272 | cpu.regs.set_a(0b00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:276:30 [INFO] [stderr] | [INFO] [stderr] 276 | assert_eq!(cpu.regs.a(), 0b00000011); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:307:30 [INFO] [stderr] | [INFO] [stderr] 307 | assert_eq!(cpu.regs.a(), 0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:317:20 [INFO] [stderr] | [INFO] [stderr] 317 | cpu.regs.set_a(0b00000010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:321:30 [INFO] [stderr] | [INFO] [stderr] 321 | assert_eq!(cpu.regs.a(), 0b10000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:348:20 [INFO] [stderr] | [INFO] [stderr] 348 | cpu.regs.set_a(0b11000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:352:30 [INFO] [stderr] | [INFO] [stderr] 352 | assert_eq!(cpu.regs.a(), 0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:362:20 [INFO] [stderr] | [INFO] [stderr] 362 | cpu.regs.set_a(0b01000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:366:30 [INFO] [stderr] | [INFO] [stderr] 366 | assert_eq!(cpu.regs.a(), 0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:376:20 [INFO] [stderr] | [INFO] [stderr] 376 | cpu.regs.set_a(0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:393:20 [INFO] [stderr] | [INFO] [stderr] 393 | cpu.regs.set_a(0b10000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:397:30 [INFO] [stderr] | [INFO] [stderr] 397 | assert_eq!(cpu.regs.a(), 0b11000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:407:20 [INFO] [stderr] | [INFO] [stderr] 407 | cpu.regs.set_a(0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:411:30 [INFO] [stderr] | [INFO] [stderr] 411 | assert_eq!(cpu.regs.a(), 0b11000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:468:20 [INFO] [stderr] | [INFO] [stderr] 468 | cpu.regs.set_a(0b00000011); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:472:30 [INFO] [stderr] | [INFO] [stderr] 472 | assert_eq!(cpu.regs.a(), 0b00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:482:20 [INFO] [stderr] | [INFO] [stderr] 482 | cpu.regs.set_a(0b00000010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:486:30 [INFO] [stderr] | [INFO] [stderr] 486 | assert_eq!(cpu.regs.a(), 0b00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:513:20 [INFO] [stderr] | [INFO] [stderr] 513 | cpu.regs.set_a(0b11101111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:527:20 [INFO] [stderr] | [INFO] [stderr] 527 | cpu.regs.set_a(0b00010000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:546:30 [INFO] [stderr] | [INFO] [stderr] 546 | assert_eq!(cpu.regs.a(), 0b11101111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/bits.rs:561:30 [INFO] [stderr] | [INFO] [stderr] 561 | assert_eq!(cpu.regs.a(), 0b00010000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/math.rs:683:20 [INFO] [stderr] | [INFO] [stderr] 683 | cpu.regs.set_a(0b10101010); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/tests/math.rs:686:30 [INFO] [stderr] | [INFO] [stderr] 686 | assert_eq!(cpu.regs.a(), 0b01010101); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0101_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cpu/instructions/mod.rs:342:5 [INFO] [stderr] | [INFO] [stderr] 342 | instruction [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cpu/instructions/mod.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | / if !prefixed { [INFO] [stderr] 244 | | match (x, y, z, q, p) { [INFO] [stderr] 245 | | // X=0, Z=0 [INFO] [stderr] 246 | | (0, 0, 0, _, _) => Some(Nop), [INFO] [stderr] ... | [INFO] [stderr] 339 | | } [INFO] [stderr] 340 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/mod.rs:229:14 [INFO] [stderr] | [INFO] [stderr] 229 | let x = (0b11000000 & opcode) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/mod.rs:230:14 [INFO] [stderr] | [INFO] [stderr] 230 | let y = (0b00111000 & opcode) >> 3; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/mod.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | let z = 0b00000111 & opcode; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions/mod.rs:233:14 [INFO] [stderr] | [INFO] [stderr] 233 | let q = (0b00001000 & opcode) >> 3; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/registers.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | pub const FLAG_Z: u8 = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/registers.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | pub const FLAG_N: u8 = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/registers.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | pub const FLAG_H: u8 = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/registers.rs:45:24 [INFO] [stderr] | [INFO] [stderr] 45 | pub const FLAG_C: u8 = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | Joypad = 0b00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | Serial = 0b00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lcd.rs:133:43 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn step(&mut self, cycles: usize, mut screen_buffer: &mut [u32]) -> StepResult { [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | Timer = 0b00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | Stat = 0b00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | VBlank = 0b00000001 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/joypad.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | const PIN_15 = 0b100000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/joypad.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | const PIN_14 = 0b010000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/joypad.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | const PIN_13 = 0b001000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/joypad.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | const PIN_12 = 0b000100, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/joypad.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | const PIN_11 = 0b000010, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/joypad.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | const PIN_10 = 0b000001 [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lcd.rs:76:36 [INFO] [stderr] | [INFO] [stderr] 76 | Shade::White => 0x9CBD0F, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x009C_BD0F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lcd.rs:77:36 [INFO] [stderr] | [INFO] [stderr] 77 | Shade::LightGray => 0x8CAD0F, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x008C_AD0F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lcd.rs:78:36 [INFO] [stderr] | [INFO] [stderr] 78 | Shade::DarkGray => 0x306230, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0030_6230` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lcd.rs:79:36 [INFO] [stderr] | [INFO] [stderr] 79 | Shade::Black => 0x0F380F [INFO] [stderr] | ^^^^^^^^ help: consider: `0x000F_380F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lcd.rs:182:28 [INFO] [stderr] | [INFO] [stderr] 182 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 183 | | if self.ly < 144 && self.draw_pending { [INFO] [stderr] 184 | | if self.lcdc.contains(LCDC_BG_DISPLAY) { [INFO] [stderr] 185 | | self.draw_background_line(screen_buffer); [INFO] [stderr] ... | [INFO] [stderr] 189 | | } [INFO] [stderr] 190 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 182 | } else if self.ly < 144 && self.draw_pending { [INFO] [stderr] 183 | if self.lcdc.contains(LCDC_BG_DISPLAY) { [INFO] [stderr] 184 | self.draw_background_line(screen_buffer); [INFO] [stderr] 185 | } [INFO] [stderr] 186 | [INFO] [stderr] 187 | self.draw_pending = false; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Khz` [INFO] [stderr] --> src/timer.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / enum_from_primitive! { [INFO] [stderr] 10 | | #[derive(Copy, Clone)] [INFO] [stderr] 11 | | enum TacFrequency { [INFO] [stderr] 12 | | Khz4 = 0, [INFO] [stderr] ... | [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/timer.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | ADDR_TAC => 0b11111000 | ((self.tac_enabled as u8) << 2) | (self.tac_freq as u8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:72:14 [INFO] [stderr] | [INFO] [stderr] 72 | *i = 0xFFFFFF; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/bus.rs:174:50 [INFO] [stderr] | [INFO] [stderr] 174 | let src_val = self.read(((val as u16) << 8) | lsb); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/cartridge/mbc1.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | _ => panic!("Address {:#X} not handled by MBC1") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/cartridge/mbc1.rs:148:26 [INFO] [stderr] | [INFO] [stderr] 148 | _ => panic!("Address {:#X} not handled by MBC1") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/cartridge/mod.rs:59:65 [INFO] [stderr] | [INFO] [stderr] 59 | String::from_utf8((&self.rom[0x0134..0x0143]).to_vec()).unwrap_or("UNKNOWN".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "UNKNOWN".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cartridge/mod.rs:125:25 [INFO] [stderr] | [INFO] [stderr] 125 | fn read(&self, rom: &Vec, addr: u16) -> u8; [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/debugger/command.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn parse(line: &String, pc: u16) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/debugger/mod.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | if let Ok(_) = stdin().read_line(&mut input) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 58 | | let command = if input.trim().len() == 0 { [INFO] [stderr] 59 | | Ok(self.previous_command) [INFO] [stderr] 60 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____________- help: try this: `if stdin().read_line(&mut input).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/debugger/mod.rs:58:34 [INFO] [stderr] | [INFO] [stderr] 58 | let command = if input.trim().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/debugger/mod.rs:131:21 [INFO] [stderr] | [INFO] [stderr] 131 | length = length + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `length += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/debugger/mod.rs:138:25 [INFO] [stderr] | [INFO] [stderr] 138 | length = length + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `length += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/debugger/mod.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | instruction_addr = instruction_addr + length; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instruction_addr += length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/addressing.rs:34:27 [INFO] [stderr] | [INFO] [stderr] 34 | bus.read(0xFF00 + self.0 as u16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/addressing.rs:38:28 [INFO] [stderr] | [INFO] [stderr] 38 | bus.write(0xFF00 + self.0 as u16, val); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/addressing.rs:54:19 [INFO] [stderr] | [INFO] [stderr] 54 | let low = bus.read(self.0) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bus.read(self.0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/addressing.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | let high = bus.read(self.0 + 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bus.read(self.0 + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/addressing.rs:185:33 [INFO] [stderr] | [INFO] [stderr] 185 | Register::A => 0xFF00 | (cpu.regs.a() as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.a())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/addressing.rs:186:33 [INFO] [stderr] | [INFO] [stderr] 186 | Register::B => 0xFF00 | (cpu.regs.b() as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.b())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/addressing.rs:187:33 [INFO] [stderr] | [INFO] [stderr] 187 | Register::C => 0xFF00 | (cpu.regs.c() as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.c())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/addressing.rs:188:33 [INFO] [stderr] | [INFO] [stderr] 188 | Register::D => 0xFF00 | (cpu.regs.d() as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.d())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/addressing.rs:189:33 [INFO] [stderr] | [INFO] [stderr] 189 | Register::E => 0xFF00 | (cpu.regs.e() as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.e())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/addressing.rs:190:33 [INFO] [stderr] | [INFO] [stderr] 190 | Register::F => 0xFF00 | (cpu.regs.f() as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.f())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/addressing.rs:191:33 [INFO] [stderr] | [INFO] [stderr] 191 | Register::H => 0xFF00 | (cpu.regs.h() as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.h())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/addressing.rs:192:33 [INFO] [stderr] | [INFO] [stderr] 192 | Register::L => 0xFF00 | (cpu.regs.l() as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.regs.l())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions/jumps.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | cpu.regs.set_pc((index * 8) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(index * 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions/loads.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | let unsigned = src.read(cpu, bus) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(src.read(cpu, bus))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions/math.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | let unsigned = src.read(cpu, bus) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(src.read(cpu, bus))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions/math.rs:57:15 [INFO] [stderr] | [INFO] [stderr] 57 | let val = cpu.regs.a() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(cpu.regs.a())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions/math.rs:58:15 [INFO] [stderr] | [INFO] [stderr] 58 | let inc = src.read(cpu, bus) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(src.read(cpu, bus))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/cpu/instructions/math.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | cpu.regs.set_zero((sum & 0xFF) == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `sum.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions/math.rs:88:15 [INFO] [stderr] | [INFO] [stderr] 88 | let val = cpu.regs.a() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(cpu.regs.a())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions/math.rs:89:15 [INFO] [stderr] | [INFO] [stderr] 89 | let dec = src.read(cpu, bus) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(src.read(cpu, bus))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/cpu/instructions/math.rs:98:23 [INFO] [stderr] | [INFO] [stderr] 98 | cpu.regs.set_zero(diff & 0xFF == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `diff.trailing_zeros() >= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/cpu/instructions/math.rs:181:28 [INFO] [stderr] | [INFO] [stderr] 181 | cpu.regs.set_halfcarry(val & 0xF == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `val.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/registers.rs:63:40 [INFO] [stderr] | [INFO] [stderr] 63 | let af = (self.af & 0x00FF) | ((val as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/registers.rs:72:41 [INFO] [stderr] | [INFO] [stderr] 72 | self.bc = (self.bc & 0x00FF) | ((val as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/registers.rs:80:40 [INFO] [stderr] | [INFO] [stderr] 80 | self.bc = (self.bc & 0xFF00) | (val as u16) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/registers.rs:88:41 [INFO] [stderr] | [INFO] [stderr] 88 | self.de = (self.de & 0x00FF) | ((val as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/registers.rs:96:38 [INFO] [stderr] | [INFO] [stderr] 96 | self.de = self.de & 0xFF00 | (val as u16) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/registers.rs:104:39 [INFO] [stderr] | [INFO] [stderr] 104 | let af = (self.af & 0xFF00) | (val as u16) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/registers.rs:113:41 [INFO] [stderr] | [INFO] [stderr] 113 | self.hl = (self.hl & 0x00FF) | ((val as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/registers.rs:121:40 [INFO] [stderr] | [INFO] [stderr] 121 | self.hl = (self.hl & 0xFF00) | (val as u16) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu/mod.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | length = length + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `length += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu/mod.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | length = length + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `length += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cpu/mod.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | flag = flag >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `flag >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/joypad.rs:41:34 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn step(&mut self, keys: &Vec