[INFO] updating cached repository cvent/hogan [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cvent/hogan [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cvent/hogan" "work/ex/clippy-test-run/sources/stable/gh/cvent/hogan"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cvent/hogan'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cvent/hogan" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cvent/hogan"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cvent/hogan'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 55d6190e4e569f70fce1f5e9f0726d9a0f6abbdb [INFO] sha for GitHub repo cvent/hogan: 55d6190e4e569f70fce1f5e9f0726d9a0f6abbdb [INFO] validating manifest of cvent/hogan on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cvent/hogan on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cvent/hogan [INFO] finished frobbing cvent/hogan [INFO] frobbed toml for cvent/hogan written to work/ex/clippy-test-run/sources/stable/gh/cvent/hogan/Cargo.toml [INFO] started frobbing cvent/hogan [INFO] finished frobbing cvent/hogan [INFO] frobbed toml for cvent/hogan written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cvent/hogan/Cargo.toml [INFO] crate cvent/hogan has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cvent/hogan against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cvent/hogan:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9fcec108887db75ece3475abcfc0e66eccb7fa2d04090f58a81f4df8c4d922ba [INFO] running `"docker" "start" "-a" "9fcec108887db75ece3475abcfc0e66eccb7fa2d04090f58a81f4df8c4d922ba"` [INFO] [stderr] Compiling serde v1.0.79 [INFO] [stderr] Checking predicates-core v0.9.0 [INFO] [stderr] Checking normalize-line-endings v0.2.2 [INFO] [stderr] Compiling libz-sys v1.0.23 [INFO] [stderr] Checking dir-diff v0.3.1 [INFO] [stderr] Checking float-cmp v0.4.0 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking gzip-header v0.1.2 [INFO] [stderr] Checking tiny_http v0.6.0 [INFO] [stderr] Checking stderrlog v0.4.1 [INFO] [stderr] Checking predicates-tree v0.9.0 [INFO] [stderr] Checking predicates v0.9.0 [INFO] [stderr] Compiling mime_guess v1.8.6 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Compiling libssh2-sys v0.2.11 [INFO] [stderr] Compiling curl-sys v0.4.12 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Compiling libgit2-sys v0.7.10 [INFO] [stderr] Checking serde_json v1.0.31 [INFO] [stderr] Checking treediff v3.0.1 [INFO] [stderr] Checking escargot v0.3.1 [INFO] [stderr] Checking rouille v2.2.0 [INFO] [stderr] Checking handlebars v1.0.4 [INFO] [stderr] Checking assert_cmd v0.9.1 [INFO] [stderr] Checking json-patch v0.2.2 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking hogan v0.2.7 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/config.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | / if let &Ok(ref config_dir) = &config_dir { [INFO] [stderr] 130 | | if !config_dir.directory().is_dir() { [INFO] [stderr] 131 | | bail!( [INFO] [stderr] 132 | | "{:?} either does not exist or is not a directory. It needs to be both", [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | if let Ok(ref config_dir) = config_dir { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/config.rs:159:42 [INFO] [stderr] | [INFO] [stderr] 159 | fn find_env_type_data<'a>(types: &'a Vec, name: &str) -> &'a Value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[EnvironmentType]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:227:23 [INFO] [stderr] | [INFO] [stderr] 227 | fn as_environment(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:234:28 [INFO] [stderr] | [INFO] [stderr] 234 | fn as_environment_type(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `list` [INFO] [stderr] --> src/transform/helper_comma_delimited_list.rs:31:30 [INFO] [stderr] | [INFO] [stderr] 31 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 31 | for (i, ) in list.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transform/helper_or.rs:24:60 [INFO] [stderr] | [INFO] [stderr] 24 | let comparison = lvalue.as_str().map_or(false, |v| v.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transform/helper_or.rs:25:50 [INFO] [stderr] | [INFO] [stderr] 25 | || rvalue.as_str().map_or(false, |v| v.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/transform/helper_url_add_slash.rs:24:71 [INFO] [stderr] | [INFO] [stderr] 24 | let output = if Url::parse(s).is_ok() && !s.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/transform/helper_url_rm_path.rs:24:42 [INFO] [stderr] | [INFO] [stderr] 24 | let url = if s.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/transform/helper_url_rm_path.rs:37:46 [INFO] [stderr] | [INFO] [stderr] 37 | if url_str.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/transform/helper_url_rm_slash.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | if s.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/template.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | environments: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Environment]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/config.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | / if let &Ok(ref config_dir) = &config_dir { [INFO] [stderr] 130 | | if !config_dir.directory().is_dir() { [INFO] [stderr] 131 | | bail!( [INFO] [stderr] 132 | | "{:?} either does not exist or is not a directory. It needs to be both", [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | if let Ok(ref config_dir) = config_dir { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/config.rs:159:42 [INFO] [stderr] | [INFO] [stderr] 159 | fn find_env_type_data<'a>(types: &'a Vec, name: &str) -> &'a Value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[EnvironmentType]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:227:23 [INFO] [stderr] | [INFO] [stderr] 227 | fn as_environment(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:234:28 [INFO] [stderr] | [INFO] [stderr] 234 | fn as_environment_type(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `list` [INFO] [stderr] --> src/transform/helper_comma_delimited_list.rs:31:30 [INFO] [stderr] | [INFO] [stderr] 31 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 31 | for (i, ) in list.iter().enumerate().take(len) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transform/helper_or.rs:24:60 [INFO] [stderr] | [INFO] [stderr] 24 | let comparison = lvalue.as_str().map_or(false, |v| v.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transform/helper_or.rs:25:50 [INFO] [stderr] | [INFO] [stderr] 25 | || rvalue.as_str().map_or(false, |v| v.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/transform/helper_url_add_slash.rs:24:71 [INFO] [stderr] | [INFO] [stderr] 24 | let output = if Url::parse(s).is_ok() && !s.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/transform/helper_url_rm_path.rs:24:42 [INFO] [stderr] | [INFO] [stderr] 24 | let url = if s.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/transform/helper_url_rm_path.rs:37:46 [INFO] [stderr] | [INFO] [stderr] 37 | if url_str.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/transform/helper_url_rm_slash.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | if s.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/template.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | environments: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Environment]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![warn(unused)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(unused_imports)] implied by #[warn(unused)] [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![warn(unused)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(unused_imports)] implied by #[warn(unused)] [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/main.rs:191:54 [INFO] [stderr] | [INFO] [stderr] 191 | rouille::start_server(("0.0.0.0", port), move |request| { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 192 | | router!(request, [INFO] [stderr] 193 | | (POST) (/refresh) => { [INFO] [stderr] 194 | | match environments.write() { [INFO] [stderr] ... | [INFO] [stderr] 266 | | ) [INFO] [stderr] 267 | | }); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/main.rs:191:54 [INFO] [stderr] | [INFO] [stderr] 191 | rouille::start_server(("0.0.0.0", port), move |request| { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 192 | | router!(request, [INFO] [stderr] 193 | | (POST) (/refresh) => { [INFO] [stderr] 194 | | match environments.write() { [INFO] [stderr] ... | [INFO] [stderr] 266 | | ) [INFO] [stderr] 267 | | }); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 20s [INFO] running `"docker" "inspect" "9fcec108887db75ece3475abcfc0e66eccb7fa2d04090f58a81f4df8c4d922ba"` [INFO] running `"docker" "rm" "-f" "9fcec108887db75ece3475abcfc0e66eccb7fa2d04090f58a81f4df8c4d922ba"` [INFO] [stdout] 9fcec108887db75ece3475abcfc0e66eccb7fa2d04090f58a81f4df8c4d922ba