[INFO] updating cached repository cvent/ecs-manage
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cvent/ecs-manage
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cvent/ecs-manage" "work/ex/clippy-test-run/sources/stable/gh/cvent/ecs-manage"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cvent/ecs-manage'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cvent/ecs-manage" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cvent/ecs-manage"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cvent/ecs-manage'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2b2406b235afdd4bf0c305927b3ea40003861ffe
[INFO] sha for GitHub repo cvent/ecs-manage: 2b2406b235afdd4bf0c305927b3ea40003861ffe
[INFO] validating manifest of cvent/ecs-manage on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cvent/ecs-manage on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cvent/ecs-manage
[INFO] finished frobbing cvent/ecs-manage
[INFO] frobbed toml for cvent/ecs-manage written to work/ex/clippy-test-run/sources/stable/gh/cvent/ecs-manage/Cargo.toml
[INFO] started frobbing cvent/ecs-manage
[INFO] finished frobbing cvent/ecs-manage
[INFO] frobbed toml for cvent/ecs-manage written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cvent/ecs-manage/Cargo.toml
[INFO] crate cvent/ecs-manage has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cvent/ecs-manage against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cvent/ecs-manage:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e0a0cd3515941ea0063a427a491024384b62de2a27000276155339f119b11c87
[INFO] running `"docker" "start" "-a" "e0a0cd3515941ea0063a427a491024384b62de2a27000276155339f119b11c87"`
[INFO] [stderr]     Checking xml-rs v0.7.0
[INFO] [stderr]     Checking backoff v0.1.2
[INFO] [stderr]    Compiling rusoto_core v0.32.0
[INFO] [stderr]     Checking serde_json v1.0.20
[INFO] [stderr]     Checking chrono v0.4.3
[INFO] [stderr]    Compiling structopt-derive v0.2.10
[INFO] [stderr]     Checking stderrlog v0.4.1
[INFO] [stderr]     Checking rusoto_credential v0.11.0
[INFO] [stderr]     Checking structopt v0.2.10
[INFO] [stderr]     Checking rusoto_ecs v0.32.0
[INFO] [stderr]     Checking rusoto_ecr v0.32.0
[INFO] [stderr]     Checking rusoto_elbv2 v0.32.0
[INFO] [stderr]     Checking ecs-manage v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead
[INFO] [stderr]    --> src/args.rs:110:1
[INFO] [stderr]     |
[INFO] [stderr] 110 | / arg_enum!{
[INFO] [stderr] 111 | |     #[derive(Debug)]
[INFO] [stderr] 112 | |     pub enum ServiceProperty {
[INFO] [stderr] 113 | |         DesiredCount,
[INFO] [stderr] 114 | |     }
[INFO] [stderr] 115 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead
[INFO] [stderr]    --> src/args.rs:110:1
[INFO] [stderr]     |
[INFO] [stderr] 110 | / arg_enum!{
[INFO] [stderr] 111 | |     #[derive(Debug)]
[INFO] [stderr] 112 | |     pub enum ServiceProperty {
[INFO] [stderr] 113 | |         DesiredCount,
[INFO] [stderr] 114 | |     }
[INFO] [stderr] 115 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/services.rs:149:25
[INFO] [stderr]     |
[INFO] [stderr] 149 |             role_suffix.unwrap_or(String::from("ECSServiceRole"))
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("ECSServiceRole"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/services.rs:162:60
[INFO] [stderr]     |
[INFO] [stderr] 162 |       let desired_count = from_service.clone().desired_count.ok_or(format_err!(
[INFO] [stderr]     |  ____________________________________________________________^
[INFO] [stderr] 163 | |         "No desired count found for {:?}",
[INFO] [stderr] 164 | |         &service_name
[INFO] [stderr] 165 | |     ))?;
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 162 |     let desired_count = from_service.clone().desired_count.ok_or_else(|| format_err!(
[INFO] [stderr] 163 |         "No desired count found for {:?}",
[INFO] [stderr] 164 |         &service_name
[INFO] [stderr] 165 |     ))?;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/services.rs:167:64
[INFO] [stderr]     |
[INFO] [stderr] 167 |       let task_definition = from_service.clone().task_definition.ok_or(format_err!(
[INFO] [stderr]     |  ________________________________________________________________^
[INFO] [stderr] 168 | |         "No task definition found for {}",
[INFO] [stderr] 169 | |         &service_name
[INFO] [stderr] 170 | |     ))?;
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 167 |     let task_definition = from_service.clone().task_definition.ok_or_else(|| format_err!(
[INFO] [stderr] 168 |         "No task definition found for {}",
[INFO] [stderr] 169 |         &service_name
[INFO] [stderr] 170 |     ))?;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/services.rs:195:18
[INFO] [stderr]     |
[INFO] [stderr] 195 |                 .ok_or(format_err!("Tried to create service, but nothing returned"))?;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Tried to create service, but nothing returned"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/services.rs:229:50
[INFO] [stderr]     |
[INFO] [stderr] 229 |                 DesiredCountOptions::Map(map) => map.get(&service_name).map(|c| c.clone()),
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `map.get(&service_name).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/services.rs:229:81
[INFO] [stderr]     |
[INFO] [stderr] 229 |                 DesiredCountOptions::Map(map) => map.get(&service_name).map(|c| c.clone()),
[INFO] [stderr]     |                                                                                 ^^^^^^^^^ help: try dereferencing it: `*c`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/services.rs:264:10
[INFO] [stderr]     |
[INFO] [stderr] 264 |         .ok_or(format_err!("Tried to update service, but nothing returned"))
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Tried to update service, but nothing returned"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/services.rs:322:29
[INFO] [stderr]     |
[INFO] [stderr] 322 | /                             match image_arn {
[INFO] [stderr] 323 | |                                 Some(image_arn) => {
[INFO] [stderr] 324 | |                                     match image_arn.split('/').collect::<Vec<&str>>().pop() {
[INFO] [stderr] 325 | |                                         Some(repo_image) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 370 | |                                 None => {}
[INFO] [stderr] 371 | |                             }
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 322 |                             if let Some(image_arn) = image_arn {
[INFO] [stderr] 323 |     match image_arn.split('/').collect::<Vec<&str>>().pop() {
[INFO] [stderr] 324 |         Some(repo_image) => {
[INFO] [stderr] 325 |             let split_repo_image =
[INFO] [stderr] 326 |                 repo_image.splitn(2, ':').collect::<Vec<&str>>();
[INFO] [stderr] 327 | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/services.rs:324:37
[INFO] [stderr]     |
[INFO] [stderr] 324 | /                                     match image_arn.split('/').collect::<Vec<&str>>().pop() {
[INFO] [stderr] 325 | |                                         Some(repo_image) => {
[INFO] [stderr] 326 | |                                             let split_repo_image =
[INFO] [stderr] 327 | |                                                 repo_image.splitn(2, ':').collect::<Vec<&str>>();
[INFO] [stderr] ...   |
[INFO] [stderr] 367 | |                                         None => {}
[INFO] [stderr] 368 | |                                     }
[INFO] [stderr]     | |_____________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 324 |                                     if let Some(repo_image) = image_arn.split('/').collect::<Vec<&str>>().pop() {
[INFO] [stderr] 325 |     let split_repo_image =
[INFO] [stderr] 326 |         repo_image.splitn(2, ':').collect::<Vec<&str>>();
[INFO] [stderr] 327 | 
[INFO] [stderr] 328 |     let image_id = ImageIdentifier {
[INFO] [stderr] 329 |         image_digest: None,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/services.rs:352:53
[INFO] [stderr]     |
[INFO] [stderr] 352 | /                                                     match image_details_res.image_details {
[INFO] [stderr] 353 | |                                                         Some(mut image_details) => {
[INFO] [stderr] 354 | |                                                             match image_details.pop() {
[INFO] [stderr] 355 | |                                                                 Some(image_detail) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 361 | |                                                         None => {}
[INFO] [stderr] 362 | |                                                     }
[INFO] [stderr]     | |_____________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 352 |                                                     if let Some(mut image_details) = image_details_res.image_details {
[INFO] [stderr] 353 |     match image_details.pop() {
[INFO] [stderr] 354 |         Some(image_detail) => {
[INFO] [stderr] 355 |             images.push(Ok(image_detail));
[INFO] [stderr] 356 |         }
[INFO] [stderr] 357 |         None => {}
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/services.rs:354:61
[INFO] [stderr]     |
[INFO] [stderr] 354 | /                                                             match image_details.pop() {
[INFO] [stderr] 355 | |                                                                 Some(image_detail) => {
[INFO] [stderr] 356 | |                                                                     images.push(Ok(image_detail));
[INFO] [stderr] 357 | |                                                                 }
[INFO] [stderr] 358 | |                                                                 None => {}
[INFO] [stderr] 359 | |                                                             }
[INFO] [stderr]     | |_____________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 354 |                                                             if let Some(image_detail) = image_details.pop() {
[INFO] [stderr] 355 |     images.push(Ok(image_detail));
[INFO] [stderr] 356 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/services.rs:394:17
[INFO] [stderr]     |
[INFO] [stderr] 394 | /                 match target_group_arn {
[INFO] [stderr] 395 | |                     Some(target_group_arn) => {
[INFO] [stderr] 396 | |                         let target_groups_res =
[INFO] [stderr] 397 | |                             helpers::retry_log(format!("describing {}", target_group_arn), || {
[INFO] [stderr] ...   |
[INFO] [stderr] 438 | |                     None => {}
[INFO] [stderr] 439 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 394 |                 if let Some(target_group_arn) = target_group_arn {
[INFO] [stderr] 395 |     let target_groups_res =
[INFO] [stderr] 396 |         helpers::retry_log(format!("describing {}", target_group_arn), || {
[INFO] [stderr] 397 |             elb_client
[INFO] [stderr] 398 |                 .describe_target_groups(&DescribeTargetGroupsInput {
[INFO] [stderr] 399 |                     load_balancer_arn: None,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/services.rs:424:54
[INFO] [stderr]     |
[INFO] [stderr] 424 |                               Ok(target_groups_res) => match target_groups_res.target_groups {
[INFO] [stderr]     |  ______________________________________________________^
[INFO] [stderr] 425 | |                                 Some(mut target_group_details) => {
[INFO] [stderr] 426 | |                                     match target_group_details.pop() {
[INFO] [stderr] 427 | |                                         Some(target_group_detail) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 433 | |                                 None => {}
[INFO] [stderr] 434 | |                             },
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 424 |                             Ok(target_groups_res) => if let Some(mut target_group_details) = target_groups_res.target_groups {
[INFO] [stderr] 425 |     match target_group_details.pop() {
[INFO] [stderr] 426 |         Some(target_group_detail) => {
[INFO] [stderr] 427 |             target_groups.push(Ok(target_group_detail));
[INFO] [stderr] 428 |         }
[INFO] [stderr] 429 |         None => {}
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/services.rs:426:37
[INFO] [stderr]     |
[INFO] [stderr] 426 | /                                     match target_group_details.pop() {
[INFO] [stderr] 427 | |                                         Some(target_group_detail) => {
[INFO] [stderr] 428 | |                                             target_groups.push(Ok(target_group_detail));
[INFO] [stderr] 429 | |                                         }
[INFO] [stderr] 430 | |                                         None => {}
[INFO] [stderr] 431 | |                                     }
[INFO] [stderr]     | |_____________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 426 |                                     if let Some(target_group_detail) = target_group_details.pop() {
[INFO] [stderr] 427 |     target_groups.push(Ok(target_group_detail));
[INFO] [stderr] 428 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:62:45
[INFO] [stderr]    |
[INFO] [stderr] 62 |                       service.task_definition.ok_or(format_err!(
[INFO] [stderr]    |  _____________________________________________^
[INFO] [stderr] 63 | |                         "Service {:?} has no task definition",
[INFO] [stderr] 64 | |                         &service_name
[INFO] [stderr] 65 | |                     ))?,
[INFO] [stderr]    | |______________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 62 |                     service.task_definition.ok_or_else(|| format_err!(
[INFO] [stderr] 63 |                         "Service {:?} has no task definition",
[INFO] [stderr] 64 |                         &service_name
[INFO] [stderr] 65 |                     ))?,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:68:26
[INFO] [stderr]    |
[INFO] [stderr] 68 |                         .ok_or(format_err!("Service {} has no desired count", service_name))?,
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Service {} has no desired count", service_name))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/services.rs:149:25
[INFO] [stderr]     |
[INFO] [stderr] 149 |             role_suffix.unwrap_or(String::from("ECSServiceRole"))
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("ECSServiceRole"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/services.rs:162:60
[INFO] [stderr]     |
[INFO] [stderr] 162 |       let desired_count = from_service.clone().desired_count.ok_or(format_err!(
[INFO] [stderr]     |  ____________________________________________________________^
[INFO] [stderr] 163 | |         "No desired count found for {:?}",
[INFO] [stderr] 164 | |         &service_name
[INFO] [stderr] 165 | |     ))?;
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 162 |     let desired_count = from_service.clone().desired_count.ok_or_else(|| format_err!(
[INFO] [stderr] 163 |         "No desired count found for {:?}",
[INFO] [stderr] 164 |         &service_name
[INFO] [stderr] 165 |     ))?;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/services.rs:167:64
[INFO] [stderr]     |
[INFO] [stderr] 167 |       let task_definition = from_service.clone().task_definition.ok_or(format_err!(
[INFO] [stderr]     |  ________________________________________________________________^
[INFO] [stderr] 168 | |         "No task definition found for {}",
[INFO] [stderr] 169 | |         &service_name
[INFO] [stderr] 170 | |     ))?;
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 167 |     let task_definition = from_service.clone().task_definition.ok_or_else(|| format_err!(
[INFO] [stderr] 168 |         "No task definition found for {}",
[INFO] [stderr] 169 |         &service_name
[INFO] [stderr] 170 |     ))?;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/services.rs:195:18
[INFO] [stderr]     |
[INFO] [stderr] 195 |                 .ok_or(format_err!("Tried to create service, but nothing returned"))?;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Tried to create service, but nothing returned"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/services.rs:229:50
[INFO] [stderr]     |
[INFO] [stderr] 229 |                 DesiredCountOptions::Map(map) => map.get(&service_name).map(|c| c.clone()),
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `map.get(&service_name).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/services.rs:229:81
[INFO] [stderr]     |
[INFO] [stderr] 229 |                 DesiredCountOptions::Map(map) => map.get(&service_name).map(|c| c.clone()),
[INFO] [stderr]     |                                                                                 ^^^^^^^^^ help: try dereferencing it: `*c`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/services.rs:264:10
[INFO] [stderr]     |
[INFO] [stderr] 264 |         .ok_or(format_err!("Tried to update service, but nothing returned"))
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Tried to update service, but nothing returned"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/services.rs:322:29
[INFO] [stderr]     |
[INFO] [stderr] 322 | /                             match image_arn {
[INFO] [stderr] 323 | |                                 Some(image_arn) => {
[INFO] [stderr] 324 | |                                     match image_arn.split('/').collect::<Vec<&str>>().pop() {
[INFO] [stderr] 325 | |                                         Some(repo_image) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 370 | |                                 None => {}
[INFO] [stderr] 371 | |                             }
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 322 |                             if let Some(image_arn) = image_arn {
[INFO] [stderr] 323 |     match image_arn.split('/').collect::<Vec<&str>>().pop() {
[INFO] [stderr] 324 |         Some(repo_image) => {
[INFO] [stderr] 325 |             let split_repo_image =
[INFO] [stderr] 326 |                 repo_image.splitn(2, ':').collect::<Vec<&str>>();
[INFO] [stderr] 327 | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/services.rs:324:37
[INFO] [stderr]     |
[INFO] [stderr] 324 | /                                     match image_arn.split('/').collect::<Vec<&str>>().pop() {
[INFO] [stderr] 325 | |                                         Some(repo_image) => {
[INFO] [stderr] 326 | |                                             let split_repo_image =
[INFO] [stderr] 327 | |                                                 repo_image.splitn(2, ':').collect::<Vec<&str>>();
[INFO] [stderr] ...   |
[INFO] [stderr] 367 | |                                         None => {}
[INFO] [stderr] 368 | |                                     }
[INFO] [stderr]     | |_____________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 324 |                                     if let Some(repo_image) = image_arn.split('/').collect::<Vec<&str>>().pop() {
[INFO] [stderr] 325 |     let split_repo_image =
[INFO] [stderr] 326 |         repo_image.splitn(2, ':').collect::<Vec<&str>>();
[INFO] [stderr] 327 | 
[INFO] [stderr] 328 |     let image_id = ImageIdentifier {
[INFO] [stderr] 329 |         image_digest: None,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/services.rs:352:53
[INFO] [stderr]     |
[INFO] [stderr] 352 | /                                                     match image_details_res.image_details {
[INFO] [stderr] 353 | |                                                         Some(mut image_details) => {
[INFO] [stderr] 354 | |                                                             match image_details.pop() {
[INFO] [stderr] 355 | |                                                                 Some(image_detail) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 361 | |                                                         None => {}
[INFO] [stderr] 362 | |                                                     }
[INFO] [stderr]     | |_____________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 352 |                                                     if let Some(mut image_details) = image_details_res.image_details {
[INFO] [stderr] 353 |     match image_details.pop() {
[INFO] [stderr] 354 |         Some(image_detail) => {
[INFO] [stderr] 355 |             images.push(Ok(image_detail));
[INFO] [stderr] 356 |         }
[INFO] [stderr] 357 |         None => {}
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/services.rs:354:61
[INFO] [stderr]     |
[INFO] [stderr] 354 | /                                                             match image_details.pop() {
[INFO] [stderr] 355 | |                                                                 Some(image_detail) => {
[INFO] [stderr] 356 | |                                                                     images.push(Ok(image_detail));
[INFO] [stderr] 357 | |                                                                 }
[INFO] [stderr] 358 | |                                                                 None => {}
[INFO] [stderr] 359 | |                                                             }
[INFO] [stderr]     | |_____________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 354 |                                                             if let Some(image_detail) = image_details.pop() {
[INFO] [stderr] 355 |     images.push(Ok(image_detail));
[INFO] [stderr] 356 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/services.rs:394:17
[INFO] [stderr]     |
[INFO] [stderr] 394 | /                 match target_group_arn {
[INFO] [stderr] 395 | |                     Some(target_group_arn) => {
[INFO] [stderr] 396 | |                         let target_groups_res =
[INFO] [stderr] 397 | |                             helpers::retry_log(format!("describing {}", target_group_arn), || {
[INFO] [stderr] ...   |
[INFO] [stderr] 438 | |                     None => {}
[INFO] [stderr] 439 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 394 |                 if let Some(target_group_arn) = target_group_arn {
[INFO] [stderr] 395 |     let target_groups_res =
[INFO] [stderr] 396 |         helpers::retry_log(format!("describing {}", target_group_arn), || {
[INFO] [stderr] 397 |             elb_client
[INFO] [stderr] 398 |                 .describe_target_groups(&DescribeTargetGroupsInput {
[INFO] [stderr] 399 |                     load_balancer_arn: None,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/services.rs:424:54
[INFO] [stderr]     |
[INFO] [stderr] 424 |                               Ok(target_groups_res) => match target_groups_res.target_groups {
[INFO] [stderr]     |  ______________________________________________________^
[INFO] [stderr] 425 | |                                 Some(mut target_group_details) => {
[INFO] [stderr] 426 | |                                     match target_group_details.pop() {
[INFO] [stderr] 427 | |                                         Some(target_group_detail) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 433 | |                                 None => {}
[INFO] [stderr] 434 | |                             },
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 424 |                             Ok(target_groups_res) => if let Some(mut target_group_details) = target_groups_res.target_groups {
[INFO] [stderr] 425 |     match target_group_details.pop() {
[INFO] [stderr] 426 |         Some(target_group_detail) => {
[INFO] [stderr] 427 |             target_groups.push(Ok(target_group_detail));
[INFO] [stderr] 428 |         }
[INFO] [stderr] 429 |         None => {}
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/services.rs:426:37
[INFO] [stderr]     |
[INFO] [stderr] 426 | /                                     match target_group_details.pop() {
[INFO] [stderr] 427 | |                                         Some(target_group_detail) => {
[INFO] [stderr] 428 | |                                             target_groups.push(Ok(target_group_detail));
[INFO] [stderr] 429 | |                                         }
[INFO] [stderr] 430 | |                                         None => {}
[INFO] [stderr] 431 | |                                     }
[INFO] [stderr]     | |_____________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 426 |                                     if let Some(target_group_detail) = target_group_details.pop() {
[INFO] [stderr] 427 |     target_groups.push(Ok(target_group_detail));
[INFO] [stderr] 428 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:62:45
[INFO] [stderr]    |
[INFO] [stderr] 62 |                       service.task_definition.ok_or(format_err!(
[INFO] [stderr]    |  _____________________________________________^
[INFO] [stderr] 63 | |                         "Service {:?} has no task definition",
[INFO] [stderr] 64 | |                         &service_name
[INFO] [stderr] 65 | |                     ))?,
[INFO] [stderr]    | |______________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 62 |                     service.task_definition.ok_or_else(|| format_err!(
[INFO] [stderr] 63 |                         "Service {:?} has no task definition",
[INFO] [stderr] 64 |                         &service_name
[INFO] [stderr] 65 |                     ))?,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:68:26
[INFO] [stderr]    |
[INFO] [stderr] 68 |                         .ok_or(format_err!("Service {} has no desired count", service_name))?,
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Service {} has no desired count", service_name))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 45.47s
[INFO] running `"docker" "inspect" "e0a0cd3515941ea0063a427a491024384b62de2a27000276155339f119b11c87"`
[INFO] running `"docker" "rm" "-f" "e0a0cd3515941ea0063a427a491024384b62de2a27000276155339f119b11c87"`
[INFO] [stdout] e0a0cd3515941ea0063a427a491024384b62de2a27000276155339f119b11c87