[INFO] updating cached repository cultofmetatron/r_monkey [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cultofmetatron/r_monkey [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cultofmetatron/r_monkey" "work/ex/clippy-test-run/sources/stable/gh/cultofmetatron/r_monkey"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cultofmetatron/r_monkey'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cultofmetatron/r_monkey" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cultofmetatron/r_monkey"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cultofmetatron/r_monkey'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ddf5036a36cc4315bb88914e2b7e59dcb32d6f5e [INFO] sha for GitHub repo cultofmetatron/r_monkey: ddf5036a36cc4315bb88914e2b7e59dcb32d6f5e [INFO] validating manifest of cultofmetatron/r_monkey on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cultofmetatron/r_monkey on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cultofmetatron/r_monkey [INFO] finished frobbing cultofmetatron/r_monkey [INFO] frobbed toml for cultofmetatron/r_monkey written to work/ex/clippy-test-run/sources/stable/gh/cultofmetatron/r_monkey/Cargo.toml [INFO] started frobbing cultofmetatron/r_monkey [INFO] finished frobbing cultofmetatron/r_monkey [INFO] frobbed toml for cultofmetatron/r_monkey written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cultofmetatron/r_monkey/Cargo.toml [INFO] crate cultofmetatron/r_monkey has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cultofmetatron/r_monkey against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cultofmetatron/r_monkey:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 16a5308dcc3cce9c61967b64af0b84a075d6524cd032b7c1ca1e6b7f25061dc3 [INFO] running `"docker" "start" "-a" "16a5308dcc3cce9c61967b64af0b84a075d6524cd032b7c1ca1e6b7f25061dc3"` [INFO] [stderr] Checking r_monkey v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | tokens: tokens [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | tokens: tokens [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/lexer.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | / return Lexer { [INFO] [stderr] 55 | | input: input, [INFO] [stderr] 56 | | tokens: tokens [INFO] [stderr] 57 | | }; [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | Lexer { [INFO] [stderr] 55 | input: input, [INFO] [stderr] 56 | tokens: tokens [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return tokens; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/lexer.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | / return Lexer { [INFO] [stderr] 55 | | input: input, [INFO] [stderr] 56 | | tokens: tokens [INFO] [stderr] 57 | | }; [INFO] [stderr] | |________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | Lexer { [INFO] [stderr] 55 | input: input, [INFO] [stderr] 56 | tokens: tokens [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return tokens; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `skip` [INFO] [stderr] --> src/lexer.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | let mut skip : bool = false; [INFO] [stderr] | ^^^^ help: consider using `_skip` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `index` [INFO] [stderr] --> src/lexer.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | let mut index : usize = 0; [INFO] [stderr] | ^^^^^ help: consider using `_index` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lexer.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | let mut skip : bool = false; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lexer.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | let mut index : usize = 0; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Asterix` [INFO] [stderr] --> src/lexer.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | Asterix, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_complex_modifier` [INFO] [stderr] --> src/lexer.rs:144:3 [INFO] [stderr] | [INFO] [stderr] 144 | fn is_complex_modifier(ch1: char) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `NextChar` [INFO] [stderr] --> src/lexer.rs:154:3 [INFO] [stderr] | [INFO] [stderr] 154 | enum NextChar { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `peek_ahead` [INFO] [stderr] --> src/lexer.rs:159:3 [INFO] [stderr] | [INFO] [stderr] 159 | fn peek_ahead(index: usize, aStr: &Vec) -> NextChar { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexer.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | fn tokenizer (input : &String) -> Vec{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable `charTerator` should have a snake case name such as `char_terator` [INFO] [stderr] --> src/lexer.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | let mut charTerator = input.chars().peekable(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lexer.rs:159:37 [INFO] [stderr] | [INFO] [stderr] 159 | fn peek_ahead(index: usize, aStr: &Vec) -> NextChar { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable `aStr` should have a snake case name such as `a_str` [INFO] [stderr] --> src/lexer.rs:159:31 [INFO] [stderr] | [INFO] [stderr] 159 | fn peek_ahead(index: usize, aStr: &Vec) -> NextChar { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexer.rs:216:24 [INFO] [stderr] | [INFO] [stderr] 216 | fn is_number(ident : &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `skip` [INFO] [stderr] --> src/lexer.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | let mut skip : bool = false; [INFO] [stderr] | ^^^^ help: consider using `_skip` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `index` [INFO] [stderr] --> src/lexer.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | let mut index : usize = 0; [INFO] [stderr] | ^^^^^ help: consider using `_index` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lexer.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | let mut skip : bool = false; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lexer.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | let mut index : usize = 0; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Asterix` [INFO] [stderr] --> src/lexer.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | Asterix, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_complex_modifier` [INFO] [stderr] --> src/lexer.rs:144:3 [INFO] [stderr] | [INFO] [stderr] 144 | fn is_complex_modifier(ch1: char) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `NextChar` [INFO] [stderr] --> src/lexer.rs:154:3 [INFO] [stderr] | [INFO] [stderr] 154 | enum NextChar { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `peek_ahead` [INFO] [stderr] --> src/lexer.rs:159:3 [INFO] [stderr] | [INFO] [stderr] 159 | fn peek_ahead(index: usize, aStr: &Vec) -> NextChar { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexer.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | fn tokenizer (input : &String) -> Vec{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable `charTerator` should have a snake case name such as `char_terator` [INFO] [stderr] --> src/lexer.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | let mut charTerator = input.chars().peekable(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lexer.rs:159:37 [INFO] [stderr] | [INFO] [stderr] 159 | fn peek_ahead(index: usize, aStr: &Vec) -> NextChar { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable `aStr` should have a snake case name such as `a_str` [INFO] [stderr] --> src/lexer.rs:159:31 [INFO] [stderr] | [INFO] [stderr] 159 | fn peek_ahead(index: usize, aStr: &Vec) -> NextChar { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexer.rs:216:24 [INFO] [stderr] | [INFO] [stderr] 216 | fn is_number(ident : &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "16a5308dcc3cce9c61967b64af0b84a075d6524cd032b7c1ca1e6b7f25061dc3"` [INFO] running `"docker" "rm" "-f" "16a5308dcc3cce9c61967b64af0b84a075d6524cd032b7c1ca1e6b7f25061dc3"` [INFO] [stdout] 16a5308dcc3cce9c61967b64af0b84a075d6524cd032b7c1ca1e6b7f25061dc3