[INFO] updating cached repository cuebyte/file-crypto [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cuebyte/file-crypto [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cuebyte/file-crypto" "work/ex/clippy-test-run/sources/stable/gh/cuebyte/file-crypto"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cuebyte/file-crypto'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cuebyte/file-crypto" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cuebyte/file-crypto"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cuebyte/file-crypto'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 163e10fc8f3afa1ba936375251b25ab89e891518 [INFO] sha for GitHub repo cuebyte/file-crypto: 163e10fc8f3afa1ba936375251b25ab89e891518 [INFO] validating manifest of cuebyte/file-crypto on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cuebyte/file-crypto on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cuebyte/file-crypto [INFO] finished frobbing cuebyte/file-crypto [INFO] frobbed toml for cuebyte/file-crypto written to work/ex/clippy-test-run/sources/stable/gh/cuebyte/file-crypto/Cargo.toml [INFO] started frobbing cuebyte/file-crypto [INFO] finished frobbing cuebyte/file-crypto [INFO] frobbed toml for cuebyte/file-crypto written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cuebyte/file-crypto/Cargo.toml [INFO] crate cuebyte/file-crypto has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cuebyte/file-crypto against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cuebyte/file-crypto:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f938c0ced3e98a326577aae92d732a7346e96f4544c80e0fd88c274743ede249 [INFO] running `"docker" "start" "-a" "f938c0ced3e98a326577aae92d732a7346e96f4544c80e0fd88c274743ede249"` [INFO] [stderr] Checking file-crypto v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | page: page, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `page` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | page: page, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `page` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | page: page, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `page` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | page: page, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `page` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/meta.rs:116:31 [INFO] [stderr] | [INFO] [stderr] 116 | const MIN_CHUNK_SIZE: usize = 0x100000; // 1Mb [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/meta.rs:116:31 [INFO] [stderr] | [INFO] [stderr] 116 | const MIN_CHUNK_SIZE: usize = 0x100000; // 1Mb [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `crypto::Key` [INFO] [stderr] --> src/crypto.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | let mut key = [0u8; KEY_LEN]; [INFO] [stderr] 22 | | SystemRandom::new().fill(&mut key).unwrap(); [INFO] [stderr] 23 | | Key(key) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `crypto::Key` [INFO] [stderr] --> src/crypto.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | let mut key = [0u8; KEY_LEN]; [INFO] [stderr] 22 | | SystemRandom::new().fill(&mut key).unwrap(); [INFO] [stderr] 23 | | Key(key) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | page: page, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `page` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | page: page, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `page` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | page: page, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `page` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | page: page, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `page` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/integration_test.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | let s0 = (0u32..1000000u32) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/integration_test.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | let s1 = (0u32..1000000u32) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/integration_test.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | let mb = 1048576.0; [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_048_576.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/integration_test.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | let s1 = (0u32..1000000u32) [INFO] [stderr] | ______________^ [INFO] [stderr] 33 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `(0u32..1000000u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/integration_test.rs:66:93 [INFO] [stderr] | [INFO] [stderr] 66 | e.metadata().unwrap().is_file() && !e.file_name().to_str().unwrap().starts_with(".") [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/meta.rs:116:31 [INFO] [stderr] | [INFO] [stderr] 116 | const MIN_CHUNK_SIZE: usize = 0x100000; // 1Mb [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/meta.rs:116:31 [INFO] [stderr] | [INFO] [stderr] 116 | const MIN_CHUNK_SIZE: usize = 0x100000; // 1Mb [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `crypto::Key` [INFO] [stderr] --> src/crypto.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | let mut key = [0u8; KEY_LEN]; [INFO] [stderr] 22 | | SystemRandom::new().fill(&mut key).unwrap(); [INFO] [stderr] 23 | | Key(key) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `crypto::Key` [INFO] [stderr] --> src/crypto.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Self { [INFO] [stderr] 21 | | let mut key = [0u8; KEY_LEN]; [INFO] [stderr] 22 | | SystemRandom::new().fill(&mut key).unwrap(); [INFO] [stderr] 23 | | Key(key) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.45s [INFO] running `"docker" "inspect" "f938c0ced3e98a326577aae92d732a7346e96f4544c80e0fd88c274743ede249"` [INFO] running `"docker" "rm" "-f" "f938c0ced3e98a326577aae92d732a7346e96f4544c80e0fd88c274743ede249"` [INFO] [stdout] f938c0ced3e98a326577aae92d732a7346e96f4544c80e0fd88c274743ede249