[INFO] updating cached repository cswl/git-all
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cswl/git-all
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cswl/git-all" "work/ex/clippy-test-run/sources/stable/gh/cswl/git-all"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cswl/git-all'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cswl/git-all" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cswl/git-all"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cswl/git-all'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8b47bee2f21b43674f65fe10716b7725e08730aa
[INFO] sha for GitHub repo cswl/git-all: 8b47bee2f21b43674f65fe10716b7725e08730aa
[INFO] validating manifest of cswl/git-all on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cswl/git-all on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cswl/git-all
[INFO] finished frobbing cswl/git-all
[INFO] frobbed toml for cswl/git-all written to work/ex/clippy-test-run/sources/stable/gh/cswl/git-all/Cargo.toml
[INFO] started frobbing cswl/git-all
[INFO] finished frobbing cswl/git-all
[INFO] frobbed toml for cswl/git-all written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cswl/git-all/Cargo.toml
[INFO] crate cswl/git-all has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cswl/git-all against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cswl/git-all:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9c7d546d9d0b162eec6989d1a1feab36c6b508119b3d216d8707b2b594f46d48
[INFO] running `"docker" "start" "-a" "9c7d546d9d0b162eec6989d1a1feab36c6b508119b3d216d8707b2b594f46d48"`
[INFO] [stderr]     Checking subprocess v0.1.12
[INFO] [stderr]     Checking git-all v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused imports: `Error as SerdeError`, `Value`
[INFO] [stderr]   --> src/main.rs:10:18
[INFO] [stderr]    |
[INFO] [stderr] 10 | use serde_json::{Error as SerdeError, Value};
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `PopenConfig`, `Popen`
[INFO] [stderr]   --> src/main.rs:16:24
[INFO] [stderr]    |
[INFO] [stderr] 16 | use subprocess::{Exec, Popen, PopenConfig, Redirection};
[INFO] [stderr]    |                        ^^^^^  ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/scan.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 | /         if entry.file_type().is_dir() {
[INFO] [stderr] 35 | |             if is_git_repo(&entry) {
[INFO] [stderr] 36 | |                 // Stop further recursing if it is a git repo
[INFO] [stderr] 37 | |                 walker.skip_current_dir();
[INFO] [stderr] ...  |
[INFO] [stderr] 41 | |             }
[INFO] [stderr] 42 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 34 |         if entry.file_type().is_dir() && is_git_repo(&entry) {
[INFO] [stderr] 35 |     // Stop further recursing if it is a git repo
[INFO] [stderr] 36 |     walker.skip_current_dir();
[INFO] [stderr] 37 |     let path = entry.path();
[INFO] [stderr] 38 |     // println!("{}", path.display());
[INFO] [stderr] 39 |     git_dirs.push(path.to_owned());
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `matches`
[INFO] [stderr]   --> src/main.rs:41:17
[INFO] [stderr]    |
[INFO] [stderr] 41 |     if let Some(matches) = matches.subcommand_matches("status") {
[INFO] [stderr]    |                 ^^^^^^^ help: consider using `_matches` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `exit_status`
[INFO] [stderr]   --> src/main.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 |     let exit_status = Exec::cmd("git")
[INFO] [stderr]    |         ^^^^^^^^^^^ help: consider using `_exit_status` instead
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `ScanFlags`
[INFO] [stderr]  --> src/scan.rs:9:1
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub struct ScanFlags {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `Symlinks` should have a snake case name such as `symlinks`
[INFO] [stderr]   --> src/scan.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     Symlinks: bool,     // Whether to follow symlinks
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `TopLevelOnly` should have a snake case name such as `top_level_only`
[INFO] [stderr]   --> src/scan.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     TopLevelOnly: bool, // Whether to stop after first .git repo
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Error as SerdeError`, `Value`
[INFO] [stderr]   --> src/main.rs:10:18
[INFO] [stderr]    |
[INFO] [stderr] 10 | use serde_json::{Error as SerdeError, Value};
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `PopenConfig`, `Popen`
[INFO] [stderr]   --> src/main.rs:16:24
[INFO] [stderr]    |
[INFO] [stderr] 16 | use subprocess::{Exec, Popen, PopenConfig, Redirection};
[INFO] [stderr]    |                        ^^^^^  ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/scan.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 | /         if entry.file_type().is_dir() {
[INFO] [stderr] 35 | |             if is_git_repo(&entry) {
[INFO] [stderr] 36 | |                 // Stop further recursing if it is a git repo
[INFO] [stderr] 37 | |                 walker.skip_current_dir();
[INFO] [stderr] ...  |
[INFO] [stderr] 41 | |             }
[INFO] [stderr] 42 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 34 |         if entry.file_type().is_dir() && is_git_repo(&entry) {
[INFO] [stderr] 35 |     // Stop further recursing if it is a git repo
[INFO] [stderr] 36 |     walker.skip_current_dir();
[INFO] [stderr] 37 |     let path = entry.path();
[INFO] [stderr] 38 |     // println!("{}", path.display());
[INFO] [stderr] 39 |     git_dirs.push(path.to_owned());
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `matches`
[INFO] [stderr]   --> src/main.rs:41:17
[INFO] [stderr]    |
[INFO] [stderr] 41 |     if let Some(matches) = matches.subcommand_matches("status") {
[INFO] [stderr]    |                 ^^^^^^^ help: consider using `_matches` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `exit_status`
[INFO] [stderr]   --> src/main.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 |     let exit_status = Exec::cmd("git")
[INFO] [stderr]    |         ^^^^^^^^^^^ help: consider using `_exit_status` instead
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `ScanFlags`
[INFO] [stderr]  --> src/scan.rs:9:1
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub struct ScanFlags {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `Symlinks` should have a snake case name such as `symlinks`
[INFO] [stderr]   --> src/scan.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     Symlinks: bool,     // Whether to follow symlinks
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `TopLevelOnly` should have a snake case name such as `top_level_only`
[INFO] [stderr]   --> src/scan.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     TopLevelOnly: bool, // Whether to stop after first .git repo
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.93s
[INFO] running `"docker" "inspect" "9c7d546d9d0b162eec6989d1a1feab36c6b508119b3d216d8707b2b594f46d48"`
[INFO] running `"docker" "rm" "-f" "9c7d546d9d0b162eec6989d1a1feab36c6b508119b3d216d8707b2b594f46d48"`
[INFO] [stdout] 9c7d546d9d0b162eec6989d1a1feab36c6b508119b3d216d8707b2b594f46d48