[INFO] updating cached repository cstyles/http_server_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cstyles/http_server_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cstyles/http_server_rust" "work/ex/clippy-test-run/sources/stable/gh/cstyles/http_server_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cstyles/http_server_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cstyles/http_server_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cstyles/http_server_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cstyles/http_server_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 83df5bf69b625b9eb30ff4e5a356a90c9b9a667c [INFO] sha for GitHub repo cstyles/http_server_rust: 83df5bf69b625b9eb30ff4e5a356a90c9b9a667c [INFO] validating manifest of cstyles/http_server_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cstyles/http_server_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cstyles/http_server_rust [INFO] finished frobbing cstyles/http_server_rust [INFO] frobbed toml for cstyles/http_server_rust written to work/ex/clippy-test-run/sources/stable/gh/cstyles/http_server_rust/Cargo.toml [INFO] started frobbing cstyles/http_server_rust [INFO] finished frobbing cstyles/http_server_rust [INFO] frobbed toml for cstyles/http_server_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cstyles/http_server_rust/Cargo.toml [INFO] crate cstyles/http_server_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cstyles/http_server_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cstyles/http_server_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5bd33e0e276937ceff409d3c7ac826fcb2fe0b966ecc3a8834e9768cda56e9e8 [INFO] running `"docker" "start" "-a" "5bd33e0e276937ceff409d3c7ac826fcb2fe0b966ecc3a8834e9768cda56e9e8"` [INFO] [stderr] Compiling autocfg v0.1.1 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Compiling backtrace v0.3.13 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Compiling pest_generator v2.0.0 [INFO] [stderr] Checking hyper v0.12.18 [INFO] [stderr] Compiling pest_derive v2.0.1 [INFO] [stderr] Checking tera v0.11.20 [INFO] [stderr] Checking http_server_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / return Err(Response::builder() [INFO] [stderr] 125 | | .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stderr] 126 | | .body(Body::from(error)) [INFO] [stderr] 127 | | .unwrap()) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 124 | Err(Response::builder() [INFO] [stderr] 125 | .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stderr] 126 | .body(Body::from(error)) [INFO] [stderr] 127 | .unwrap()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / return Err(Response::builder() [INFO] [stderr] 125 | | .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stderr] 126 | | .body(Body::from(error)) [INFO] [stderr] 127 | | .unwrap()) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 124 | Err(Response::builder() [INFO] [stderr] 125 | .status(StatusCode::INTERNAL_SERVER_ERROR) [INFO] [stderr] 126 | .body(Body::from(error)) [INFO] [stderr] 127 | .unwrap()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:82:31 [INFO] [stderr] | [INFO] [stderr] 82 | if uri_path.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:82:31 [INFO] [stderr] | [INFO] [stderr] 82 | if uri_path.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 39.04s [INFO] running `"docker" "inspect" "5bd33e0e276937ceff409d3c7ac826fcb2fe0b966ecc3a8834e9768cda56e9e8"` [INFO] running `"docker" "rm" "-f" "5bd33e0e276937ceff409d3c7ac826fcb2fe0b966ecc3a8834e9768cda56e9e8"` [INFO] [stdout] 5bd33e0e276937ceff409d3c7ac826fcb2fe0b966ecc3a8834e9768cda56e9e8