[INFO] updating cached repository cstorey/gll-experiments [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cstorey/gll-experiments [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cstorey/gll-experiments" "work/ex/clippy-test-run/sources/stable/gh/cstorey/gll-experiments"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cstorey/gll-experiments'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cstorey/gll-experiments" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cstorey/gll-experiments"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cstorey/gll-experiments'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 31e529f404d371a044cef55fdd449c6989a52c18 [INFO] sha for GitHub repo cstorey/gll-experiments: 31e529f404d371a044cef55fdd449c6989a52c18 [INFO] validating manifest of cstorey/gll-experiments on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cstorey/gll-experiments on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cstorey/gll-experiments [INFO] finished frobbing cstorey/gll-experiments [INFO] frobbed toml for cstorey/gll-experiments written to work/ex/clippy-test-run/sources/stable/gh/cstorey/gll-experiments/Cargo.toml [INFO] started frobbing cstorey/gll-experiments [INFO] finished frobbing cstorey/gll-experiments [INFO] frobbed toml for cstorey/gll-experiments written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cstorey/gll-experiments/Cargo.toml [INFO] crate cstorey/gll-experiments has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cstorey/gll-experiments against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cstorey/gll-experiments:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1a878968b395ed7d5066856ba4eea57435c6b96bbaf5100c72e81086a9a87da2 [INFO] running `"docker" "start" "-a" "1a878968b395ed7d5066856ba4eea57435c6b96bbaf5100c72e81086a9a87da2"` [INFO] [stderr] Checking gll-examples v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | let mut fromv = self.gss.entry(v).or_insert_with(BTreeSet::new); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Stack` [INFO] [stderr] --> src/main.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | type Stack = VecDeque; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &Extlbl::Positioned(_, lbl) => lbl, [INFO] [stderr] 37 | | _ => panic!("... eh"), [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | Extlbl::Positioned(_, lbl) => lbl, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:123:61 [INFO] [stderr] | [INFO] [stderr] 123 | self.r.push_back(Descriptor(Label::LS1, self.u.clone(), self.idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.u` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:126:61 [INFO] [stderr] | [INFO] [stderr] 126 | self.r.push_back(Descriptor(Label::LS2, self.u.clone(), self.idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.u` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:129:61 [INFO] [stderr] | [INFO] [stderr] 129 | self.r.push_back(Descriptor(Label::LS3, self.u.clone(), self.idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.u` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | let mut fromv = self.gss.entry(v).or_insert_with(BTreeSet::new); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Stack` [INFO] [stderr] --> src/main.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | type Stack = VecDeque; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &Extlbl::Positioned(_, lbl) => lbl, [INFO] [stderr] 37 | | _ => panic!("... eh"), [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | Extlbl::Positioned(_, lbl) => lbl, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:123:61 [INFO] [stderr] | [INFO] [stderr] 123 | self.r.push_back(Descriptor(Label::LS1, self.u.clone(), self.idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.u` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:126:61 [INFO] [stderr] | [INFO] [stderr] 126 | self.r.push_back(Descriptor(Label::LS2, self.u.clone(), self.idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.u` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:129:61 [INFO] [stderr] | [INFO] [stderr] 129 | self.r.push_back(Descriptor(Label::LS3, self.u.clone(), self.idx)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.u` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.34s [INFO] running `"docker" "inspect" "1a878968b395ed7d5066856ba4eea57435c6b96bbaf5100c72e81086a9a87da2"` [INFO] running `"docker" "rm" "-f" "1a878968b395ed7d5066856ba4eea57435c6b96bbaf5100c72e81086a9a87da2"` [INFO] [stdout] 1a878968b395ed7d5066856ba4eea57435c6b96bbaf5100c72e81086a9a87da2