[INFO] updating cached repository csreid/chess-engine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/csreid/chess-engine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/csreid/chess-engine" "work/ex/clippy-test-run/sources/stable/gh/csreid/chess-engine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/csreid/chess-engine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/csreid/chess-engine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csreid/chess-engine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csreid/chess-engine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d026bd5a88da27b9e6a6d631a54d585ddafa7b92 [INFO] sha for GitHub repo csreid/chess-engine: d026bd5a88da27b9e6a6d631a54d585ddafa7b92 [INFO] validating manifest of csreid/chess-engine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of csreid/chess-engine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing csreid/chess-engine [INFO] finished frobbing csreid/chess-engine [INFO] frobbed toml for csreid/chess-engine written to work/ex/clippy-test-run/sources/stable/gh/csreid/chess-engine/Cargo.toml [INFO] started frobbing csreid/chess-engine [INFO] finished frobbing csreid/chess-engine [INFO] frobbed toml for csreid/chess-engine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csreid/chess-engine/Cargo.toml [INFO] crate csreid/chess-engine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting csreid/chess-engine against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/csreid/chess-engine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 813200e7fd3a62c19e4d8463160d0cf961880e243393c09f34a626b3c541c108 [INFO] running `"docker" "start" "-a" "813200e7fd3a62c19e4d8463160d0cf961880e243393c09f34a626b3c541c108"` [INFO] [stderr] Compiling chess v2.0.1 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking stopwatch v0.0.7 [INFO] [stderr] Checking chess-engine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:64:3 [INFO] [stderr] | [INFO] [stderr] 64 | board: board, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `board` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:64:3 [INFO] [stderr] | [INFO] [stderr] 64 | board: board, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `board` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ALL_FILES`, `ALL_RANKS`, `Piece`, `Square` [INFO] [stderr] --> src/main.rs:9:2 [INFO] [stderr] | [INFO] [stderr] 9 | ALL_FILES, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] 10 | ALL_RANKS, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 16 | Piece, [INFO] [stderr] | ^^^^^ [INFO] [stderr] 17 | Square, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `rand::*` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use rand::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `finished_count` [INFO] [stderr] --> src/main.rs:86:10 [INFO] [stderr] | [INFO] [stderr] 86 | let mut finished_count = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_finished_count` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `total_count` [INFO] [stderr] --> src/main.rs:87:10 [INFO] [stderr] | [INFO] [stderr] 87 | let mut total_count = 0; [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_total_count` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rng` [INFO] [stderr] --> src/main.rs:91:10 [INFO] [stderr] | [INFO] [stderr] 91 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ^^^ help: consider using `_rng` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `iter2` [INFO] [stderr] --> src/main.rs:93:10 [INFO] [stderr] | [INFO] [stderr] 93 | let mut iter2 = MoveGen::new_legal(&board); [INFO] [stderr] | ^^^^^ help: consider using `_iter2` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/main.rs:94:10 [INFO] [stderr] | [INFO] [stderr] 94 | let mut count = 0; [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:86:6 [INFO] [stderr] | [INFO] [stderr] 86 | let mut finished_count = 0; [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:87:6 [INFO] [stderr] | [INFO] [stderr] 87 | let mut total_count = 0; [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:90:6 [INFO] [stderr] | [INFO] [stderr] 90 | let mut board = Board::from_fen(fen.to_string()).unwrap(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:91:6 [INFO] [stderr] | [INFO] [stderr] 91 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:93:6 [INFO] [stderr] | [INFO] [stderr] 93 | let mut iter2 = MoveGen::new_legal(&board); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:94:6 [INFO] [stderr] | [INFO] [stderr] 94 | let mut count = 0; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:42:18 [INFO] [stderr] | [INFO] [stderr] 42 | let mut board = b.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:88:31 [INFO] [stderr] | [INFO] [stderr] 88 | let fen = env::args().nth(1).unwrap_or("rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:6 [INFO] [stderr] | [INFO] [stderr] 119 | if (results as f64) > (best) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(results)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:120:11 [INFO] [stderr] | [INFO] [stderr] 120 | best = results as f64 / N as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(results)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | best = results as f64 / N as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(N)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:127:37 [INFO] [stderr] | [INFO] [stderr] 127 | println!("({}/ms)", (cpus as f64 * N as f64)/(sw.elapsed_ms() as f64)); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(N)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ALL_FILES`, `ALL_RANKS`, `Piece`, `Square` [INFO] [stderr] --> src/main.rs:9:2 [INFO] [stderr] | [INFO] [stderr] 9 | ALL_FILES, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] 10 | ALL_RANKS, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 16 | Piece, [INFO] [stderr] | ^^^^^ [INFO] [stderr] 17 | Square, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `rand::*` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use rand::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `finished_count` [INFO] [stderr] --> src/main.rs:86:10 [INFO] [stderr] | [INFO] [stderr] 86 | let mut finished_count = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_finished_count` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `total_count` [INFO] [stderr] --> src/main.rs:87:10 [INFO] [stderr] | [INFO] [stderr] 87 | let mut total_count = 0; [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_total_count` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rng` [INFO] [stderr] --> src/main.rs:91:10 [INFO] [stderr] | [INFO] [stderr] 91 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ^^^ help: consider using `_rng` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `iter2` [INFO] [stderr] --> src/main.rs:93:10 [INFO] [stderr] | [INFO] [stderr] 93 | let mut iter2 = MoveGen::new_legal(&board); [INFO] [stderr] | ^^^^^ help: consider using `_iter2` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/main.rs:94:10 [INFO] [stderr] | [INFO] [stderr] 94 | let mut count = 0; [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:86:6 [INFO] [stderr] | [INFO] [stderr] 86 | let mut finished_count = 0; [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:87:6 [INFO] [stderr] | [INFO] [stderr] 87 | let mut total_count = 0; [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:90:6 [INFO] [stderr] | [INFO] [stderr] 90 | let mut board = Board::from_fen(fen.to_string()).unwrap(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:91:6 [INFO] [stderr] | [INFO] [stderr] 91 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:93:6 [INFO] [stderr] | [INFO] [stderr] 93 | let mut iter2 = MoveGen::new_legal(&board); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:94:6 [INFO] [stderr] | [INFO] [stderr] 94 | let mut count = 0; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:42:18 [INFO] [stderr] | [INFO] [stderr] 42 | let mut board = b.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:88:31 [INFO] [stderr] | [INFO] [stderr] 88 | let fen = env::args().nth(1).unwrap_or("rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:119:6 [INFO] [stderr] | [INFO] [stderr] 119 | if (results as f64) > (best) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(results)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:120:11 [INFO] [stderr] | [INFO] [stderr] 120 | best = results as f64 / N as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(results)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:120:28 [INFO] [stderr] | [INFO] [stderr] 120 | best = results as f64 / N as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(N)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:127:37 [INFO] [stderr] | [INFO] [stderr] 127 | println!("({}/ms)", (cpus as f64 * N as f64)/(sw.elapsed_ms() as f64)); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(N)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4m 22s [INFO] running `"docker" "inspect" "813200e7fd3a62c19e4d8463160d0cf961880e243393c09f34a626b3c541c108"` [INFO] running `"docker" "rm" "-f" "813200e7fd3a62c19e4d8463160d0cf961880e243393c09f34a626b3c541c108"` [INFO] [stdout] 813200e7fd3a62c19e4d8463160d0cf961880e243393c09f34a626b3c541c108