[INFO] updating cached repository csreid/AoC2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/csreid/AoC2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/csreid/AoC2018" "work/ex/clippy-test-run/sources/stable/gh/csreid/AoC2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/csreid/AoC2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/csreid/AoC2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csreid/AoC2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csreid/AoC2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9415bfa42c09babaeca2e121acf7eef91bd6b7fb [INFO] sha for GitHub repo csreid/AoC2018: 9415bfa42c09babaeca2e121acf7eef91bd6b7fb [INFO] validating manifest of csreid/AoC2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of csreid/AoC2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing csreid/AoC2018 [INFO] finished frobbing csreid/AoC2018 [INFO] frobbed toml for csreid/AoC2018 written to work/ex/clippy-test-run/sources/stable/gh/csreid/AoC2018/Cargo.toml [INFO] started frobbing csreid/AoC2018 [INFO] finished frobbing csreid/AoC2018 [INFO] frobbed toml for csreid/AoC2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csreid/AoC2018/Cargo.toml [INFO] crate csreid/AoC2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting csreid/AoC2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/csreid/AoC2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5d0814b60cddd88660c5d0cb9281689c3024c0d374db4dd77431e3d729702484 [INFO] running `"docker" "start" "-a" "5d0814b60cddd88660c5d0cb9281689c3024c0d374db4dd77431e3d729702484"` [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Checking fine_grained v0.1.2 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking AoC v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `itertools::Itertools` [INFO] [stderr] --> src/day2/mod.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use itertools::Itertools; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashSet` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use std::collections::HashSet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::convert::From` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::convert::From; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Change` [INFO] [stderr] --> src/main.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | use day1::{Change,ChangeRecord,ChangeList}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `itertools::Itertools` [INFO] [stderr] --> src/day2/mod.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use itertools::Itertools; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashSet` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use std::collections::HashSet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::convert::From` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::convert::From; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Change` [INFO] [stderr] --> src/main.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | use day1::{Change,ChangeRecord,ChangeList}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `l` [INFO] [stderr] --> src/main.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | .filter(|(l, r, v)| { [INFO] [stderr] | ^ help: consider using `_l` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/main.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | .filter(|(l, r, v)| { [INFO] [stderr] | ^ help: consider using `_r` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/day2/mod.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | .filter(|(idx, (l, r))| { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `l` [INFO] [stderr] --> src/main.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | .filter(|(l, r, v)| { [INFO] [stderr] | ^ help: consider using `_l` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/main.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | .filter(|(l, r, v)| { [INFO] [stderr] | ^ help: consider using `_r` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `idx` [INFO] [stderr] --> src/day2/mod.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | .filter(|(idx, (l, r))| { [INFO] [stderr] | ^^^ help: consider using `_idx` instead [INFO] [stderr] [INFO] [stderr] warning: crate `AoC` should have a snake case name such as `ao_c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/day2/mod.rs:28:3 [INFO] [stderr] | [INFO] [stderr] 28 | chars [INFO] [stderr] | _________^ [INFO] [stderr] 29 | | .values() [INFO] [stderr] 30 | | .filter(|x| **x == n) [INFO] [stderr] 31 | | .collect::>() [INFO] [stderr] 32 | | .len() > 0 [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] help: using `is_empty` is clearer and more explicit [INFO] [stderr] | [INFO] [stderr] 28 | !chars [INFO] [stderr] 29 | .values() [INFO] [stderr] 30 | .filter(|x| **x == n) [INFO] [stderr] 31 | .collect::>().is_empty() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/day2/mod.rs:31:4 [INFO] [stderr] | [INFO] [stderr] 31 | .collect::>() [INFO] [stderr] | _____________^ [INFO] [stderr] 32 | | .len() > 0 [INFO] [stderr] | |__________________^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/day2/mod.rs:71:3 [INFO] [stderr] | [INFO] [stderr] 71 | write!(f, "{} -> {} as position {}", self.left, self.right, self.position); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: crate `AoC` should have a snake case name such as `ao_c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/day2/mod.rs:28:3 [INFO] [stderr] | [INFO] [stderr] 28 | chars [INFO] [stderr] | _________^ [INFO] [stderr] 29 | | .values() [INFO] [stderr] 30 | | .filter(|x| **x == n) [INFO] [stderr] 31 | | .collect::>() [INFO] [stderr] 32 | | .len() > 0 [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] help: using `is_empty` is clearer and more explicit [INFO] [stderr] | [INFO] [stderr] 28 | !chars [INFO] [stderr] 29 | .values() [INFO] [stderr] 30 | .filter(|x| **x == n) [INFO] [stderr] 31 | .collect::>().is_empty() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/day2/mod.rs:31:4 [INFO] [stderr] | [INFO] [stderr] 31 | .collect::>() [INFO] [stderr] | _____________^ [INFO] [stderr] 32 | | .len() > 0 [INFO] [stderr] | |__________________^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/day2/mod.rs:71:3 [INFO] [stderr] | [INFO] [stderr] 71 | write!(f, "{} -> {} as position {}", self.left, self.right, self.position); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.74s [INFO] running `"docker" "inspect" "5d0814b60cddd88660c5d0cb9281689c3024c0d374db4dd77431e3d729702484"` [INFO] running `"docker" "rm" "-f" "5d0814b60cddd88660c5d0cb9281689c3024c0d374db4dd77431e3d729702484"` [INFO] [stdout] 5d0814b60cddd88660c5d0cb9281689c3024c0d374db4dd77431e3d729702484