[INFO] updating cached repository csharad/workie [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/csharad/workie [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/csharad/workie" "work/ex/clippy-test-run/sources/stable/gh/csharad/workie"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/csharad/workie'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/csharad/workie" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csharad/workie"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csharad/workie'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e0ed754c34b0d5cb15b68f94bf9ca337c93bee31 [INFO] sha for GitHub repo csharad/workie: e0ed754c34b0d5cb15b68f94bf9ca337c93bee31 [INFO] validating manifest of csharad/workie on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of csharad/workie on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing csharad/workie [INFO] finished frobbing csharad/workie [INFO] frobbed toml for csharad/workie written to work/ex/clippy-test-run/sources/stable/gh/csharad/workie/Cargo.toml [INFO] started frobbing csharad/workie [INFO] finished frobbing csharad/workie [INFO] frobbed toml for csharad/workie written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csharad/workie/Cargo.toml [INFO] crate csharad/workie has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting csharad/workie against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/csharad/workie:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7588d23f1593f4536a7a09f5980691d58a503c31b4d3f05a60d6343e753ed4a2 [INFO] running `"docker" "start" "-a" "7588d23f1593f4536a7a09f5980691d58a503c31b4d3f05a60d6343e753ed4a2"` [INFO] [stderr] Compiling if_chain v0.1.3 [INFO] [stderr] Checking r2d2 v0.8.3 [INFO] [stderr] Compiling url v1.7.2 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking tokio-threadpool v0.1.8 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking bcrypt v0.2.1 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking tokio-signal v0.2.6 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling actix_derive v0.3.2 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Compiling serde v1.0.80 [INFO] [stderr] Checking trust-dns-resolver v0.10.0 [INFO] [stderr] Checking actix v0.7.6 [INFO] [stderr] Checking actix-net v0.1.1 [INFO] [stderr] Compiling serde_json v1.0.33 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Checking diesel v1.3.3 [INFO] [stderr] Checking validator v0.8.0 [INFO] [stderr] Checking actix-web v0.7.13 [INFO] [stderr] Compiling validator_derive v0.8.0 [INFO] [stderr] Checking workie-backend v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/model/task.rs:70:19 [INFO] [stderr] | [INFO] [stderr] 70 | completed_on: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/model/user.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | full_name: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/result.rs:83:31 [INFO] [stderr] | [INFO] [stderr] 83 | fn build_database_error(kind: &DatabaseErrorKind) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `DatabaseErrorKind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/model/task.rs:70:19 [INFO] [stderr] | [INFO] [stderr] 70 | completed_on: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/model/user.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | full_name: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/result.rs:83:31 [INFO] [stderr] | [INFO] [stderr] 83 | fn build_database_error(kind: &DatabaseErrorKind) -> HttpResponse { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `DatabaseErrorKind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 27s [INFO] running `"docker" "inspect" "7588d23f1593f4536a7a09f5980691d58a503c31b4d3f05a60d6343e753ed4a2"` [INFO] running `"docker" "rm" "-f" "7588d23f1593f4536a7a09f5980691d58a503c31b4d3f05a60d6343e753ed4a2"` [INFO] [stdout] 7588d23f1593f4536a7a09f5980691d58a503c31b4d3f05a60d6343e753ed4a2