[INFO] updating cached repository csharad/paryxa [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/csharad/paryxa [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/csharad/paryxa" "work/ex/clippy-test-run/sources/stable/gh/csharad/paryxa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/csharad/paryxa'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/csharad/paryxa" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csharad/paryxa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csharad/paryxa'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2f1b3fd933af34909efc503f834ecd5076db11c8 [INFO] sha for GitHub repo csharad/paryxa: 2f1b3fd933af34909efc503f834ecd5076db11c8 [INFO] validating manifest of csharad/paryxa on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of csharad/paryxa on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing csharad/paryxa [INFO] finished frobbing csharad/paryxa [INFO] frobbed toml for csharad/paryxa written to work/ex/clippy-test-run/sources/stable/gh/csharad/paryxa/Cargo.toml [INFO] started frobbing csharad/paryxa [INFO] finished frobbing csharad/paryxa [INFO] frobbed toml for csharad/paryxa written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/csharad/paryxa/Cargo.toml [INFO] crate csharad/paryxa has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting csharad/paryxa against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/csharad/paryxa:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 84459a3de83b6b0aa1e67735d9571db309a449007345fda1283fc7b68141439a [INFO] running `"docker" "start" "-a" "84459a3de83b6b0aa1e67735d9571db309a449007345fda1283fc7b68141439a"` [INFO] [stderr] Checking urlencoding v1.0.0 [INFO] [stderr] Checking ttl_cache v0.4.2 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking r2d2 v0.8.2 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking input_buffer v0.2.0 [INFO] [stderr] Checking indexmap v1.0.2 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Compiling aho-corasick v0.6.8 [INFO] [stderr] Checking headers-core v0.0.1 [INFO] [stderr] Checking block-cipher-trait v0.5.3 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking sha-1 v0.7.0 [INFO] [stderr] Compiling headers-derive v0.0.1 [INFO] [stderr] Checking blowfish v0.3.0 [INFO] [stderr] Checking tokio-threadpool v0.1.8 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking diesel v1.3.3 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Compiling regex v1.0.5 [INFO] [stderr] Checking tungstenite v0.6.0 [INFO] [stderr] Checking bcrypt v0.2.1 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking headers-ext v0.0.3 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking hyper v0.12.12 [INFO] [stderr] Compiling juniper_codegen v0.10.0 [INFO] [stderr] Checking juniper v0.10.0 [INFO] [stderr] Checking warp v0.1.7 [INFO] [stderr] Checking juniper_warp v0.1.0 [INFO] [stderr] Checking paryxa-server v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: field is never used: `test_attempt_id` [INFO] [stderr] --> src/models/question_answer.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | test_attempt_id: i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `user_id` [INFO] [stderr] --> src/models/test_subscription.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | user_id: i32, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/basic.rs:19:14 [INFO] [stderr] | [INFO] [stderr] 19 | .map(|user| Some(user)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/basic.rs:39:31 [INFO] [stderr] | [INFO] [stderr] 39 | let parts = decoded.split(":").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/question_option.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | is_correct: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/question_option.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | is_correct: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/test_paper.rs:150:18 [INFO] [stderr] | [INFO] [stderr] 150 | description: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/test_paper.rs:219:18 [INFO] [stderr] | [INFO] [stderr] 219 | description: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: field is never used: `test_attempt_id` [INFO] [stderr] --> src/models/question_answer.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | test_attempt_id: i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `user_id` [INFO] [stderr] --> src/models/test_subscription.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | user_id: i32, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/basic.rs:19:14 [INFO] [stderr] | [INFO] [stderr] 19 | .map(|user| Some(user)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/basic.rs:39:31 [INFO] [stderr] | [INFO] [stderr] 39 | let parts = decoded.split(":").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/models/test_schedule.rs:68:58 [INFO] [stderr] | [INFO] [stderr] 68 | self.time < now && self.time + Duration::seconds(self.duration as i64) > now [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.duration)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/question_option.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | is_correct: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/question_option.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | is_correct: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/user.rs:258:17 [INFO] [stderr] | [INFO] [stderr] 258 | first_name: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/user.rs:259:16 [INFO] [stderr] | [INFO] [stderr] 259 | last_name: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/user.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | gender: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/user.rs:263:14 [INFO] [stderr] | [INFO] [stderr] 263 | contact: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/test_paper.rs:150:18 [INFO] [stderr] | [INFO] [stderr] 150 | description: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/mod.rs:13:45 [INFO] [stderr] | [INFO] [stderr] 13 | fn join(self, is_null: Option) -> Option>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/test_paper.rs:219:18 [INFO] [stderr] | [INFO] [stderr] 219 | description: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/models/test_schedule.rs:68:58 [INFO] [stderr] | [INFO] [stderr] 68 | self.time < now && self.time + Duration::seconds(self.duration as i64) > now [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.duration)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/user.rs:258:17 [INFO] [stderr] | [INFO] [stderr] 258 | first_name: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/user.rs:259:16 [INFO] [stderr] | [INFO] [stderr] 259 | last_name: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/user.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | gender: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/user.rs:263:14 [INFO] [stderr] | [INFO] [stderr] 263 | contact: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/models/mod.rs:13:45 [INFO] [stderr] | [INFO] [stderr] 13 | fn join(self, is_null: Option) -> Option>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 46s [INFO] running `"docker" "inspect" "84459a3de83b6b0aa1e67735d9571db309a449007345fda1283fc7b68141439a"` [INFO] running `"docker" "rm" "-f" "84459a3de83b6b0aa1e67735d9571db309a449007345fda1283fc7b68141439a"` [INFO] [stdout] 84459a3de83b6b0aa1e67735d9571db309a449007345fda1283fc7b68141439a