[INFO] updating cached repository crumblingstatue/noten [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/crumblingstatue/noten [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/crumblingstatue/noten" "work/ex/clippy-test-run/sources/stable/gh/crumblingstatue/noten"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/crumblingstatue/noten'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/crumblingstatue/noten" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crumblingstatue/noten"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crumblingstatue/noten'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a7fa60fc77eaf8894911a87f05e4e68a380eeaaf [INFO] sha for GitHub repo crumblingstatue/noten: a7fa60fc77eaf8894911a87f05e4e68a380eeaaf [INFO] validating manifest of crumblingstatue/noten on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of crumblingstatue/noten on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing crumblingstatue/noten [INFO] finished frobbing crumblingstatue/noten [INFO] frobbed toml for crumblingstatue/noten written to work/ex/clippy-test-run/sources/stable/gh/crumblingstatue/noten/Cargo.toml [INFO] started frobbing crumblingstatue/noten [INFO] finished frobbing crumblingstatue/noten [INFO] frobbed toml for crumblingstatue/noten written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/crumblingstatue/noten/Cargo.toml [INFO] crate crumblingstatue/noten has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting crumblingstatue/noten against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/crumblingstatue/noten:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d98794bb918b9c5c3a2fa4d94feb336cab5d795eb7a4fb995b374a2248963b9b [INFO] running `"docker" "start" "-a" "d98794bb918b9c5c3a2fa4d94feb336cab5d795eb7a4fb995b374a2248963b9b"` [INFO] [stderr] Compiling hoedown v6.0.0 [INFO] [stderr] Checking toml v0.4.1 [INFO] [stderr] Checking env_logger v0.4.2 [INFO] [stderr] Checking noten v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/template_deps.rs:38:27 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(TemplateDeps { hash_map: hash_map }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skeleton.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | Skeleton { segments: segments }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/template_deps.rs:38:27 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(TemplateDeps { hash_map: hash_map }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/skeleton.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | Skeleton { segments: segments }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | pub const FILENAME: &'static str = "noten.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/template_deps.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | pub const PATH: &'static str = ".noten/template-deps.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | pub const FILENAME: &'static str = "noten.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/template_deps.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | pub const PATH: &'static str = ".noten/template-deps.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/substitution.rs:47:26 [INFO] [stderr] | [INFO] [stderr] 47 | Some(err) => Err(err.into()), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/substitution.rs:115:10 [INFO] [stderr] | [INFO] [stderr] 115 | .expect(&format!("Failed to spawn {}", gen_name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to spawn {}", gen_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/substitution.rs:47:26 [INFO] [stderr] | [INFO] [stderr] 47 | Some(err) => Err(err.into()), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/substitution.rs:115:10 [INFO] [stderr] | [INFO] [stderr] 115 | .expect(&format!("Failed to spawn {}", gen_name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to spawn {}", gen_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.03s [INFO] running `"docker" "inspect" "d98794bb918b9c5c3a2fa4d94feb336cab5d795eb7a4fb995b374a2248963b9b"` [INFO] running `"docker" "rm" "-f" "d98794bb918b9c5c3a2fa4d94feb336cab5d795eb7a4fb995b374a2248963b9b"` [INFO] [stdout] d98794bb918b9c5c3a2fa4d94feb336cab5d795eb7a4fb995b374a2248963b9b