[INFO] updating cached repository cruessler/git-tree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cruessler/git-tree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cruessler/git-tree" "work/ex/clippy-test-run/sources/stable/gh/cruessler/git-tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cruessler/git-tree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cruessler/git-tree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cruessler/git-tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cruessler/git-tree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1f4c729332f170ed93abbf61d741f9f49f2db48b [INFO] sha for GitHub repo cruessler/git-tree: 1f4c729332f170ed93abbf61d741f9f49f2db48b [INFO] validating manifest of cruessler/git-tree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cruessler/git-tree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cruessler/git-tree [INFO] finished frobbing cruessler/git-tree [INFO] frobbed toml for cruessler/git-tree written to work/ex/clippy-test-run/sources/stable/gh/cruessler/git-tree/Cargo.toml [INFO] started frobbing cruessler/git-tree [INFO] finished frobbing cruessler/git-tree [INFO] frobbed toml for cruessler/git-tree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cruessler/git-tree/Cargo.toml [INFO] crate cruessler/git-tree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cruessler/git-tree against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cruessler/git-tree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4df03e3b6c49d72699eed8f3449cc4bec86049905ed0da6f98d3606fc88e7b0f [INFO] running `"docker" "start" "-a" "4df03e3b6c49d72699eed8f3449cc4bec86049905ed0da6f98d3606fc88e7b0f"` [INFO] [stderr] Checking ansi_term v0.10.1 [INFO] [stderr] Compiling cmake v0.1.25 [INFO] [stderr] Checking textwrap v0.8.0 [INFO] [stderr] Checking backtrace-sys v0.1.16 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking clap v2.26.2 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling libgit2-sys v0.6.14 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking git2 v0.6.8 [INFO] [stderr] Checking git-tree v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | write!(f, "{}\n", l.as_os_str().to_string_lossy())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | stats: stats, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | write!(f, "{}\n", l.as_os_str().to_string_lossy())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | stats: stats, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | .ok_or(failure::err_msg("HEAD is not a direct reference"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| failure::err_msg("HEAD is not a direct reference"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | dir.to_str().map(|dir| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 87 | || let new_node = self.children.entry(dir.into()).or_insert(Node::Tree(Tree { [INFO] [stderr] 88 | || name: dir.into(), [INFO] [stderr] 89 | || children: BTreeMap::new(), [INFO] [stderr] ... || [INFO] [stderr] 94 | || } [INFO] [stderr] 95 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(dir) = dir.to_str() { ... }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:87:68 [INFO] [stderr] | [INFO] [stderr] 87 | let new_node = self.children.entry(dir.into()).or_insert(Node::Tree(Tree { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 88 | | name: dir.into(), [INFO] [stderr] 89 | | children: BTreeMap::new(), [INFO] [stderr] 90 | | })); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | let new_node = self.children.entry(dir.into()).or_insert_with(|| Node::Tree(Tree { [INFO] [stderr] 88 | name: dir.into(), [INFO] [stderr] 89 | children: BTreeMap::new(), [INFO] [stderr] 90 | })); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:92:21 [INFO] [stderr] | [INFO] [stderr] 92 | / if let &mut Node::Tree(ref mut new_node) = new_node { [INFO] [stderr] 93 | | new_node.add_node_at_path(node, name, path) [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 92 | if let Node::Tree(ref mut new_node) = *new_node { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / match self { [INFO] [stderr] 147 | | &Node::Tree(ref node) => node.lines(), [INFO] [stderr] 148 | | &Node::Summary(ref node) => node.lines(), [INFO] [stderr] 149 | | &Node::Leaf(ref node) => node.lines(), [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 146 | match *self { [INFO] [stderr] 147 | Node::Tree(ref node) => node.lines(), [INFO] [stderr] 148 | Node::Summary(ref node) => node.lines(), [INFO] [stderr] 149 | Node::Leaf(ref node) => node.lines(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:280:47 [INFO] [stderr] | [INFO] [stderr] 280 | let path = Path::new(entry.path().ok_or(failure::err_msg(format!( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 281 | | "{:?} cannot be resolved to a path", [INFO] [stderr] 282 | | entry.path() [INFO] [stderr] 283 | | )))?); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 280 | let path = Path::new(entry.path().ok_or_else(|| failure::err_msg(format!( [INFO] [stderr] 281 | "{:?} cannot be resolved to a path", [INFO] [stderr] 282 | entry.path() [INFO] [stderr] 283 | )))?); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | / entry [INFO] [stderr] 293 | | .path() [INFO] [stderr] 294 | | .and_then(|path| Path::new(path).parent()) [INFO] [stderr] 295 | | .map(|parent| { [INFO] [stderr] 296 | | root.add_leaf_at_path(leaf, &mut parent.components()); [INFO] [stderr] 297 | | }); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 292 | if let Some(parent) = entry [INFO] [stderr] 293 | .path() [INFO] [stderr] 294 | .and_then(|path| Path::new(path).parent()) { root.add_leaf_at_path(leaf, &mut parent.components()); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | .ok_or(failure::err_msg("HEAD is not a direct reference"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| failure::err_msg("HEAD is not a direct reference"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | dir.to_str().map(|dir| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 87 | || let new_node = self.children.entry(dir.into()).or_insert(Node::Tree(Tree { [INFO] [stderr] 88 | || name: dir.into(), [INFO] [stderr] 89 | || children: BTreeMap::new(), [INFO] [stderr] ... || [INFO] [stderr] 94 | || } [INFO] [stderr] 95 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(dir) = dir.to_str() { ... }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:87:68 [INFO] [stderr] | [INFO] [stderr] 87 | let new_node = self.children.entry(dir.into()).or_insert(Node::Tree(Tree { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 88 | | name: dir.into(), [INFO] [stderr] 89 | | children: BTreeMap::new(), [INFO] [stderr] 90 | | })); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | let new_node = self.children.entry(dir.into()).or_insert_with(|| Node::Tree(Tree { [INFO] [stderr] 88 | name: dir.into(), [INFO] [stderr] 89 | children: BTreeMap::new(), [INFO] [stderr] 90 | })); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:92:21 [INFO] [stderr] | [INFO] [stderr] 92 | / if let &mut Node::Tree(ref mut new_node) = new_node { [INFO] [stderr] 93 | | new_node.add_node_at_path(node, name, path) [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 92 | if let Node::Tree(ref mut new_node) = *new_node { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / match self { [INFO] [stderr] 147 | | &Node::Tree(ref node) => node.lines(), [INFO] [stderr] 148 | | &Node::Summary(ref node) => node.lines(), [INFO] [stderr] 149 | | &Node::Leaf(ref node) => node.lines(), [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 146 | match *self { [INFO] [stderr] 147 | Node::Tree(ref node) => node.lines(), [INFO] [stderr] 148 | Node::Summary(ref node) => node.lines(), [INFO] [stderr] 149 | Node::Leaf(ref node) => node.lines(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:372:14 [INFO] [stderr] | [INFO] [stderr] 372 | node.map(|node| Some(node)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:280:47 [INFO] [stderr] | [INFO] [stderr] 280 | let path = Path::new(entry.path().ok_or(failure::err_msg(format!( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 281 | | "{:?} cannot be resolved to a path", [INFO] [stderr] 282 | | entry.path() [INFO] [stderr] 283 | | )))?); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 280 | let path = Path::new(entry.path().ok_or_else(|| failure::err_msg(format!( [INFO] [stderr] 281 | "{:?} cannot be resolved to a path", [INFO] [stderr] 282 | entry.path() [INFO] [stderr] 283 | )))?); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | / entry [INFO] [stderr] 293 | | .path() [INFO] [stderr] 294 | | .and_then(|path| Path::new(path).parent()) [INFO] [stderr] 295 | | .map(|parent| { [INFO] [stderr] 296 | | root.add_leaf_at_path(leaf, &mut parent.components()); [INFO] [stderr] 297 | | }); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 292 | if let Some(parent) = entry [INFO] [stderr] 293 | .path() [INFO] [stderr] 294 | .and_then(|path| Path::new(path).parent()) { root.add_leaf_at_path(leaf, &mut parent.components()); } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:372:14 [INFO] [stderr] | [INFO] [stderr] 372 | node.map(|node| Some(node)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 46.64s [INFO] running `"docker" "inspect" "4df03e3b6c49d72699eed8f3449cc4bec86049905ed0da6f98d3606fc88e7b0f"` [INFO] running `"docker" "rm" "-f" "4df03e3b6c49d72699eed8f3449cc4bec86049905ed0da6f98d3606fc88e7b0f"` [INFO] [stdout] 4df03e3b6c49d72699eed8f3449cc4bec86049905ed0da6f98d3606fc88e7b0f