[INFO] updating cached repository cristianoliveira/funzzy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cristianoliveira/funzzy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cristianoliveira/funzzy" "work/ex/clippy-test-run/sources/stable/gh/cristianoliveira/funzzy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cristianoliveira/funzzy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cristianoliveira/funzzy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cristianoliveira/funzzy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cristianoliveira/funzzy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9c4ae0c0a33686527acafd8cf2da6e0868d88aeb [INFO] sha for GitHub repo cristianoliveira/funzzy: 9c4ae0c0a33686527acafd8cf2da6e0868d88aeb [INFO] validating manifest of cristianoliveira/funzzy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cristianoliveira/funzzy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cristianoliveira/funzzy [INFO] finished frobbing cristianoliveira/funzzy [INFO] frobbed toml for cristianoliveira/funzzy written to work/ex/clippy-test-run/sources/stable/gh/cristianoliveira/funzzy/Cargo.toml [INFO] started frobbing cristianoliveira/funzzy [INFO] finished frobbing cristianoliveira/funzzy [INFO] frobbed toml for cristianoliveira/funzzy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cristianoliveira/funzzy/Cargo.toml [INFO] crate cristianoliveira/funzzy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cristianoliveira/funzzy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cristianoliveira/funzzy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 676453a851d7579c262501d635f27fe8c004b657f0dcec40bd8ad6af83295c20 [INFO] running `"docker" "start" "-a" "676453a851d7579c262501d635f27fe8c004b657f0dcec40bd8ad6af83295c20"` [INFO] [stderr] Checking net2 v0.2.26 [INFO] [stderr] Checking inotify v0.3.0 [INFO] [stderr] Checking filetime v0.1.10 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking docopt v1.0.0 [INFO] [stderr] Checking miow v0.1.3 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking notify v4.0.3 [INFO] [stderr] Checking funzzy v0.3.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/watch.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | WatchCommand { watches: watches , verbose: verbose } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `watches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/watch.rs:28:43 [INFO] [stderr] | [INFO] [stderr] 28 | WatchCommand { watches: watches , verbose: verbose } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `verbose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/watch.rs:92:19 [INFO] [stderr] | [INFO] [stderr] 92 | Watches { rules: rules } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/run.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | RunCommand { command: command, interval: interval } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/run.rs:18:40 [INFO] [stderr] | [INFO] [stderr] 18 | RunCommand { command: command, interval: interval } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `interval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rules.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | commands: commands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `commands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/watch.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | WatchCommand { watches: watches , verbose: verbose } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `watches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/watch.rs:28:43 [INFO] [stderr] | [INFO] [stderr] 28 | WatchCommand { watches: watches , verbose: verbose } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `verbose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/watch.rs:92:19 [INFO] [stderr] | [INFO] [stderr] 92 | Watches { rules: rules } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/run.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | RunCommand { command: command, interval: interval } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/run.rs:18:40 [INFO] [stderr] | [INFO] [stderr] 18 | RunCommand { command: command, interval: interval } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `interval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rules.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | commands: commands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `commands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/init.rs:7:29 [INFO] [stderr] | [INFO] [stderr] 7 | pub const DEFAULT_CONTENT: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/watch.rs:13:30 [INFO] [stderr] | [INFO] [stderr] 13 | pub const DEFAULT_FILENAME: &'static str = ".watch.yaml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmd.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/init.rs:7:29 [INFO] [stderr] | [INFO] [stderr] 7 | pub const DEFAULT_CONTENT: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/watch.rs:13:30 [INFO] [stderr] | [INFO] [stderr] 13 | pub const DEFAULT_FILENAME: &'static str = ".watch.yaml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cmd.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | return Ok(()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/cli/watch.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | / for rule in self.rules.iter() [INFO] [stderr] 104 | | .filter(|r| !r.ignore(path) && r.watch(path)) { [INFO] [stderr] 105 | | return Some(rule.commands()); [INFO] [stderr] 106 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/rules.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / self.ignore_patterns.iter() [INFO] [stderr] 42 | | .any(|ignore| pattern(ignore).matches(path)) || false [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 41 | self.ignore_patterns.iter() [INFO] [stderr] 42 | .any(|ignore| pattern(ignore).matches(path)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rules.rs:60:47 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn from_string(patterns: String, command: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 60 | pub fn from_string(patterns: String, command: &str) -> Vec { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `command.clone()` to [INFO] [stderr] | [INFO] [stderr] 65 | vec![Rules::new(vec![command.to_string()], watches, vec![])] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmd.rs:10:11 [INFO] [stderr] | [INFO] [stderr] 10 | while tokens.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/cmd.rs:12:15 [INFO] [stderr] | [INFO] [stderr] 12 | match token.clone() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 12 | match &(*token).clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 12 | match &str::clone(token) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `funzzy`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/cli/watch.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | / for rule in self.rules.iter() [INFO] [stderr] 104 | | .filter(|r| !r.ignore(path) && r.watch(path)) { [INFO] [stderr] 105 | | return Some(rule.commands()); [INFO] [stderr] 106 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/rules.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / self.ignore_patterns.iter() [INFO] [stderr] 42 | | .any(|ignore| pattern(ignore).matches(path)) || false [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 41 | self.ignore_patterns.iter() [INFO] [stderr] 42 | .any(|ignore| pattern(ignore).matches(path)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rules.rs:60:47 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn from_string(patterns: String, command: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 60 | pub fn from_string(patterns: String, command: &str) -> Vec { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `command.clone()` to [INFO] [stderr] | [INFO] [stderr] 65 | vec![Rules::new(vec![command.to_string()], watches, vec![])] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmd.rs:10:11 [INFO] [stderr] | [INFO] [stderr] 10 | while tokens.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/cmd.rs:12:15 [INFO] [stderr] | [INFO] [stderr] 12 | match token.clone() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 12 | match &(*token).clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 12 | match &str::clone(token) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `funzzy`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "676453a851d7579c262501d635f27fe8c004b657f0dcec40bd8ad6af83295c20"` [INFO] running `"docker" "rm" "-f" "676453a851d7579c262501d635f27fe8c004b657f0dcec40bd8ad6af83295c20"` [INFO] [stdout] 676453a851d7579c262501d635f27fe8c004b657f0dcec40bd8ad6af83295c20