[INFO] updating cached repository creationix/jack.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/creationix/jack.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/creationix/jack.rs" "work/ex/clippy-test-run/sources/stable/gh/creationix/jack.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/creationix/jack.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/creationix/jack.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/creationix/jack.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/creationix/jack.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] af183e1413c5b6b7e67cefa14d329a35aa7d6ad5 [INFO] sha for GitHub repo creationix/jack.rs: af183e1413c5b6b7e67cefa14d329a35aa7d6ad5 [INFO] validating manifest of creationix/jack.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of creationix/jack.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing creationix/jack.rs [INFO] finished frobbing creationix/jack.rs [INFO] frobbed toml for creationix/jack.rs written to work/ex/clippy-test-run/sources/stable/gh/creationix/jack.rs/Cargo.toml [INFO] started frobbing creationix/jack.rs [INFO] finished frobbing creationix/jack.rs [INFO] frobbed toml for creationix/jack.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/creationix/jack.rs/Cargo.toml [INFO] crate creationix/jack.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting creationix/jack.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/creationix/jack.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 45456d368e748dcb2641ab3f18a14030954df18c58824fc37872df4e5fa22be9 [INFO] running `"docker" "start" "-a" "45456d368e748dcb2641ab3f18a14030954df18c58824fc37872df4e5fa22be9"` [INFO] [stderr] Checking rusty-jack v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:24:10 [INFO] [stderr] | [INFO] [stderr] 24 | try!(match left { [INFO] [stderr] | __________^ [INFO] [stderr] 25 | | &Code::Op(_) => write!(f, "({})", left), [INFO] [stderr] 26 | | _ => write!(f, "{}", left) [INFO] [stderr] 27 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | try!(match *left { [INFO] [stderr] 25 | Code::Op(_) => write!(f, "({})", left), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / match right { [INFO] [stderr] 30 | | &Code::Op(_) => write!(f, "({})", right), [INFO] [stderr] 31 | | _ => write!(f, "{}", right) [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *right { [INFO] [stderr] 30 | Code::Op(_) => write!(f, "({})", right), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / match num { [INFO] [stderr] 37 | | &Code::Integer(n) if n < 0 => write!(f, "-({})", num), [INFO] [stderr] 38 | | &Code::Rational(n, _) if n < 0 => write!(f, "-({})", num), [INFO] [stderr] 39 | | &Code::Op(_) => write!(f, "-({})", num), [INFO] [stderr] 40 | | _ => write!(f, "-{}", num), [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | match *num { [INFO] [stderr] 37 | Code::Integer(n) if n < 0 => write!(f, "-({})", num), [INFO] [stderr] 38 | Code::Rational(n, _) if n < 0 => write!(f, "-({})", num), [INFO] [stderr] 39 | Code::Op(_) => write!(f, "-({})", num), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / match self { [INFO] [stderr] 47 | | &Code::Integer(n) => write!(f, "{}", n), [INFO] [stderr] 48 | | &Code::Rational(n, d) => write!(f, "{}/{}", n, d), [INFO] [stderr] 49 | | &Code::String(ref s) => write!(f, "'{}'", s), [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 46 | match *self { [INFO] [stderr] 47 | Code::Integer(n) => write!(f, "{}", n), [INFO] [stderr] 48 | Code::Rational(n, d) => write!(f, "{}/{}", n, d), [INFO] [stderr] 49 | Code::String(ref s) => write!(f, "'{}'", s), [INFO] [stderr] 50 | Code::Op(ref op) => match op { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:50:34 [INFO] [stderr] | [INFO] [stderr] 50 | &Code::Op(ref op) => match op { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 51 | | &Op::Add(ref left, ref right) => binopfmt(f, left, right, "+"), [INFO] [stderr] 52 | | &Op::Sub(ref left, ref right) => binopfmt(f, left, right, "-"), [INFO] [stderr] 53 | | &Op::Div(ref left, ref right) => binopfmt(f, left, right, "/"), [INFO] [stderr] ... | [INFO] [stderr] 56 | | [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | &Code::Op(ref op) => match *op { [INFO] [stderr] 51 | Op::Add(ref left, ref right) => binopfmt(f, left, right, "+"), [INFO] [stderr] 52 | Op::Sub(ref left, ref right) => binopfmt(f, left, right, "-"), [INFO] [stderr] 53 | Op::Div(ref left, ref right) => binopfmt(f, left, right, "/"), [INFO] [stderr] 54 | Op::Mul(ref left, ref right) => binopfmt(f, left, right, "*"), [INFO] [stderr] 55 | Op::Neg(ref num) => negfmt(f, num), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | n = n / g; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n /= g` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | d = d / g; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `d /= g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / match num { [INFO] [stderr] 144 | | &Code::Integer(a) => Ok(Code::Integer(-a)), [INFO] [stderr] 145 | | &Code::Rational(n, d) => Ok(Code::Rational(-n, d)), [INFO] [stderr] 146 | | _ => Err("Negate requires a number"), [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 143 | match *num { [INFO] [stderr] 144 | Code::Integer(a) => Ok(Code::Integer(-a)), [INFO] [stderr] 145 | Code::Rational(n, d) => Ok(Code::Rational(-n, d)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:153:30 [INFO] [stderr] | [INFO] [stderr] 153 | &Code::Op(ref op) => match op { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 154 | | &Op::Add(ref left, ref right) => add(left, right), [INFO] [stderr] 155 | | &Op::Sub(ref left, ref right) => subtract(left, right), [INFO] [stderr] 156 | | &Op::Mul(ref left, ref right) => multiply(left, right), [INFO] [stderr] 157 | | &Op::Div(ref left, ref right) => divide(left, right), [INFO] [stderr] 158 | | &Op::Neg(ref num) => negate(num), [INFO] [stderr] 159 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 153 | &Code::Op(ref op) => match *op { [INFO] [stderr] 154 | Op::Add(ref left, ref right) => add(left, right), [INFO] [stderr] 155 | Op::Sub(ref left, ref right) => subtract(left, right), [INFO] [stderr] 156 | Op::Mul(ref left, ref right) => multiply(left, right), [INFO] [stderr] 157 | Op::Div(ref left, ref right) => divide(left, right), [INFO] [stderr] 158 | Op::Neg(ref num) => negate(num), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:24:10 [INFO] [stderr] | [INFO] [stderr] 24 | try!(match left { [INFO] [stderr] | __________^ [INFO] [stderr] 25 | | &Code::Op(_) => write!(f, "({})", left), [INFO] [stderr] 26 | | _ => write!(f, "{}", left) [INFO] [stderr] 27 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | try!(match *left { [INFO] [stderr] 25 | Code::Op(_) => write!(f, "({})", left), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / match right { [INFO] [stderr] 30 | | &Code::Op(_) => write!(f, "({})", right), [INFO] [stderr] 31 | | _ => write!(f, "{}", right) [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *right { [INFO] [stderr] 30 | Code::Op(_) => write!(f, "({})", right), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / match num { [INFO] [stderr] 37 | | &Code::Integer(n) if n < 0 => write!(f, "-({})", num), [INFO] [stderr] 38 | | &Code::Rational(n, _) if n < 0 => write!(f, "-({})", num), [INFO] [stderr] 39 | | &Code::Op(_) => write!(f, "-({})", num), [INFO] [stderr] 40 | | _ => write!(f, "-{}", num), [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | match *num { [INFO] [stderr] 37 | Code::Integer(n) if n < 0 => write!(f, "-({})", num), [INFO] [stderr] 38 | Code::Rational(n, _) if n < 0 => write!(f, "-({})", num), [INFO] [stderr] 39 | Code::Op(_) => write!(f, "-({})", num), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / match self { [INFO] [stderr] 47 | | &Code::Integer(n) => write!(f, "{}", n), [INFO] [stderr] 48 | | &Code::Rational(n, d) => write!(f, "{}/{}", n, d), [INFO] [stderr] 49 | | &Code::String(ref s) => write!(f, "'{}'", s), [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 46 | match *self { [INFO] [stderr] 47 | Code::Integer(n) => write!(f, "{}", n), [INFO] [stderr] 48 | Code::Rational(n, d) => write!(f, "{}/{}", n, d), [INFO] [stderr] 49 | Code::String(ref s) => write!(f, "'{}'", s), [INFO] [stderr] 50 | Code::Op(ref op) => match op { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:50:34 [INFO] [stderr] | [INFO] [stderr] 50 | &Code::Op(ref op) => match op { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 51 | | &Op::Add(ref left, ref right) => binopfmt(f, left, right, "+"), [INFO] [stderr] 52 | | &Op::Sub(ref left, ref right) => binopfmt(f, left, right, "-"), [INFO] [stderr] 53 | | &Op::Div(ref left, ref right) => binopfmt(f, left, right, "/"), [INFO] [stderr] ... | [INFO] [stderr] 56 | | [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | &Code::Op(ref op) => match *op { [INFO] [stderr] 51 | Op::Add(ref left, ref right) => binopfmt(f, left, right, "+"), [INFO] [stderr] 52 | Op::Sub(ref left, ref right) => binopfmt(f, left, right, "-"), [INFO] [stderr] 53 | Op::Div(ref left, ref right) => binopfmt(f, left, right, "/"), [INFO] [stderr] 54 | Op::Mul(ref left, ref right) => binopfmt(f, left, right, "*"), [INFO] [stderr] 55 | Op::Neg(ref num) => negfmt(f, num), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | n = n / g; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n /= g` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | d = d / g; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `d /= g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / match num { [INFO] [stderr] 144 | | &Code::Integer(a) => Ok(Code::Integer(-a)), [INFO] [stderr] 145 | | &Code::Rational(n, d) => Ok(Code::Rational(-n, d)), [INFO] [stderr] 146 | | _ => Err("Negate requires a number"), [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 143 | match *num { [INFO] [stderr] 144 | Code::Integer(a) => Ok(Code::Integer(-a)), [INFO] [stderr] 145 | Code::Rational(n, d) => Ok(Code::Rational(-n, d)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:153:30 [INFO] [stderr] | [INFO] [stderr] 153 | &Code::Op(ref op) => match op { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 154 | | &Op::Add(ref left, ref right) => add(left, right), [INFO] [stderr] 155 | | &Op::Sub(ref left, ref right) => subtract(left, right), [INFO] [stderr] 156 | | &Op::Mul(ref left, ref right) => multiply(left, right), [INFO] [stderr] 157 | | &Op::Div(ref left, ref right) => divide(left, right), [INFO] [stderr] 158 | | &Op::Neg(ref num) => negate(num), [INFO] [stderr] 159 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 153 | &Code::Op(ref op) => match *op { [INFO] [stderr] 154 | Op::Add(ref left, ref right) => add(left, right), [INFO] [stderr] 155 | Op::Sub(ref left, ref right) => subtract(left, right), [INFO] [stderr] 156 | Op::Mul(ref left, ref right) => multiply(left, right), [INFO] [stderr] 157 | Op::Div(ref left, ref right) => divide(left, right), [INFO] [stderr] 158 | Op::Neg(ref num) => negate(num), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.76s [INFO] running `"docker" "inspect" "45456d368e748dcb2641ab3f18a14030954df18c58824fc37872df4e5fa22be9"` [INFO] running `"docker" "rm" "-f" "45456d368e748dcb2641ab3f18a14030954df18c58824fc37872df4e5fa22be9"` [INFO] [stdout] 45456d368e748dcb2641ab3f18a14030954df18c58824fc37872df4e5fa22be9