[INFO] updating cached repository cpsdqs/lambda
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/cpsdqs/lambda
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/cpsdqs/lambda" "work/ex/clippy-test-run/sources/stable/gh/cpsdqs/lambda"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cpsdqs/lambda'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/cpsdqs/lambda" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cpsdqs/lambda"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cpsdqs/lambda'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7d8c3003aa0447c1a7a4d4277cce5fe967d6fbc0
[INFO] sha for GitHub repo cpsdqs/lambda: 7d8c3003aa0447c1a7a4d4277cce5fe967d6fbc0
[INFO] validating manifest of cpsdqs/lambda on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cpsdqs/lambda on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cpsdqs/lambda
[INFO] finished frobbing cpsdqs/lambda
[INFO] frobbed toml for cpsdqs/lambda written to work/ex/clippy-test-run/sources/stable/gh/cpsdqs/lambda/Cargo.toml
[INFO] started frobbing cpsdqs/lambda
[INFO] finished frobbing cpsdqs/lambda
[INFO] frobbed toml for cpsdqs/lambda written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cpsdqs/lambda/Cargo.toml
[INFO] crate cpsdqs/lambda has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cpsdqs/lambda against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cpsdqs/lambda:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 82964fcbf26b6370b8503d644ea739aa72ffe02abde5994a1af2b306f7aa9751
[INFO] running `"docker" "start" "-a" "82964fcbf26b6370b8503d644ea739aa72ffe02abde5994a1af2b306f7aa9751"`
[INFO] [stderr]     Checking lambda v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/main.rs:328:5
[INFO] [stderr]     |
[INFO] [stderr] 328 | /     if tokens.len() >= 3 {
[INFO] [stderr] 329 | |         if tokens[0].is_identifier() && tokens[1] == LexToken::Define {
[INFO] [stderr] 330 | |             define = match tokens.remove(0) {
[INFO] [stderr] 331 | |                 LexToken::Identifier(n) => Some(n),
[INFO] [stderr] ...   |
[INFO] [stderr] 335 | |         }
[INFO] [stderr] 336 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 328 |     if tokens.len() >= 3 && tokens[0].is_identifier() && tokens[1] == LexToken::Define {
[INFO] [stderr] 329 |     define = match tokens.remove(0) {
[INFO] [stderr] 330 |         LexToken::Identifier(n) => Some(n),
[INFO] [stderr] 331 |         _ => panic!(),
[INFO] [stderr] 332 |     };
[INFO] [stderr] 333 |     tokens.remove(0);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/main.rs:508:12
[INFO] [stderr]     |
[INFO] [stderr] 508 |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 509 | |         if let Some(node) = convert_expr(node) {
[INFO] [stderr] 510 | |             println!("\x1b[36m{}\x1b[m", node.reduce(&HashMap::new(), index));
[INFO] [stderr] 511 | |         }
[INFO] [stderr] 512 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 508 |     } else if let Some(node) = convert_expr(node) {
[INFO] [stderr] 509 |     println!("\x1b[36m{}\x1b[m", node.reduce(&HashMap::new(), index));
[INFO] [stderr] 510 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/main.rs:328:5
[INFO] [stderr]     |
[INFO] [stderr] 328 | /     if tokens.len() >= 3 {
[INFO] [stderr] 329 | |         if tokens[0].is_identifier() && tokens[1] == LexToken::Define {
[INFO] [stderr] 330 | |             define = match tokens.remove(0) {
[INFO] [stderr] 331 | |                 LexToken::Identifier(n) => Some(n),
[INFO] [stderr] ...   |
[INFO] [stderr] 335 | |         }
[INFO] [stderr] 336 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 328 |     if tokens.len() >= 3 && tokens[0].is_identifier() && tokens[1] == LexToken::Define {
[INFO] [stderr] 329 |     define = match tokens.remove(0) {
[INFO] [stderr] 330 |         LexToken::Identifier(n) => Some(n),
[INFO] [stderr] 331 |         _ => panic!(),
[INFO] [stderr] 332 |     };
[INFO] [stderr] 333 |     tokens.remove(0);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/main.rs:508:12
[INFO] [stderr]     |
[INFO] [stderr] 508 |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 509 | |         if let Some(node) = convert_expr(node) {
[INFO] [stderr] 510 | |             println!("\x1b[36m{}\x1b[m", node.reduce(&HashMap::new(), index));
[INFO] [stderr] 511 | |         }
[INFO] [stderr] 512 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 508 |     } else if let Some(node) = convert_expr(node) {
[INFO] [stderr] 509 |     println!("\x1b[36m{}\x1b[m", node.reduce(&HashMap::new(), index));
[INFO] [stderr] 510 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `LambdaIndex`
[INFO] [stderr]   --> src/main.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     pub fn new() -> LambdaIndex {
[INFO] [stderr] 28 | |         LambdaIndex {
[INFO] [stderr] 29 | |             lambdas: HashMap::new(),
[INFO] [stderr] 30 | |         }
[INFO] [stderr] 31 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 22 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/main.rs:34:26
[INFO] [stderr]    |
[INFO] [stderr] 34 |         self.lambdas.get(name.into())
[INFO] [stderr]    |                          ^^^^^^^^^^^ help: consider removing `.into()`: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/main.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 |     ARGUMENT_NAMES.lock().unwrap().get(&id).map(|x| x.clone())
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `ARGUMENT_NAMES.lock().unwrap().get(&id).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 | /         match self {
[INFO] [stderr] 68 | |             &LambdaItem::Value(ref name) => LambdaItem::Value(name.clone()),
[INFO] [stderr] 69 | |             &LambdaItem::Argument(id) => args.get(&id).unwrap_or(&LambdaItem::Argument(id)).clone(),
[INFO] [stderr] 70 | |             &LambdaItem::Lambda(ref lambda) => LambdaItem::Lambda(Box::new(lambda.subst_args(args))),
[INFO] [stderr] ...  |
[INFO] [stderr] 94 | |             }
[INFO] [stderr] 95 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 67 |         match *self {
[INFO] [stderr] 68 |             LambdaItem::Value(ref name) => LambdaItem::Value(name.clone()),
[INFO] [stderr] 69 |             LambdaItem::Argument(id) => args.get(&id).unwrap_or(&LambdaItem::Argument(id)).clone(),
[INFO] [stderr] 70 |             LambdaItem::Lambda(ref lambda) => LambdaItem::Lambda(Box::new(lambda.subst_args(args))),
[INFO] [stderr] 71 |             LambdaItem::Call(ref callee, ref arg) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:99:9
[INFO] [stderr]     |
[INFO] [stderr] 99  | /         match self {
[INFO] [stderr] 100 | |             &LambdaItem::Value(..) => self.clone(),
[INFO] [stderr] 101 | |             &LambdaItem::Argument(id) => args.get(&id).unwrap_or(&LambdaItem::Argument(id)).clone(),
[INFO] [stderr] 102 | |             &LambdaItem::Lambda(ref l) => LambdaItem::Lambda(Box::new(l.subst_args(args))),
[INFO] [stderr] 103 | |             &LambdaItem::Call(ref a, ref b) => LambdaItem::Call(Box::new(a.subst_args(args)), Box::new(b.subst_args(args))),
[INFO] [stderr] 104 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 99  |         match *self {
[INFO] [stderr] 100 |             LambdaItem::Value(..) => self.clone(),
[INFO] [stderr] 101 |             LambdaItem::Argument(id) => args.get(&id).unwrap_or(&LambdaItem::Argument(id)).clone(),
[INFO] [stderr] 102 |             LambdaItem::Lambda(ref l) => LambdaItem::Lambda(Box::new(l.subst_args(args))),
[INFO] [stderr] 103 |             LambdaItem::Call(ref a, ref b) => LambdaItem::Call(Box::new(a.subst_args(args)), Box::new(b.subst_args(args))),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:108:9
[INFO] [stderr]     |
[INFO] [stderr] 108 | /         match self {
[INFO] [stderr] 109 | |             &LambdaItem::Value(..) => false,
[INFO] [stderr] 110 | |             &LambdaItem::Argument(..) => false,
[INFO] [stderr] 111 | |             &LambdaItem::Lambda(..) => true,
[INFO] [stderr] 112 | |             &LambdaItem::Call(..) => true,
[INFO] [stderr] 113 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 108 |         match *self {
[INFO] [stderr] 109 |             LambdaItem::Value(..) => false,
[INFO] [stderr] 110 |             LambdaItem::Argument(..) => false,
[INFO] [stderr] 111 |             LambdaItem::Lambda(..) => true,
[INFO] [stderr] 112 |             LambdaItem::Call(..) => true,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:148:9
[INFO] [stderr]     |
[INFO] [stderr] 148 | /         match self {
[INFO] [stderr] 149 | |             &LambdaItem::Value(ref name) => write!(f, "{}", name),
[INFO] [stderr] 150 | |             &LambdaItem::Argument(id) => write!(f, "{}", argument_name(id).unwrap()),
[INFO] [stderr] 151 | |             &LambdaItem::Lambda(ref lambda) => write!(f, "{}", lambda),
[INFO] [stderr] ...   |
[INFO] [stderr] 164 | |             }
[INFO] [stderr] 165 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 148 |         match *self {
[INFO] [stderr] 149 |             LambdaItem::Value(ref name) => write!(f, "{}", name),
[INFO] [stderr] 150 |             LambdaItem::Argument(id) => write!(f, "{}", argument_name(id).unwrap()),
[INFO] [stderr] 151 |             LambdaItem::Lambda(ref lambda) => write!(f, "{}", lambda),
[INFO] [stderr] 152 |             LambdaItem::Call(ref a, ref b) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/main.rs:153:17
[INFO] [stderr]     |
[INFO] [stderr] 153 | /                 if let &LambdaItem::Call(ref c, ref d) = &**a {
[INFO] [stderr] 154 | |                     if d.needs_display_parens() {
[INFO] [stderr] 155 | |                         write!(f, "{} ({}) {}", c, d, b)
[INFO] [stderr] 156 | |                     } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 162 | |                     write!(f, "{} {}", a, b)
[INFO] [stderr] 163 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 153 |                 if let LambdaItem::Call(ref c, ref d) = **a {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:185:9
[INFO] [stderr]     |
[INFO] [stderr] 185 | /         match self {
[INFO] [stderr] 186 | |             &LexToken::Identifier(_) => true,
[INFO] [stderr] 187 | |             _ => false,
[INFO] [stderr] 188 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 185 |         match *self {
[INFO] [stderr] 186 |             LexToken::Identifier(_) => true,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:348:21
[INFO] [stderr]     |
[INFO] [stderr] 348 | /                     match next {
[INFO] [stderr] 349 | |                         &LexToken::Identifier(ref ident) => ident.clone(),
[INFO] [stderr] 350 | |                         _ => {
[INFO] [stderr] 351 | |                             return Err(ParseError::InvalidToken(
[INFO] [stderr] ...   |
[INFO] [stderr] 354 | |                         }
[INFO] [stderr] 355 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 348 |                     match *next {
[INFO] [stderr] 349 |                         LexToken::Identifier(ref ident) => ident.clone(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:363:21
[INFO] [stderr]     |
[INFO] [stderr] 363 | /                     match next {
[INFO] [stderr] 364 | |                         &LexToken::Dot => (),
[INFO] [stderr] 365 | |                         _ => {
[INFO] [stderr] 366 | |                             return Err(ParseError::InvalidToken(
[INFO] [stderr] ...   |
[INFO] [stderr] 369 | |                         }
[INFO] [stderr] 370 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 363 |                     match *next {
[INFO] [stderr] 364 |                         LexToken::Dot => (),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `LambdaIndex`
[INFO] [stderr]   --> src/main.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     pub fn new() -> LambdaIndex {
[INFO] [stderr] 28 | |         LambdaIndex {
[INFO] [stderr] 29 | |             lambdas: HashMap::new(),
[INFO] [stderr] 30 | |         }
[INFO] [stderr] 31 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 22 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/main.rs:34:26
[INFO] [stderr]    |
[INFO] [stderr] 34 |         self.lambdas.get(name.into())
[INFO] [stderr]    |                          ^^^^^^^^^^^ help: consider removing `.into()`: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/main.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 |     ARGUMENT_NAMES.lock().unwrap().get(&id).map(|x| x.clone())
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `ARGUMENT_NAMES.lock().unwrap().get(&id).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 | /         match self {
[INFO] [stderr] 68 | |             &LambdaItem::Value(ref name) => LambdaItem::Value(name.clone()),
[INFO] [stderr] 69 | |             &LambdaItem::Argument(id) => args.get(&id).unwrap_or(&LambdaItem::Argument(id)).clone(),
[INFO] [stderr] 70 | |             &LambdaItem::Lambda(ref lambda) => LambdaItem::Lambda(Box::new(lambda.subst_args(args))),
[INFO] [stderr] ...  |
[INFO] [stderr] 94 | |             }
[INFO] [stderr] 95 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 67 |         match *self {
[INFO] [stderr] 68 |             LambdaItem::Value(ref name) => LambdaItem::Value(name.clone()),
[INFO] [stderr] 69 |             LambdaItem::Argument(id) => args.get(&id).unwrap_or(&LambdaItem::Argument(id)).clone(),
[INFO] [stderr] 70 |             LambdaItem::Lambda(ref lambda) => LambdaItem::Lambda(Box::new(lambda.subst_args(args))),
[INFO] [stderr] 71 |             LambdaItem::Call(ref callee, ref arg) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:99:9
[INFO] [stderr]     |
[INFO] [stderr] 99  | /         match self {
[INFO] [stderr] 100 | |             &LambdaItem::Value(..) => self.clone(),
[INFO] [stderr] 101 | |             &LambdaItem::Argument(id) => args.get(&id).unwrap_or(&LambdaItem::Argument(id)).clone(),
[INFO] [stderr] 102 | |             &LambdaItem::Lambda(ref l) => LambdaItem::Lambda(Box::new(l.subst_args(args))),
[INFO] [stderr] 103 | |             &LambdaItem::Call(ref a, ref b) => LambdaItem::Call(Box::new(a.subst_args(args)), Box::new(b.subst_args(args))),
[INFO] [stderr] 104 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 99  |         match *self {
[INFO] [stderr] 100 |             LambdaItem::Value(..) => self.clone(),
[INFO] [stderr] 101 |             LambdaItem::Argument(id) => args.get(&id).unwrap_or(&LambdaItem::Argument(id)).clone(),
[INFO] [stderr] 102 |             LambdaItem::Lambda(ref l) => LambdaItem::Lambda(Box::new(l.subst_args(args))),
[INFO] [stderr] 103 |             LambdaItem::Call(ref a, ref b) => LambdaItem::Call(Box::new(a.subst_args(args)), Box::new(b.subst_args(args))),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:108:9
[INFO] [stderr]     |
[INFO] [stderr] 108 | /         match self {
[INFO] [stderr] 109 | |             &LambdaItem::Value(..) => false,
[INFO] [stderr] 110 | |             &LambdaItem::Argument(..) => false,
[INFO] [stderr] 111 | |             &LambdaItem::Lambda(..) => true,
[INFO] [stderr] 112 | |             &LambdaItem::Call(..) => true,
[INFO] [stderr] 113 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 108 |         match *self {
[INFO] [stderr] 109 |             LambdaItem::Value(..) => false,
[INFO] [stderr] 110 |             LambdaItem::Argument(..) => false,
[INFO] [stderr] 111 |             LambdaItem::Lambda(..) => true,
[INFO] [stderr] 112 |             LambdaItem::Call(..) => true,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:148:9
[INFO] [stderr]     |
[INFO] [stderr] 148 | /         match self {
[INFO] [stderr] 149 | |             &LambdaItem::Value(ref name) => write!(f, "{}", name),
[INFO] [stderr] 150 | |             &LambdaItem::Argument(id) => write!(f, "{}", argument_name(id).unwrap()),
[INFO] [stderr] 151 | |             &LambdaItem::Lambda(ref lambda) => write!(f, "{}", lambda),
[INFO] [stderr] ...   |
[INFO] [stderr] 164 | |             }
[INFO] [stderr] 165 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 148 |         match *self {
[INFO] [stderr] 149 |             LambdaItem::Value(ref name) => write!(f, "{}", name),
[INFO] [stderr] 150 |             LambdaItem::Argument(id) => write!(f, "{}", argument_name(id).unwrap()),
[INFO] [stderr] 151 |             LambdaItem::Lambda(ref lambda) => write!(f, "{}", lambda),
[INFO] [stderr] 152 |             LambdaItem::Call(ref a, ref b) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/main.rs:153:17
[INFO] [stderr]     |
[INFO] [stderr] 153 | /                 if let &LambdaItem::Call(ref c, ref d) = &**a {
[INFO] [stderr] 154 | |                     if d.needs_display_parens() {
[INFO] [stderr] 155 | |                         write!(f, "{} ({}) {}", c, d, b)
[INFO] [stderr] 156 | |                     } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 162 | |                     write!(f, "{} {}", a, b)
[INFO] [stderr] 163 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 153 |                 if let LambdaItem::Call(ref c, ref d) = **a {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:185:9
[INFO] [stderr]     |
[INFO] [stderr] 185 | /         match self {
[INFO] [stderr] 186 | |             &LexToken::Identifier(_) => true,
[INFO] [stderr] 187 | |             _ => false,
[INFO] [stderr] 188 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 185 |         match *self {
[INFO] [stderr] 186 |             LexToken::Identifier(_) => true,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:348:21
[INFO] [stderr]     |
[INFO] [stderr] 348 | /                     match next {
[INFO] [stderr] 349 | |                         &LexToken::Identifier(ref ident) => ident.clone(),
[INFO] [stderr] 350 | |                         _ => {
[INFO] [stderr] 351 | |                             return Err(ParseError::InvalidToken(
[INFO] [stderr] ...   |
[INFO] [stderr] 354 | |                         }
[INFO] [stderr] 355 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 348 |                     match *next {
[INFO] [stderr] 349 |                         LexToken::Identifier(ref ident) => ident.clone(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:363:21
[INFO] [stderr]     |
[INFO] [stderr] 363 | /                     match next {
[INFO] [stderr] 364 | |                         &LexToken::Dot => (),
[INFO] [stderr] 365 | |                         _ => {
[INFO] [stderr] 366 | |                             return Err(ParseError::InvalidToken(
[INFO] [stderr] ...   |
[INFO] [stderr] 369 | |                         }
[INFO] [stderr] 370 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 363 |                     match *next {
[INFO] [stderr] 364 |                         LexToken::Dot => (),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.05s
[INFO] running `"docker" "inspect" "82964fcbf26b6370b8503d644ea739aa72ffe02abde5994a1af2b306f7aa9751"`
[INFO] running `"docker" "rm" "-f" "82964fcbf26b6370b8503d644ea739aa72ffe02abde5994a1af2b306f7aa9751"`
[INFO] [stdout] 82964fcbf26b6370b8503d644ea739aa72ffe02abde5994a1af2b306f7aa9751