[INFO] updating cached repository cpfiffer/pricing-engine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cpfiffer/pricing-engine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cpfiffer/pricing-engine" "work/ex/clippy-test-run/sources/stable/gh/cpfiffer/pricing-engine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cpfiffer/pricing-engine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cpfiffer/pricing-engine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cpfiffer/pricing-engine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cpfiffer/pricing-engine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d17886b59961620eaf7fd45f70fcc7d5543ad1da [INFO] sha for GitHub repo cpfiffer/pricing-engine: d17886b59961620eaf7fd45f70fcc7d5543ad1da [INFO] validating manifest of cpfiffer/pricing-engine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cpfiffer/pricing-engine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cpfiffer/pricing-engine [INFO] finished frobbing cpfiffer/pricing-engine [INFO] frobbed toml for cpfiffer/pricing-engine written to work/ex/clippy-test-run/sources/stable/gh/cpfiffer/pricing-engine/Cargo.toml [INFO] started frobbing cpfiffer/pricing-engine [INFO] finished frobbing cpfiffer/pricing-engine [INFO] frobbed toml for cpfiffer/pricing-engine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cpfiffer/pricing-engine/Cargo.toml [INFO] crate cpfiffer/pricing-engine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cpfiffer/pricing-engine against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cpfiffer/pricing-engine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b4166f275f26f261ad410f5e8ca054fbeb432f7052aa79626a22ffa042434d2e [INFO] running `"docker" "start" "-a" "b4166f275f26f261ad410f5e8ca054fbeb432f7052aa79626a22ffa042434d2e"` [INFO] [stderr] Checking pretty_env_logger v0.2.4 [INFO] [stderr] Checking pricing-engine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/orderbook/orders.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | price: price, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `price` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/orderbook/orders.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | price: price, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `price` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/orderbook/orders.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | price: price, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `price` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/orderbook/orders.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | price: price, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `price` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/orderbook/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub mod orderbook; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/orderbook/orderbook.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / return Orderbook{ [INFO] [stderr] 27 | | name, [INFO] [stderr] 28 | | automatch: false, [INFO] [stderr] 29 | | buys: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 32 | | best_sell: (String::default(), f64::MAX), [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | Orderbook{ [INFO] [stderr] 27 | name, [INFO] [stderr] 28 | automatch: false, [INFO] [stderr] 29 | buys: HashMap::new(), [INFO] [stderr] 30 | sells: HashMap::new(), [INFO] [stderr] 31 | best_buy: (String::default(), f64::MIN), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/orderbook/orderbook.rs:111:24 [INFO] [stderr] | [INFO] [stderr] 111 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/orderbook/pricelevel.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return PriceLevel {quantity: order.amount} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PriceLevel {quantity: order.amount}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/orderbook/orders.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / return Order { [INFO] [stderr] 21 | | order_type: Ordertype::Sell, [INFO] [stderr] 22 | | price_string: price.to_string(), [INFO] [stderr] 23 | | price: price, [INFO] [stderr] 24 | | amount, [INFO] [stderr] 25 | | additive [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 20 | Order { [INFO] [stderr] 21 | order_type: Ordertype::Sell, [INFO] [stderr] 22 | price_string: price.to_string(), [INFO] [stderr] 23 | price: price, [INFO] [stderr] 24 | amount, [INFO] [stderr] 25 | additive [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/orderbook/orders.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return Order { [INFO] [stderr] 31 | | order_type: Ordertype::Buy, [INFO] [stderr] 32 | | price_string: price.to_string(), [INFO] [stderr] 33 | | price: price, [INFO] [stderr] 34 | | amount, [INFO] [stderr] 35 | | additive [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | Order { [INFO] [stderr] 31 | order_type: Ordertype::Buy, [INFO] [stderr] 32 | price_string: price.to_string(), [INFO] [stderr] 33 | price: price, [INFO] [stderr] 34 | amount, [INFO] [stderr] 35 | additive [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/testing/mod.rs:20:40 [INFO] [stderr] | [INFO] [stderr] 20 | let amount_range = Uniform::new(1, 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/testing/mod.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | return Order::sell(price.into(), amount.into(), cumulative); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Order::sell(price.into(), amount.into(), cumulative)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/testing/mod.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return Order::buy(price.into(), amount.into(), cumulative); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Order::buy(price.into(), amount.into(), cumulative)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/testing/mod.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return serde_json::to_string_pretty(&new_order).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `serde_json::to_string_pretty(&new_order).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/orderbook/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub mod orderbook; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/orderbook/orderbook.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / return Orderbook{ [INFO] [stderr] 27 | | name, [INFO] [stderr] 28 | | automatch: false, [INFO] [stderr] 29 | | buys: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 32 | | best_sell: (String::default(), f64::MAX), [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | Orderbook{ [INFO] [stderr] 27 | name, [INFO] [stderr] 28 | automatch: false, [INFO] [stderr] 29 | buys: HashMap::new(), [INFO] [stderr] 30 | sells: HashMap::new(), [INFO] [stderr] 31 | best_buy: (String::default(), f64::MIN), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/orderbook/orderbook.rs:111:24 [INFO] [stderr] | [INFO] [stderr] 111 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/orderbook/pricelevel.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return PriceLevel {quantity: order.amount} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PriceLevel {quantity: order.amount}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/orderbook/orders.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / return Order { [INFO] [stderr] 21 | | order_type: Ordertype::Sell, [INFO] [stderr] 22 | | price_string: price.to_string(), [INFO] [stderr] 23 | | price: price, [INFO] [stderr] 24 | | amount, [INFO] [stderr] 25 | | additive [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 20 | Order { [INFO] [stderr] 21 | order_type: Ordertype::Sell, [INFO] [stderr] 22 | price_string: price.to_string(), [INFO] [stderr] 23 | price: price, [INFO] [stderr] 24 | amount, [INFO] [stderr] 25 | additive [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/orderbook/orders.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return Order { [INFO] [stderr] 31 | | order_type: Ordertype::Buy, [INFO] [stderr] 32 | | price_string: price.to_string(), [INFO] [stderr] 33 | | price: price, [INFO] [stderr] 34 | | amount, [INFO] [stderr] 35 | | additive [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | Order { [INFO] [stderr] 31 | order_type: Ordertype::Buy, [INFO] [stderr] 32 | price_string: price.to_string(), [INFO] [stderr] 33 | price: price, [INFO] [stderr] 34 | amount, [INFO] [stderr] 35 | additive [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/testing/mod.rs:20:40 [INFO] [stderr] | [INFO] [stderr] 20 | let amount_range = Uniform::new(1, 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/testing/mod.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | return Order::sell(price.into(), amount.into(), cumulative); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Order::sell(price.into(), amount.into(), cumulative)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/testing/mod.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return Order::buy(price.into(), amount.into(), cumulative); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Order::buy(price.into(), amount.into(), cumulative)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/testing/mod.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return serde_json::to_string_pretty(&new_order).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `serde_json::to_string_pretty(&new_order).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `automatch` [INFO] [stderr] --> src/orderbook/orderbook.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | automatch: bool, // Whether or not to match trades [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/orderbook/orderbook.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / match self.buys.contains_key(&new_buy.price_string) { [INFO] [stderr] 39 | | true => { [INFO] [stderr] 40 | | let price = new_buy.price_string; [INFO] [stderr] 41 | | if verbose { [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 38 | if self.buys.contains_key(&new_buy.price_string) { [INFO] [stderr] 39 | let price = new_buy.price_string; [INFO] [stderr] 40 | if verbose { [INFO] [stderr] 41 | info!("Inserting new buy level {} at {}", [INFO] [stderr] 42 | &price, [INFO] [stderr] 43 | pl.quantity) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/orderbook/orderbook.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match self.sells.contains_key(&new_sell.price_string) { [INFO] [stderr] 70 | | true => { [INFO] [stderr] 71 | | let price = new_sell.price_string; [INFO] [stderr] 72 | | if verbose { [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 69 | if self.sells.contains_key(&new_sell.price_string) { [INFO] [stderr] 70 | let price = new_sell.price_string; [INFO] [stderr] 71 | if verbose { [INFO] [stderr] 72 | info!("Inserting new sell level {} at {}", [INFO] [stderr] 73 | &price, [INFO] [stderr] 74 | pl.quantity) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/orderbook/orderbook.rs:127:70 [INFO] [stderr] | [INFO] [stderr] 127 | self.best_buy = (new_order.price_string.clone(), new_order.price.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_order.price` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/orderbook/orderbook.rs:132:71 [INFO] [stderr] | [INFO] [stderr] 132 | self.best_sell = (new_order.price_string.clone(), new_order.price.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_order.price` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: field is never used: `automatch` [INFO] [stderr] --> src/orderbook/orderbook.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | automatch: bool, // Whether or not to match trades [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/orderbook/orderbook.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / match self.buys.contains_key(&new_buy.price_string) { [INFO] [stderr] 39 | | true => { [INFO] [stderr] 40 | | let price = new_buy.price_string; [INFO] [stderr] 41 | | if verbose { [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 38 | if self.buys.contains_key(&new_buy.price_string) { [INFO] [stderr] 39 | let price = new_buy.price_string; [INFO] [stderr] 40 | if verbose { [INFO] [stderr] 41 | info!("Inserting new buy level {} at {}", [INFO] [stderr] 42 | &price, [INFO] [stderr] 43 | pl.quantity) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/orderbook/orderbook.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match self.sells.contains_key(&new_sell.price_string) { [INFO] [stderr] 70 | | true => { [INFO] [stderr] 71 | | let price = new_sell.price_string; [INFO] [stderr] 72 | | if verbose { [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 69 | if self.sells.contains_key(&new_sell.price_string) { [INFO] [stderr] 70 | let price = new_sell.price_string; [INFO] [stderr] 71 | if verbose { [INFO] [stderr] 72 | info!("Inserting new sell level {} at {}", [INFO] [stderr] 73 | &price, [INFO] [stderr] 74 | pl.quantity) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/orderbook/orderbook.rs:127:70 [INFO] [stderr] | [INFO] [stderr] 127 | self.best_buy = (new_order.price_string.clone(), new_order.price.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_order.price` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/orderbook/orderbook.rs:132:71 [INFO] [stderr] | [INFO] [stderr] 132 | self.best_sell = (new_order.price_string.clone(), new_order.price.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_order.price` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.88s [INFO] running `"docker" "inspect" "b4166f275f26f261ad410f5e8ca054fbeb432f7052aa79626a22ffa042434d2e"` [INFO] running `"docker" "rm" "-f" "b4166f275f26f261ad410f5e8ca054fbeb432f7052aa79626a22ffa042434d2e"` [INFO] [stdout] b4166f275f26f261ad410f5e8ca054fbeb432f7052aa79626a22ffa042434d2e