[INFO] updating cached repository cpearce/gl-rs-playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cpearce/gl-rs-playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cpearce/gl-rs-playground" "work/ex/clippy-test-run/sources/stable/gh/cpearce/gl-rs-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cpearce/gl-rs-playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cpearce/gl-rs-playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cpearce/gl-rs-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cpearce/gl-rs-playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2f39aaa15340a50687fcf43716043ce858041bc2 [INFO] sha for GitHub repo cpearce/gl-rs-playground: 2f39aaa15340a50687fcf43716043ce858041bc2 [INFO] validating manifest of cpearce/gl-rs-playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cpearce/gl-rs-playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cpearce/gl-rs-playground [INFO] finished frobbing cpearce/gl-rs-playground [INFO] frobbed toml for cpearce/gl-rs-playground written to work/ex/clippy-test-run/sources/stable/gh/cpearce/gl-rs-playground/Cargo.toml [INFO] started frobbing cpearce/gl-rs-playground [INFO] finished frobbing cpearce/gl-rs-playground [INFO] frobbed toml for cpearce/gl-rs-playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cpearce/gl-rs-playground/Cargo.toml [INFO] crate cpearce/gl-rs-playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cpearce/gl-rs-playground against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cpearce/gl-rs-playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e5a27473671eec1a5c80209ed34f2c0761c2fb68b803b6676b8e30d2a8e16920 [INFO] running `"docker" "start" "-a" "e5a27473671eec1a5c80209ed34f2c0761c2fb68b803b6676b8e30d2a8e16920"` [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Checking glutin v0.18.0 [INFO] [stderr] Checking fighter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:124:26 [INFO] [stderr] | [INFO] [stderr] 124 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:128:22 [INFO] [stderr] | [INFO] [stderr] 128 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | / str::from_utf8(&buf) [INFO] [stderr] 142 | | .ok() [INFO] [stderr] 143 | | .expect("ShaderInfoLog not valid utf8") [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:157:26 [INFO] [stderr] | [INFO] [stderr] 157 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:161:22 [INFO] [stderr] | [INFO] [stderr] 161 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | / str::from_utf8(&buf) [INFO] [stderr] 175 | | .ok() [INFO] [stderr] 176 | | .expect("ProgramInfoLog not valid utf8") [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/main.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | mem::transmute(&VERTEX_DATA[0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&VERTEX_DATA[0] as *const f32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/main.rs:227:13 [INFO] [stderr] | [INFO] [stderr] 227 | mem::transmute(&VERTEX_ELEMENTS[0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&VERTEX_ELEMENTS[0] as *const u32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:233:46 [INFO] [stderr] | [INFO] [stderr] 233 | gl::BindFragDataLocation(program, 0, CString::new("out_color").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:233:46 [INFO] [stderr] | [INFO] [stderr] 233 | gl::BindFragDataLocation(program, 0, CString::new("out_color").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:236:55 [INFO] [stderr] | [INFO] [stderr] 236 | let pos_attr = gl::GetAttribLocation(program, CString::new("position").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:236:55 [INFO] [stderr] | [INFO] [stderr] 236 | let pos_attr = gl::GetAttribLocation(program, CString::new("position").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:246:57 [INFO] [stderr] | [INFO] [stderr] 246 | let color_attr = gl::GetAttribLocation(program, CString::new("color").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:246:57 [INFO] [stderr] | [INFO] [stderr] 246 | let color_attr = gl::GetAttribLocation(program, CString::new("color").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:261:41 [INFO] [stderr] | [INFO] [stderr] 261 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 262 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 263 | | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 264 | | glutin::WindowEvent::Resized(logical_size) => { [INFO] [stderr] ... | [INFO] [stderr] 274 | | _ => (), [INFO] [stderr] 275 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 261 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 262 | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 263 | glutin::WindowEvent::Resized(logical_size) => { [INFO] [stderr] 264 | let dpi_factor = gl_window.get_hidpi_factor(); [INFO] [stderr] 265 | gl_window.resize(logical_size.to_physical(dpi_factor)); [INFO] [stderr] 266 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:268:69 [INFO] [stderr] | [INFO] [stderr] 268 | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 269 | | Some(glutin::VirtualKeyCode::Escape) => running = false, [INFO] [stderr] 270 | | _ => (), [INFO] [stderr] 271 | | }, [INFO] [stderr] | |_________________^ help: try this: `if let Some(glutin::VirtualKeyCode::Escape) = input.virtual_keycode { running = false }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:282:61 [INFO] [stderr] | [INFO] [stderr] 282 | let uni_color = gl::GetUniformLocation(program, CString::new("triangleColor").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:282:61 [INFO] [stderr] | [INFO] [stderr] 282 | let uni_color = gl::GetUniformLocation(program, CString::new("triangleColor").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:284:48 [INFO] [stderr] | [INFO] [stderr] 284 | let t = elapsed.as_secs() as f64 + elapsed.subsec_millis() as f64 / 1000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fighter`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:124:26 [INFO] [stderr] | [INFO] [stderr] 124 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:128:22 [INFO] [stderr] | [INFO] [stderr] 128 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | / str::from_utf8(&buf) [INFO] [stderr] 142 | | .ok() [INFO] [stderr] 143 | | .expect("ShaderInfoLog not valid utf8") [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:157:26 [INFO] [stderr] | [INFO] [stderr] 157 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:161:22 [INFO] [stderr] | [INFO] [stderr] 161 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | / str::from_utf8(&buf) [INFO] [stderr] 175 | | .ok() [INFO] [stderr] 176 | | .expect("ProgramInfoLog not valid utf8") [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/main.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | mem::transmute(&VERTEX_DATA[0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&VERTEX_DATA[0] as *const f32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/main.rs:227:13 [INFO] [stderr] | [INFO] [stderr] 227 | mem::transmute(&VERTEX_ELEMENTS[0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&VERTEX_ELEMENTS[0] as *const u32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:233:46 [INFO] [stderr] | [INFO] [stderr] 233 | gl::BindFragDataLocation(program, 0, CString::new("out_color").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:233:46 [INFO] [stderr] | [INFO] [stderr] 233 | gl::BindFragDataLocation(program, 0, CString::new("out_color").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:236:55 [INFO] [stderr] | [INFO] [stderr] 236 | let pos_attr = gl::GetAttribLocation(program, CString::new("position").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:236:55 [INFO] [stderr] | [INFO] [stderr] 236 | let pos_attr = gl::GetAttribLocation(program, CString::new("position").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:246:57 [INFO] [stderr] | [INFO] [stderr] 246 | let color_attr = gl::GetAttribLocation(program, CString::new("color").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:246:57 [INFO] [stderr] | [INFO] [stderr] 246 | let color_attr = gl::GetAttribLocation(program, CString::new("color").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:261:41 [INFO] [stderr] | [INFO] [stderr] 261 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 262 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 263 | | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 264 | | glutin::WindowEvent::Resized(logical_size) => { [INFO] [stderr] ... | [INFO] [stderr] 274 | | _ => (), [INFO] [stderr] 275 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 261 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 262 | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 263 | glutin::WindowEvent::Resized(logical_size) => { [INFO] [stderr] 264 | let dpi_factor = gl_window.get_hidpi_factor(); [INFO] [stderr] 265 | gl_window.resize(logical_size.to_physical(dpi_factor)); [INFO] [stderr] 266 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:268:69 [INFO] [stderr] | [INFO] [stderr] 268 | glutin::WindowEvent::KeyboardInput { input, .. } => match input.virtual_keycode { [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 269 | | Some(glutin::VirtualKeyCode::Escape) => running = false, [INFO] [stderr] 270 | | _ => (), [INFO] [stderr] 271 | | }, [INFO] [stderr] | |_________________^ help: try this: `if let Some(glutin::VirtualKeyCode::Escape) = input.virtual_keycode { running = false }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:282:61 [INFO] [stderr] | [INFO] [stderr] 282 | let uni_color = gl::GetUniformLocation(program, CString::new("triangleColor").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:282:61 [INFO] [stderr] | [INFO] [stderr] 282 | let uni_color = gl::GetUniformLocation(program, CString::new("triangleColor").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:284:48 [INFO] [stderr] | [INFO] [stderr] 284 | let t = elapsed.as_secs() as f64 + elapsed.subsec_millis() as f64 / 1000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fighter`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e5a27473671eec1a5c80209ed34f2c0761c2fb68b803b6676b8e30d2a8e16920"` [INFO] running `"docker" "rm" "-f" "e5a27473671eec1a5c80209ed34f2c0761c2fb68b803b6676b8e30d2a8e16920"` [INFO] [stdout] e5a27473671eec1a5c80209ed34f2c0761c2fb68b803b6676b8e30d2a8e16920