[INFO] updating cached repository cowang4/rusty_tree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cowang4/rusty_tree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cowang4/rusty_tree" "work/ex/clippy-test-run/sources/stable/gh/cowang4/rusty_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cowang4/rusty_tree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cowang4/rusty_tree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cowang4/rusty_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cowang4/rusty_tree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b7142822103e3764204bc091a978513193b0e8bc [INFO] sha for GitHub repo cowang4/rusty_tree: b7142822103e3764204bc091a978513193b0e8bc [INFO] validating manifest of cowang4/rusty_tree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cowang4/rusty_tree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cowang4/rusty_tree [INFO] finished frobbing cowang4/rusty_tree [INFO] frobbed toml for cowang4/rusty_tree written to work/ex/clippy-test-run/sources/stable/gh/cowang4/rusty_tree/Cargo.toml [INFO] started frobbing cowang4/rusty_tree [INFO] finished frobbing cowang4/rusty_tree [INFO] frobbed toml for cowang4/rusty_tree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cowang4/rusty_tree/Cargo.toml [INFO] crate cowang4/rusty_tree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cowang4/rusty_tree against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cowang4/rusty_tree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d3c8c94c9cd38d4dcc7dfb090edf55cdf5f3203670d9ec3da647f01c0da4ed5f [INFO] running `"docker" "start" "-a" "d3c8c94c9cd38d4dcc7dfb090edf55cdf5f3203670d9ec3da647f01c0da4ed5f"` [INFO] [stderr] Checking docopt v1.0.0 [INFO] [stderr] Checking rusty_tree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:120:15 [INFO] [stderr] | [INFO] [stderr] 120 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:120:15 [INFO] [stderr] | [INFO] [stderr] 120 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | fn build_prefix(verts: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:24:12 [INFO] [stderr] | [INFO] [stderr] 24 | if *entry == true { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `*entry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / let mut vert = "\u{2514}"; // right angle up/right [INFO] [stderr] 78 | | if size > 0 && i != size - 1 { [INFO] [stderr] 79 | | // not the last in the folder [INFO] [stderr] 80 | | vert = "\u{251c}"; // vertical T right [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let vert = if size > 0 && i != size - 1 { "\u{251c}" } else { "\u{2514}" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:72:34 [INFO] [stderr] | [INFO] [stderr] 72 | if file_name.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:158:29 [INFO] [stderr] | [INFO] [stderr] 158 | let dirs = args.arg_dir.unwrap_or(vec![dir_default]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![dir_default])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | fn build_prefix(verts: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:24:12 [INFO] [stderr] | [INFO] [stderr] 24 | if *entry == true { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `*entry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / let mut vert = "\u{2514}"; // right angle up/right [INFO] [stderr] 78 | | if size > 0 && i != size - 1 { [INFO] [stderr] 79 | | // not the last in the folder [INFO] [stderr] 80 | | vert = "\u{251c}"; // vertical T right [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let vert = if size > 0 && i != size - 1 { "\u{251c}" } else { "\u{2514}" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:72:34 [INFO] [stderr] | [INFO] [stderr] 72 | if file_name.starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:158:29 [INFO] [stderr] | [INFO] [stderr] 158 | let dirs = args.arg_dir.unwrap_or(vec![dir_default]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![dir_default])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.36s [INFO] running `"docker" "inspect" "d3c8c94c9cd38d4dcc7dfb090edf55cdf5f3203670d9ec3da647f01c0da4ed5f"` [INFO] running `"docker" "rm" "-f" "d3c8c94c9cd38d4dcc7dfb090edf55cdf5f3203670d9ec3da647f01c0da4ed5f"` [INFO] [stdout] d3c8c94c9cd38d4dcc7dfb090edf55cdf5f3203670d9ec3da647f01c0da4ed5f