[INFO] updating cached repository cout970/raytrace-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cout970/raytrace-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cout970/raytrace-rs" "work/ex/clippy-test-run/sources/stable/gh/cout970/raytrace-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cout970/raytrace-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cout970/raytrace-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cout970/raytrace-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cout970/raytrace-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8fca701129cfbc63318bafb1b698f65e6abe586c [INFO] sha for GitHub repo cout970/raytrace-rs: 8fca701129cfbc63318bafb1b698f65e6abe586c [INFO] validating manifest of cout970/raytrace-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cout970/raytrace-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cout970/raytrace-rs [INFO] finished frobbing cout970/raytrace-rs [INFO] frobbed toml for cout970/raytrace-rs written to work/ex/clippy-test-run/sources/stable/gh/cout970/raytrace-rs/Cargo.toml [INFO] started frobbing cout970/raytrace-rs [INFO] finished frobbing cout970/raytrace-rs [INFO] frobbed toml for cout970/raytrace-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cout970/raytrace-rs/Cargo.toml [INFO] crate cout970/raytrace-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cout970/raytrace-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cout970/raytrace-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 95a8a0ca2bc0f5e9325a2f52426ca1182694f0c7c17d3c09314dbaded6278469 [INFO] running `"docker" "start" "-a" "95a8a0ca2bc0f5e9325a2f52426ca1182694f0c7c17d3c09314dbaded6278469"` [INFO] [stderr] Compiling inflections v1.1.1 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Compiling gltf-derive v0.11.2 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Compiling serde_derive v1.0.75 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking gltf-json v0.11.2 [INFO] [stderr] Checking gltf v0.11.2 [INFO] [stderr] Checking raytrace v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `image::ImageBuffer` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use image::ImageBuffer; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Arc` [INFO] [stderr] --> src/scene.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::sync::Arc; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::IntoIterator` [INFO] [stderr] --> src/solids.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::iter::IntoIterator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `solids::Solid` [INFO] [stderr] --> src/raytrace.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use solids::Solid; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::Ord` [INFO] [stderr] --> src/raytrace.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::cmp::Ord; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::ImageBuffer` [INFO] [stderr] --> src/renderer.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use image::ImageBuffer; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `rayon::iter::IntoParallelRefMutIterator` [INFO] [stderr] --> src/renderer.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use rayon::iter::IntoParallelRefMutIterator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Arc` [INFO] [stderr] --> src/renderer.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::sync::Arc; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | let delta = (after - now); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/solids.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | _ => None [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/renderer.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | for n in 0..RAYS_PER_PIXEL { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Lambertian` [INFO] [stderr] --> src/material.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Lambertian { albedo: Vector3f }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Plane` [INFO] [stderr] --> src/solids.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / Plane { [INFO] [stderr] 17 | | pos: Vector3f, [INFO] [stderr] 18 | | normal: Vector3f, [INFO] [stderr] 19 | | material: Materials, [INFO] [stderr] 20 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material.rs:25:75 [INFO] [stderr] | [INFO] [stderr] 25 | Some(ScatterResult { scatter: reflected, attenuation: albedo.clone() }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*albedo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material.rs:32:60 [INFO] [stderr] | [INFO] [stderr] 32 | Some(ScatterResult { scatter, attenuation: albedo.clone() }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scene.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | pos: pos.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scene.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | look_at: look_at.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*look_at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/scene.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | data[(iu + iv * (width as usize)) * 3 + 0] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(data[(iu + iv * (width as usize)) * 3 + 0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(iu + iv * (width as usize)) * 3` [INFO] [stderr] --> src/scene.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | data[(iu + iv * (width as usize)) * 3 + 0] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/scene.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | data[(iu + iv * (width as usize)) * 3 + 1] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(data[(iu + iv * (width as usize)) * 3 + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/scene.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | data[(iu + iv * (width as usize)) * 3 + 2] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(data[(iu + iv * (width as usize)) * 3 + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solids.rs:83:37 [INFO] [stderr] | [INFO] [stderr] 83 | normal: normal.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/raytrace.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | origin: origin.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `c_base * 3` [INFO] [stderr] --> src/renderer.rs:81:58 [INFO] [stderr] | [INFO] [stderr] 81 | global.data[g_base * 3 + 0] = chunk.data[c_base * 3 + 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `g_base * 3` [INFO] [stderr] --> src/renderer.rs:81:29 [INFO] [stderr] | [INFO] [stderr] 81 | global.data[g_base * 3 + 0] = chunk.data[c_base * 3 + 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/renderer.rs:88:91 [INFO] [stderr] | [INFO] [stderr] 88 | fn render_chunk(scene: &Scene, camera: &Camera, chunk: &(u32, u32, u32, u32), canvas: &(u32, u32)) -> ImageChunk { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(u32, u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `base * 3` [INFO] [stderr] --> src/renderer.rs:106:22 [INFO] [stderr] | [INFO] [stderr] 106 | data[base * 3 + 0] = (color.x.sqrt() * 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:57:50 [INFO] [stderr] | [INFO] [stderr] 57 | environment: (env.width(), env.height(), env.iter().map(|r| *r).collect()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `env.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::ImageBuffer` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use image::ImageBuffer; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Arc` [INFO] [stderr] --> src/scene.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::sync::Arc; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::IntoIterator` [INFO] [stderr] --> src/solids.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::iter::IntoIterator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `solids::Solid` [INFO] [stderr] --> src/raytrace.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use solids::Solid; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::Ord` [INFO] [stderr] --> src/raytrace.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::cmp::Ord; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `image::ImageBuffer` [INFO] [stderr] --> src/renderer.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use image::ImageBuffer; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `rayon::iter::IntoParallelRefMutIterator` [INFO] [stderr] --> src/renderer.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use rayon::iter::IntoParallelRefMutIterator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Arc` [INFO] [stderr] --> src/renderer.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::sync::Arc; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | let delta = (after - now); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/solids.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | _ => None [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/renderer.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | for n in 0..RAYS_PER_PIXEL { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Lambertian` [INFO] [stderr] --> src/material.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Lambertian { albedo: Vector3f }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Plane` [INFO] [stderr] --> src/solids.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / Plane { [INFO] [stderr] 17 | | pos: Vector3f, [INFO] [stderr] 18 | | normal: Vector3f, [INFO] [stderr] 19 | | material: Materials, [INFO] [stderr] 20 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material.rs:25:75 [INFO] [stderr] | [INFO] [stderr] 25 | Some(ScatterResult { scatter: reflected, attenuation: albedo.clone() }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*albedo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material.rs:32:60 [INFO] [stderr] | [INFO] [stderr] 32 | Some(ScatterResult { scatter, attenuation: albedo.clone() }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scene.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | pos: pos.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scene.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | look_at: look_at.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*look_at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/scene.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | data[(iu + iv * (width as usize)) * 3 + 0] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(data[(iu + iv * (width as usize)) * 3 + 0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(iu + iv * (width as usize)) * 3` [INFO] [stderr] --> src/scene.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | data[(iu + iv * (width as usize)) * 3 + 0] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/scene.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | data[(iu + iv * (width as usize)) * 3 + 1] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(data[(iu + iv * (width as usize)) * 3 + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/scene.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | data[(iu + iv * (width as usize)) * 3 + 2] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(data[(iu + iv * (width as usize)) * 3 + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solids.rs:83:37 [INFO] [stderr] | [INFO] [stderr] 83 | normal: normal.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/raytrace.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | origin: origin.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `c_base * 3` [INFO] [stderr] --> src/renderer.rs:81:58 [INFO] [stderr] | [INFO] [stderr] 81 | global.data[g_base * 3 + 0] = chunk.data[c_base * 3 + 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `g_base * 3` [INFO] [stderr] --> src/renderer.rs:81:29 [INFO] [stderr] | [INFO] [stderr] 81 | global.data[g_base * 3 + 0] = chunk.data[c_base * 3 + 0]; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/renderer.rs:88:91 [INFO] [stderr] | [INFO] [stderr] 88 | fn render_chunk(scene: &Scene, camera: &Camera, chunk: &(u32, u32, u32, u32), canvas: &(u32, u32)) -> ImageChunk { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(u32, u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `base * 3` [INFO] [stderr] --> src/renderer.rs:106:22 [INFO] [stderr] | [INFO] [stderr] 106 | data[base * 3 + 0] = (color.x.sqrt() * 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:57:50 [INFO] [stderr] | [INFO] [stderr] 57 | environment: (env.width(), env.height(), env.iter().map(|r| *r).collect()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `env.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.17s [INFO] running `"docker" "inspect" "95a8a0ca2bc0f5e9325a2f52426ca1182694f0c7c17d3c09314dbaded6278469"` [INFO] running `"docker" "rm" "-f" "95a8a0ca2bc0f5e9325a2f52426ca1182694f0c7c17d3c09314dbaded6278469"` [INFO] [stdout] 95a8a0ca2bc0f5e9325a2f52426ca1182694f0c7c17d3c09314dbaded6278469