[INFO] updating cached repository cosmo0920/grnenv-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cosmo0920/grnenv-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cosmo0920/grnenv-rs" "work/ex/clippy-test-run/sources/stable/gh/cosmo0920/grnenv-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cosmo0920/grnenv-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cosmo0920/grnenv-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cosmo0920/grnenv-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cosmo0920/grnenv-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 138d53e5037cd17f9ce40ee9f06bd9bba9f5a528 [INFO] sha for GitHub repo cosmo0920/grnenv-rs: 138d53e5037cd17f9ce40ee9f06bd9bba9f5a528 [INFO] validating manifest of cosmo0920/grnenv-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cosmo0920/grnenv-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cosmo0920/grnenv-rs [INFO] finished frobbing cosmo0920/grnenv-rs [INFO] frobbed toml for cosmo0920/grnenv-rs written to work/ex/clippy-test-run/sources/stable/gh/cosmo0920/grnenv-rs/Cargo.toml [INFO] started frobbing cosmo0920/grnenv-rs [INFO] finished frobbing cosmo0920/grnenv-rs [INFO] frobbed toml for cosmo0920/grnenv-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cosmo0920/grnenv-rs/Cargo.toml [INFO] crate cosmo0920/grnenv-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cosmo0920/grnenv-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cosmo0920/grnenv-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 43590ad3daee15a8054d95a08d4f47b8016bec1373a336d815487bf2d9d419e1 [INFO] running `"docker" "start" "-a" "43590ad3daee15a8054d95a08d4f47b8016bec1373a336d815487bf2d9d419e1"` [INFO] [stderr] Checking num_cpus v1.2.1 [INFO] [stderr] Compiling miniz_oxide_c_api v0.1.3 [INFO] [stderr] Checking miniz_oxide v0.1.3 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Checking msdos_time v0.1.6 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Compiling serde_json v1.0.24 [INFO] [stderr] Checking env_proxy v0.1.1 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Compiling string_cache_codegen v0.4.1 [INFO] [stderr] Compiling syn v0.14.4 [INFO] [stderr] Compiling selectors v0.19.0 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Compiling string_cache v0.7.3 [INFO] [stderr] Checking zip v0.4.2 [INFO] [stderr] Checking tokio-fs v0.1.2 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Compiling serde_derive v1.0.70 [INFO] [stderr] Compiling cssparser-macros v0.3.4 [INFO] [stderr] Checking cssparser v0.23.10 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.6 [INFO] [stderr] Compiling markup5ever v0.7.2 [INFO] [stderr] Checking html5ever v0.22.3 [INFO] [stderr] Checking kuchiki v0.7.0 [INFO] [stderr] Checking grnenv-rs v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | install_dir: install_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `install_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | shim_dir: shim_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `shim_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | build_conf: build_conf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_conf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | install_dir: install_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `install_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | shim_dir: shim_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `shim_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | arch: arch, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `arch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | build_conf: build_conf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_conf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | install_dir: install_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `install_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | shim_dir: shim_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `shim_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | versions_dir: versions_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `versions_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | build_conf: build_conf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_conf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | install_dir: install_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `install_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | shim_dir: shim_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `shim_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | build_conf: build_conf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_conf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | install_dir: install_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `install_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | shim_dir: shim_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `shim_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | arch: arch, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `arch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | build_conf: build_conf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_conf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | install_dir: install_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `install_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | shim_dir: shim_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `shim_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | versions_dir: versions_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `versions_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | build_conf: build_conf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_conf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/build_conf.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | const DEFAULT_ARGS: &'static str = "\"--with-zlib --with-ssl --enable-mruby --without-libstemmer \ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/command/common.rs:59:25 [INFO] [stderr] | [INFO] [stderr] 59 | Ok(_) => return (), [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/command/unix.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | const BASE_URL: &'static str = "http://packages.groonga.org/source/groonga"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/command/unix.rs:55:16 [INFO] [stderr] | [INFO] [stderr] 55 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/command/unix.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | status [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/command/unix.rs:139:22 [INFO] [stderr] | [INFO] [stderr] 139 | let status = cmd.wait(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/command/unix.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | status [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/command/unix.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | let status = cmd.wait(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/command/unix.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | status [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/command/unix.rs:169:22 [INFO] [stderr] | [INFO] [stderr] 169 | let status = cmd.wait(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/command/unix.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | return (); [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/command/unix.rs:181:20 [INFO] [stderr] | [INFO] [stderr] 181 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/command/common.rs:68:16 [INFO] [stderr] | [INFO] [stderr] 68 | let home = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/command/unix.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | if !env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/util.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | let base_dir = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/util.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | let base_dir = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/build_conf.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | const DEFAULT_ARGS: &'static str = "\"--with-zlib --with-ssl --enable-mruby --without-libstemmer \ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/command/common.rs:59:25 [INFO] [stderr] | [INFO] [stderr] 59 | Ok(_) => return (), [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/command/unix.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | const BASE_URL: &'static str = "http://packages.groonga.org/source/groonga"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/command/unix.rs:55:16 [INFO] [stderr] | [INFO] [stderr] 55 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/command/unix.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | status [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/command/unix.rs:139:22 [INFO] [stderr] | [INFO] [stderr] 139 | let status = cmd.wait(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/command/unix.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | status [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/command/unix.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | let status = cmd.wait(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/command/unix.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | status [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/command/unix.rs:169:22 [INFO] [stderr] | [INFO] [stderr] 169 | let status = cmd.wait(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/command/unix.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | return (); [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/command/unix.rs:181:20 [INFO] [stderr] | [INFO] [stderr] 181 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/command/common.rs:68:16 [INFO] [stderr] | [INFO] [stderr] 68 | let home = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/command/unix.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | if !env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/util.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | let base_dir = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/util.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | let base_dir = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:92:20 [INFO] [stderr] | [INFO] [stderr] 92 | let home = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/util.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | let home = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/util.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | let home = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/build_conf.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | Err(_) => panic!("Couldn't decode toml with Configuration struct"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/build_conf.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | env::var(key).unwrap_or("/usr/local/opt/openssl/lib/pkgconfig".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "/usr/local/opt/openssl/lib/pkgconfig".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/build_conf.rs:64:35 [INFO] [stderr] | [INFO] [stderr] 64 | let build_args: Vec = conf_args [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 65 | | .split_whitespace() [INFO] [stderr] 66 | | .into_iter() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 64 | let build_args: Vec = conf_args [INFO] [stderr] 65 | .split_whitespace() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/build_conf.rs:88:29 [INFO] [stderr] | [INFO] [stderr] 88 | for p in path.split(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/command/common.rs:19:50 [INFO] [stderr] | [INFO] [stderr] 19 | .and_then(|n| n.to_str().map(|s| String::from(s))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/command/common.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | let e = entry.split("-").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/command/common.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | .find(|file| is_executable(file)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `is_executable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/command/unix.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | .unwrap_or_else(|| panic!("Cound not found homedir.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/build_conf.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | Err(_) => panic!("Couldn't decode toml with Configuration struct"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/build_conf.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | env::var(key).unwrap_or("/usr/local/opt/openssl/lib/pkgconfig".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "/usr/local/opt/openssl/lib/pkgconfig".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/build_conf.rs:64:35 [INFO] [stderr] | [INFO] [stderr] 64 | let build_args: Vec = conf_args [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 65 | | .split_whitespace() [INFO] [stderr] 66 | | .into_iter() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 64 | let build_args: Vec = conf_args [INFO] [stderr] 65 | .split_whitespace() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/command/unix.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | config.version.clone().unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.version` [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/build_conf.rs:88:29 [INFO] [stderr] | [INFO] [stderr] 88 | for p in path.split(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/command/unix.rs:144:39 [INFO] [stderr] | [INFO] [stderr] 144 | let make = build_conf::make().ok_or(io::Error::new( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 145 | | io::ErrorKind::NotFound, [INFO] [stderr] 146 | | "make kind command is not found", [INFO] [stderr] 147 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 144 | let make = build_conf::make().ok_or_else(|| io::Error::new( [INFO] [stderr] 145 | io::ErrorKind::NotFound, [INFO] [stderr] 146 | "make kind command is not found", [INFO] [stderr] 147 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/command/unix.rs:159:39 [INFO] [stderr] | [INFO] [stderr] 159 | let make = build_conf::make().ok_or(io::Error::new( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 160 | | io::ErrorKind::NotFound, [INFO] [stderr] 161 | | "make kind command is not found", [INFO] [stderr] 162 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 159 | let make = build_conf::make().ok_or_else(|| io::Error::new( [INFO] [stderr] 160 | io::ErrorKind::NotFound, [INFO] [stderr] 161 | "make kind command is not found", [INFO] [stderr] 162 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/command/common.rs:19:50 [INFO] [stderr] | [INFO] [stderr] 19 | .and_then(|n| n.to_str().map(|s| String::from(s))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/command/common.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | let e = entry.split("-").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/command/unix.rs:176:43 [INFO] [stderr] | [INFO] [stderr] 176 | println!("Using Groonga version: {}", config.version.clone().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/command/common.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | .find(|file| is_executable(file)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `is_executable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/command/unix.rs:204:22 [INFO] [stderr] | [INFO] [stderr] 204 | if choice == "y".to_owned() || choice == "Y".to_owned() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `"y"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/command/unix.rs:204:50 [INFO] [stderr] | [INFO] [stderr] 204 | if choice == "y".to_owned() || choice == "Y".to_owned() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `"Y"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/command/unix.rs:228:53 [INFO] [stderr] | [INFO] [stderr] 228 | let page = downloader::page_download(&client, &*format!("{}", base_url)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `base_url.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/command/unix.rs:250:28 [INFO] [stderr] | [INFO] [stderr] 250 | .split("-") [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/command/unix.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | .unwrap_or_else(|| panic!("Cound not found homedir.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/command/unix.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | config.version.clone().unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/command/unix.rs:144:39 [INFO] [stderr] | [INFO] [stderr] 144 | let make = build_conf::make().ok_or(io::Error::new( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 145 | | io::ErrorKind::NotFound, [INFO] [stderr] 146 | | "make kind command is not found", [INFO] [stderr] 147 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 144 | let make = build_conf::make().ok_or_else(|| io::Error::new( [INFO] [stderr] 145 | io::ErrorKind::NotFound, [INFO] [stderr] 146 | "make kind command is not found", [INFO] [stderr] 147 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/command/unix.rs:159:39 [INFO] [stderr] | [INFO] [stderr] 159 | let make = build_conf::make().ok_or(io::Error::new( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 160 | | io::ErrorKind::NotFound, [INFO] [stderr] 161 | | "make kind command is not found", [INFO] [stderr] 162 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 159 | let make = build_conf::make().ok_or_else(|| io::Error::new( [INFO] [stderr] 160 | io::ErrorKind::NotFound, [INFO] [stderr] 161 | "make kind command is not found", [INFO] [stderr] 162 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/command/unix.rs:176:43 [INFO] [stderr] | [INFO] [stderr] 176 | println!("Using Groonga version: {}", config.version.clone().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/command/unix.rs:204:22 [INFO] [stderr] | [INFO] [stderr] 204 | if choice == "y".to_owned() || choice == "Y".to_owned() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `"y"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/command/unix.rs:204:50 [INFO] [stderr] | [INFO] [stderr] 204 | if choice == "y".to_owned() || choice == "Y".to_owned() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `"Y"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/extractor.rs:20:48 [INFO] [stderr] | [INFO] [stderr] 20 | create_directory(install_path.parent().unwrap_or(Path::new("")), None)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/extractor.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | if (&*file.name()).ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/profile/unix.rs:9:18 [INFO] [stderr] | [INFO] [stderr] 9 | groonga_dir: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/command/unix.rs:228:53 [INFO] [stderr] | [INFO] [stderr] 228 | let page = downloader::page_download(&client, &*format!("{}", base_url)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `base_url.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/command/unix.rs:250:28 [INFO] [stderr] | [INFO] [stderr] 250 | .split("-") [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/profile/unix.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let _ = fs::remove_file(shim_dir.join("source-groonga.sh"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/profile/unix.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | let _ = fs::remove_file(shim_dir.join("source-groonga.sh"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/config.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | let _ = env::set_var("HOME", stub_home.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/config.rs:94:38 [INFO] [stderr] | [INFO] [stderr] 94 | let _ = env::set_var("HOME", stub_home.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 94 | let _ = env::set_var("HOME", &(*stub_home).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 94 | let _ = env::set_var("HOME", &str::clone(stub_home)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/config.rs:95:41 [INFO] [stderr] | [INFO] [stderr] 95 | let install_dir = PathBuf::from(stub_home.clone()).join(".groonga"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 95 | let install_dir = PathBuf::from(&(*stub_home).clone()).join(".groonga"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 95 | let install_dir = PathBuf::from(&str::clone(stub_home)).join(".groonga"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/config.rs:96:42 [INFO] [stderr] | [INFO] [stderr] 96 | let versions_dir = PathBuf::from(stub_home.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 96 | let versions_dir = PathBuf::from(&(*stub_home).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 96 | let versions_dir = PathBuf::from(&str::clone(stub_home)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/config.rs:99:38 [INFO] [stderr] | [INFO] [stderr] 99 | let shim_dir = PathBuf::from(stub_home.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 99 | let shim_dir = PathBuf::from(&(*stub_home).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 99 | let shim_dir = PathBuf::from(&str::clone(stub_home)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/config.rs:103:40 [INFO] [stderr] | [INFO] [stderr] 103 | let build_conf = PathBuf::from(stub_home.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 103 | let build_conf = PathBuf::from(&(*stub_home).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 103 | let build_conf = PathBuf::from(&str::clone(stub_home)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/config.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | let _ = env::set_var("HOME", home); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/extractor.rs:20:48 [INFO] [stderr] | [INFO] [stderr] 20 | create_directory(install_path.parent().unwrap_or(Path::new("")), None)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/extractor.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | if (&*file.name()).ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/profile/unix.rs:9:18 [INFO] [stderr] | [INFO] [stderr] 9 | groonga_dir: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/profile/unix.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let _ = fs::remove_file(shim_dir.join("source-groonga.sh"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/profile/unix.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | let _ = fs::remove_file(shim_dir.join("source-groonga.sh"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/util.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | let _ = env::set_var("HOME", stub_home.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/util.rs:88:38 [INFO] [stderr] | [INFO] [stderr] 88 | let _ = env::set_var("HOME", stub_home.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 88 | let _ = env::set_var("HOME", &(*stub_home).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 88 | let _ = env::set_var("HOME", &str::clone(stub_home)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/util.rs:90:39 [INFO] [stderr] | [INFO] [stderr] 90 | let versioned = PathBuf::from(stub_home.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 90 | let versioned = PathBuf::from(&(*stub_home).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 90 | let versioned = PathBuf::from(&str::clone(stub_home)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/util.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | let _ = env::set_var("HOME", home); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/util.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | let _ = env::set_var("HOME", stub_home.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/util.rs:101:38 [INFO] [stderr] | [INFO] [stderr] 101 | let _ = env::set_var("HOME", stub_home.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 101 | let _ = env::set_var("HOME", &(*stub_home).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 101 | let _ = env::set_var("HOME", &str::clone(stub_home)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/util.rs:103:39 [INFO] [stderr] | [INFO] [stderr] 103 | let versioned = PathBuf::from(stub_home.clone()).join(".groonga"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 103 | let versioned = PathBuf::from(&(*stub_home).clone()).join(".groonga"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 103 | let versioned = PathBuf::from(&str::clone(stub_home)).join(".groonga"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/util.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | let _ = env::set_var("HOME", home); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `grnenv-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/grnenv-docopen.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | Ok(_) => return (), [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/bin/grnenv-docopen.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | Ok(_) => return (), [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/grnenv-docopen.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | Ok(_) => return (), [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/bin/grnenv-docopen.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | Ok(_) => return (), [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "43590ad3daee15a8054d95a08d4f47b8016bec1373a336d815487bf2d9d419e1"` [INFO] running `"docker" "rm" "-f" "43590ad3daee15a8054d95a08d4f47b8016bec1373a336d815487bf2d9d419e1"` [INFO] [stdout] 43590ad3daee15a8054d95a08d4f47b8016bec1373a336d815487bf2d9d419e1