[INFO] updating cached repository coreyja/rget [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/coreyja/rget [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/coreyja/rget" "work/ex/clippy-test-run/sources/stable/gh/coreyja/rget"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/coreyja/rget'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/coreyja/rget" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coreyja/rget"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coreyja/rget'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ebd025d92d022166fe073bc952e1bdd5c4fb694f [INFO] sha for GitHub repo coreyja/rget: ebd025d92d022166fe073bc952e1bdd5c4fb694f [INFO] validating manifest of coreyja/rget on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of coreyja/rget on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing coreyja/rget [INFO] finished frobbing coreyja/rget [INFO] frobbed toml for coreyja/rget written to work/ex/clippy-test-run/sources/stable/gh/coreyja/rget/Cargo.toml [INFO] started frobbing coreyja/rget [INFO] finished frobbing coreyja/rget [INFO] frobbed toml for coreyja/rget written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coreyja/rget/Cargo.toml [INFO] crate coreyja/rget has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting coreyja/rget against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/coreyja/rget:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 172a470ba7f10d30594c9b2a0dd43ad94a6e234222c5febae964939af964d5a6 [INFO] running `"docker" "start" "-a" "172a470ba7f10d30594c9b2a0dd43ad94a6e234222c5febae964939af964d5a6"` [INFO] [stderr] Checking docopt v1.0.1 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.7.3 [INFO] [stderr] Checking rget v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | let bar = match quiet_mode { [INFO] [stderr] | _______________^ [INFO] [stderr] 56 | | true => ProgressBar::hidden(), [INFO] [stderr] 57 | | false => match length { [INFO] [stderr] 58 | | Some(len) => ProgressBar::new(len), [INFO] [stderr] 59 | | None => ProgressBar::new_spinner(), [INFO] [stderr] 60 | | }, [INFO] [stderr] 61 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 55 | let bar = if quiet_mode { ProgressBar::hidden() } else { match length { [INFO] [stderr] 56 | Some(len) => ProgressBar::new(len), [INFO] [stderr] 57 | None => ProgressBar::new_spinner(), [INFO] [stderr] 58 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | let bar = match quiet_mode { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / match length.is_some() { [INFO] [stderr] 65 | | true => bar [INFO] [stderr] 66 | | .set_style(ProgressStyle::default_bar() [INFO] [stderr] 67 | | .template("{msg} {spinner:.green} [{elapsed_precise}] [{wide_bar:.cyan/blue}] {bytes}/{total_bytes} eta: {eta}") [INFO] [stderr] 68 | | .progress_chars("=> ")), [INFO] [stderr] 69 | | false => bar.set_style(ProgressStyle::default_spinner()), [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 64 | if length.is_some() { bar [INFO] [stderr] 65 | .set_style(ProgressStyle::default_bar() [INFO] [stderr] 66 | .template("{msg} {spinner:.green} [{elapsed_precise}] [{wide_bar:.cyan/blue}] {bytes}/{total_bytes} eta: {eta}") [INFO] [stderr] 67 | .progress_chars("=> ")) } else { bar.set_style(ProgressStyle::default_spinner()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:104:34 [INFO] [stderr] | [INFO] [stderr] 104 | let fname = target.split("/").last().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | let bar = create_progress_bar(false, fname, ct_len); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | let bar = match quiet_mode { [INFO] [stderr] | _______________^ [INFO] [stderr] 56 | | true => ProgressBar::hidden(), [INFO] [stderr] 57 | | false => match length { [INFO] [stderr] 58 | | Some(len) => ProgressBar::new(len), [INFO] [stderr] 59 | | None => ProgressBar::new_spinner(), [INFO] [stderr] 60 | | }, [INFO] [stderr] 61 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 55 | let bar = if quiet_mode { ProgressBar::hidden() } else { match length { [INFO] [stderr] 56 | Some(len) => ProgressBar::new(len), [INFO] [stderr] 57 | None => ProgressBar::new_spinner(), [INFO] [stderr] 58 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | let bar = match quiet_mode { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / match length.is_some() { [INFO] [stderr] 65 | | true => bar [INFO] [stderr] 66 | | .set_style(ProgressStyle::default_bar() [INFO] [stderr] 67 | | .template("{msg} {spinner:.green} [{elapsed_precise}] [{wide_bar:.cyan/blue}] {bytes}/{total_bytes} eta: {eta}") [INFO] [stderr] 68 | | .progress_chars("=> ")), [INFO] [stderr] 69 | | false => bar.set_style(ProgressStyle::default_spinner()), [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 64 | if length.is_some() { bar [INFO] [stderr] 65 | .set_style(ProgressStyle::default_bar() [INFO] [stderr] 66 | .template("{msg} {spinner:.green} [{elapsed_precise}] [{wide_bar:.cyan/blue}] {bytes}/{total_bytes} eta: {eta}") [INFO] [stderr] 67 | .progress_chars("=> ")) } else { bar.set_style(ProgressStyle::default_spinner()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:104:34 [INFO] [stderr] | [INFO] [stderr] 104 | let fname = target.split("/").last().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | let bar = create_progress_bar(false, fname, ct_len); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.49s [INFO] running `"docker" "inspect" "172a470ba7f10d30594c9b2a0dd43ad94a6e234222c5febae964939af964d5a6"` [INFO] running `"docker" "rm" "-f" "172a470ba7f10d30594c9b2a0dd43ad94a6e234222c5febae964939af964d5a6"` [INFO] [stdout] 172a470ba7f10d30594c9b2a0dd43ad94a6e234222c5febae964939af964d5a6