[INFO] updating cached repository coredump-ch/status [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/coredump-ch/status [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/coredump-ch/status" "work/ex/clippy-test-run/sources/stable/gh/coredump-ch/status"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/coredump-ch/status'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/coredump-ch/status" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coredump-ch/status"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coredump-ch/status'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0d67361a1828fac63db2b5ba4cd7f523f08f536c [INFO] sha for GitHub repo coredump-ch/status: 0d67361a1828fac63db2b5ba4cd7f523f08f536c [INFO] validating manifest of coredump-ch/status on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of coredump-ch/status on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing coredump-ch/status [INFO] finished frobbing coredump-ch/status [INFO] frobbed toml for coredump-ch/status written to work/ex/clippy-test-run/sources/stable/gh/coredump-ch/status/Cargo.toml [INFO] started frobbing coredump-ch/status [INFO] finished frobbing coredump-ch/status [INFO] frobbed toml for coredump-ch/status written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coredump-ch/status/Cargo.toml [INFO] crate coredump-ch/status has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting coredump-ch/status against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/coredump-ch/status:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2b059d20831cce63a944bbaefe258edf28b973fd6fcb99d8a983a852b5c9398e [INFO] running `"docker" "start" "-a" "2b059d20831cce63a944bbaefe258edf28b973fd6fcb99d8a983a852b5c9398e"` [INFO] [stderr] Checking serde_json v0.8.6 [INFO] [stderr] Checking r2d2 v0.7.2 [INFO] [stderr] Checking redis v0.8.0 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking spaceapi v0.5.1 [INFO] [stderr] Checking docopt v0.8.0 [INFO] [stderr] Checking persistent v0.3.0 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking r2d2_redis v0.6.0 [INFO] [stderr] Checking bodyparser v0.5.0 [INFO] [stderr] Checking urlencoded v0.5.0 [INFO] [stderr] Checking spaceapi-server v0.4.0 [INFO] [stderr] Checking coredump-status v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | lat: 47.2359607, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `47.235_960_7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | lon: 8.8410057, [INFO] [stderr] | ^^^^^^^^^ help: consider: `8.841_005_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:85:10 [INFO] [stderr] | [INFO] [stderr] 85 | .unwrap_or("127.0.0.1".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "127.0.0.1".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:87:10 [INFO] [stderr] | [INFO] [stderr] 87 | .unwrap_or("6379".to_string()).parse().unwrap_or(6379); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "6379".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:89:10 [INFO] [stderr] | [INFO] [stderr] 89 | .unwrap_or("0".to_string()).parse().unwrap_or(0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "0".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | lat: 47.2359607, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `47.235_960_7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | lon: 8.8410057, [INFO] [stderr] | ^^^^^^^^^ help: consider: `8.841_005_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:85:10 [INFO] [stderr] | [INFO] [stderr] 85 | .unwrap_or("127.0.0.1".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "127.0.0.1".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:87:10 [INFO] [stderr] | [INFO] [stderr] 87 | .unwrap_or("6379".to_string()).parse().unwrap_or(6379); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "6379".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:89:10 [INFO] [stderr] | [INFO] [stderr] 89 | .unwrap_or("0".to_string()).parse().unwrap_or(0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "0".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.32s [INFO] running `"docker" "inspect" "2b059d20831cce63a944bbaefe258edf28b973fd6fcb99d8a983a852b5c9398e"` [INFO] running `"docker" "rm" "-f" "2b059d20831cce63a944bbaefe258edf28b973fd6fcb99d8a983a852b5c9398e"` [INFO] [stdout] 2b059d20831cce63a944bbaefe258edf28b973fd6fcb99d8a983a852b5c9398e