[INFO] updating cached repository coopersimon/RustSudokuSolver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/coopersimon/RustSudokuSolver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/coopersimon/RustSudokuSolver" "work/ex/clippy-test-run/sources/stable/gh/coopersimon/RustSudokuSolver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/coopersimon/RustSudokuSolver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/coopersimon/RustSudokuSolver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coopersimon/RustSudokuSolver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coopersimon/RustSudokuSolver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 625478f44e697554545f1298cc703089843a1cb1 [INFO] sha for GitHub repo coopersimon/RustSudokuSolver: 625478f44e697554545f1298cc703089843a1cb1 [INFO] validating manifest of coopersimon/RustSudokuSolver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of coopersimon/RustSudokuSolver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing coopersimon/RustSudokuSolver [INFO] finished frobbing coopersimon/RustSudokuSolver [INFO] frobbed toml for coopersimon/RustSudokuSolver written to work/ex/clippy-test-run/sources/stable/gh/coopersimon/RustSudokuSolver/Cargo.toml [INFO] started frobbing coopersimon/RustSudokuSolver [INFO] finished frobbing coopersimon/RustSudokuSolver [INFO] frobbed toml for coopersimon/RustSudokuSolver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coopersimon/RustSudokuSolver/Cargo.toml [INFO] crate coopersimon/RustSudokuSolver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting coopersimon/RustSudokuSolver against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/coopersimon/RustSudokuSolver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] babd86eb43232fabae93249a8a2f49171b18e44be511c3bf14458cff8df1316b [INFO] running `"docker" "start" "-a" "babd86eb43232fabae93249a8a2f49171b18e44be511c3bf14458cff8df1316b"` [INFO] [stderr] Checking sudoku_solver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:71:70 [INFO] [stderr] | [INFO] [stderr] 71 | fn fill_square(mut sudoku: &mut Vec, square: usize, row_blanks: &Vec) -> bool [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 71 | fn fill_square(mut sudoku: &mut Vec, square: usize, row_blanks: &[u32]) -> bool [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `row_blanks.clone()` to [INFO] [stderr] | [INFO] [stderr] 94 | input_blanks = row_blanks.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `row_blanks.clone()` to [INFO] [stderr] | [INFO] [stderr] 99 | input_blanks = row_blanks.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:80:7 [INFO] [stderr] | [INFO] [stderr] 80 | / let input_blanks; [INFO] [stderr] 81 | | [INFO] [stderr] 82 | | // if at the start of a row, need to calculate missing values [INFO] [stderr] 83 | | if square % 9 == 0 [INFO] [stderr] ... | [INFO] [stderr] 99 | | input_blanks = row_blanks.clone(); [INFO] [stderr] 100 | | } [INFO] [stderr] | |_______^ help: it is more idiomatic to write: `let input_blanks = if square % 9 == 0 { ..; row_blanks.clone() } else { row_blanks.clone() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:144:25 [INFO] [stderr] | [INFO] [stderr] 144 | fn check_column(sudoku: &Vec, col_num: usize) -> bool [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | fn check_box(sudoku: &Vec, row_num: usize, col_num: usize) -> bool [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:193:25 [INFO] [stderr] | [INFO] [stderr] 193 | fn print_sudoku(sudoku: &Vec) -> bool [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:71:70 [INFO] [stderr] | [INFO] [stderr] 71 | fn fill_square(mut sudoku: &mut Vec, square: usize, row_blanks: &Vec) -> bool [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 71 | fn fill_square(mut sudoku: &mut Vec, square: usize, row_blanks: &[u32]) -> bool [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `row_blanks.clone()` to [INFO] [stderr] | [INFO] [stderr] 94 | input_blanks = row_blanks.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `row_blanks.clone()` to [INFO] [stderr] | [INFO] [stderr] 99 | input_blanks = row_blanks.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:80:7 [INFO] [stderr] | [INFO] [stderr] 80 | / let input_blanks; [INFO] [stderr] 81 | | [INFO] [stderr] 82 | | // if at the start of a row, need to calculate missing values [INFO] [stderr] 83 | | if square % 9 == 0 [INFO] [stderr] ... | [INFO] [stderr] 99 | | input_blanks = row_blanks.clone(); [INFO] [stderr] 100 | | } [INFO] [stderr] | |_______^ help: it is more idiomatic to write: `let input_blanks = if square % 9 == 0 { ..; row_blanks.clone() } else { row_blanks.clone() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:144:25 [INFO] [stderr] | [INFO] [stderr] 144 | fn check_column(sudoku: &Vec, col_num: usize) -> bool [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | fn check_box(sudoku: &Vec, row_num: usize, col_num: usize) -> bool [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:193:25 [INFO] [stderr] | [INFO] [stderr] 193 | fn print_sudoku(sudoku: &Vec) -> bool [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.15s [INFO] running `"docker" "inspect" "babd86eb43232fabae93249a8a2f49171b18e44be511c3bf14458cff8df1316b"` [INFO] running `"docker" "rm" "-f" "babd86eb43232fabae93249a8a2f49171b18e44be511c3bf14458cff8df1316b"` [INFO] [stdout] babd86eb43232fabae93249a8a2f49171b18e44be511c3bf14458cff8df1316b