[INFO] updating cached repository cookie-s/factor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cookie-s/factor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cookie-s/factor" "work/ex/clippy-test-run/sources/stable/gh/cookie-s/factor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cookie-s/factor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cookie-s/factor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cookie-s/factor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cookie-s/factor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 07db9ba4fa5561faf4fcea2bef0f5e475835063b [INFO] sha for GitHub repo cookie-s/factor: 07db9ba4fa5561faf4fcea2bef0f5e475835063b [INFO] validating manifest of cookie-s/factor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cookie-s/factor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cookie-s/factor [INFO] finished frobbing cookie-s/factor [INFO] frobbed toml for cookie-s/factor written to work/ex/clippy-test-run/sources/stable/gh/cookie-s/factor/Cargo.toml [INFO] started frobbing cookie-s/factor [INFO] finished frobbing cookie-s/factor [INFO] frobbed toml for cookie-s/factor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cookie-s/factor/Cargo.toml [INFO] crate cookie-s/factor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cookie-s/factor against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cookie-s/factor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3a7b90ad9c8db588bddff7bc8df7963acf085333ac0a5beee248d2b22e49f63d [INFO] running `"docker" "start" "-a" "3a7b90ad9c8db588bddff7bc8df7963acf085333ac0a5beee248d2b22e49f63d"` [INFO] [stderr] Checking factor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | g [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let g = n.gcd(&a); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | for b in 2..r+1 { [INFO] [stderr] | ^^^^^^ help: use: `2..=r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | g [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let g = n.gcd(&a); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | for b in 2..r+1 { [INFO] [stderr] | ^^^^^^ help: use: `2..=r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | assert!(&p != &n && &p != &BigUint::one()); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 35 | assert!(p != n && &p != &BigUint::one()); [INFO] [stderr] | ^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | assert!(&p != &n && &p != &BigUint::one()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 35 | assert!(&p != &n && p != BigUint::one()); [INFO] [stderr] | ^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | assert!(&p == &n || &p == &BigUint::one()); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 39 | assert!(p == n || &p == &BigUint::one()); [INFO] [stderr] | ^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:39:25 [INFO] [stderr] | [INFO] [stderr] 39 | assert!(&p == &n || &p == &BigUint::one()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 39 | assert!(&p == &n || p == BigUint::one()); [INFO] [stderr] | ^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | assert!(&p == &n || &p == &BigUint::one()); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 42 | assert!(p == n || &p == &BigUint::one()); [INFO] [stderr] | ^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:42:25 [INFO] [stderr] | [INFO] [stderr] 42 | assert!(&p == &n || &p == &BigUint::one()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 42 | assert!(&p == &n || p == BigUint::one()); [INFO] [stderr] | ^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | assert!(&p != &n && &p != &BigUint::one()); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 98 | assert!(p != n && &p != &BigUint::one()); [INFO] [stderr] | ^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:98:25 [INFO] [stderr] | [INFO] [stderr] 98 | assert!(&p != &n && &p != &BigUint::one()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 98 | assert!(&p != &n && p != BigUint::one()); [INFO] [stderr] | ^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.59s [INFO] running `"docker" "inspect" "3a7b90ad9c8db588bddff7bc8df7963acf085333ac0a5beee248d2b22e49f63d"` [INFO] running `"docker" "rm" "-f" "3a7b90ad9c8db588bddff7bc8df7963acf085333ac0a5beee248d2b22e49f63d"` [INFO] [stdout] 3a7b90ad9c8db588bddff7bc8df7963acf085333ac0a5beee248d2b22e49f63d