[INFO] updating cached repository commodityvectors/slack-github-tag-notifier [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/commodityvectors/slack-github-tag-notifier [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/commodityvectors/slack-github-tag-notifier" "work/ex/clippy-test-run/sources/stable/gh/commodityvectors/slack-github-tag-notifier"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/commodityvectors/slack-github-tag-notifier'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/commodityvectors/slack-github-tag-notifier" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/commodityvectors/slack-github-tag-notifier"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/commodityvectors/slack-github-tag-notifier'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 30fb675500c22ec1b4630635f111894c7f90c698 [INFO] sha for GitHub repo commodityvectors/slack-github-tag-notifier: 30fb675500c22ec1b4630635f111894c7f90c698 [INFO] validating manifest of commodityvectors/slack-github-tag-notifier on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of commodityvectors/slack-github-tag-notifier on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing commodityvectors/slack-github-tag-notifier [INFO] finished frobbing commodityvectors/slack-github-tag-notifier [INFO] frobbed toml for commodityvectors/slack-github-tag-notifier written to work/ex/clippy-test-run/sources/stable/gh/commodityvectors/slack-github-tag-notifier/Cargo.toml [INFO] started frobbing commodityvectors/slack-github-tag-notifier [INFO] finished frobbing commodityvectors/slack-github-tag-notifier [INFO] frobbed toml for commodityvectors/slack-github-tag-notifier written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/commodityvectors/slack-github-tag-notifier/Cargo.toml [INFO] crate commodityvectors/slack-github-tag-notifier has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting commodityvectors/slack-github-tag-notifier against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/commodityvectors/slack-github-tag-notifier:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb2629312d20c21b47535946d00d4a15aea2839672240aa946dfc20fc948b7fd [INFO] running `"docker" "start" "-a" "eb2629312d20c21b47535946d00d4a15aea2839672240aa946dfc20fc948b7fd"` [INFO] [stderr] Compiling lazy_static v1.0.2 [INFO] [stderr] Checking regex v1.0.1 [INFO] [stderr] Checking openssl v0.9.24 [INFO] [stderr] Checking libflate v0.1.16 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking url_serde v0.2.0 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Compiling crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Checking env_logger v0.5.11 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking reqwest v0.7.3 [INFO] [stderr] Checking slack-hook v0.6.0 [INFO] [stderr] Checking sct v0.2.0 [INFO] [stderr] Checking webpki v0.17.0 [INFO] [stderr] Checking ct-logs v0.2.0 [INFO] [stderr] Checking rustls v0.11.0 [INFO] [stderr] Checking webpki-roots v0.13.0 [INFO] [stderr] Checking tokio-rustls v0.4.0 [INFO] [stderr] Checking hyper-rustls v0.11.0 [INFO] [stderr] Checking github-rs v0.6.1 [INFO] [stderr] Checking github-gql-rs v0.0.1 [INFO] [stderr] Checking github-tag-notifier v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/github.rs:6:44 [INFO] [stderr] | [INFO] [stderr] 6 | let split_repo: Vec<&str> = repo.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/github.rs:30:37 [INFO] [stderr] | [INFO] [stderr] 30 | .and_then(|(_, _, res)| res.ok_or(format_err!("Failed to read GitHub repo: empty result"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Failed to read GitHub repo: empty result"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/github.rs:6:44 [INFO] [stderr] | [INFO] [stderr] 6 | let split_repo: Vec<&str> = repo.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/github.rs:30:37 [INFO] [stderr] | [INFO] [stderr] 30 | .and_then(|(_, _, res)| res.ok_or(format_err!("Failed to read GitHub repo: empty result"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Failed to read GitHub repo: empty result"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 47.47s [INFO] running `"docker" "inspect" "eb2629312d20c21b47535946d00d4a15aea2839672240aa946dfc20fc948b7fd"` [INFO] running `"docker" "rm" "-f" "eb2629312d20c21b47535946d00d4a15aea2839672240aa946dfc20fc948b7fd"` [INFO] [stdout] eb2629312d20c21b47535946d00d4a15aea2839672240aa946dfc20fc948b7fd