[INFO] updating cached repository commiebstrd/cryptopals_rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/commiebstrd/cryptopals_rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/commiebstrd/cryptopals_rs" "work/ex/clippy-test-run/sources/stable/gh/commiebstrd/cryptopals_rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/commiebstrd/cryptopals_rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/commiebstrd/cryptopals_rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/commiebstrd/cryptopals_rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/commiebstrd/cryptopals_rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 4b87f02762b08fe81b358c7d827164362ceebc2c
[INFO] sha for GitHub repo commiebstrd/cryptopals_rs: 4b87f02762b08fe81b358c7d827164362ceebc2c
[INFO] validating manifest of commiebstrd/cryptopals_rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of commiebstrd/cryptopals_rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing commiebstrd/cryptopals_rs
[INFO] finished frobbing commiebstrd/cryptopals_rs
[INFO] frobbed toml for commiebstrd/cryptopals_rs written to work/ex/clippy-test-run/sources/stable/gh/commiebstrd/cryptopals_rs/Cargo.toml
[INFO] started frobbing commiebstrd/cryptopals_rs
[INFO] finished frobbing commiebstrd/cryptopals_rs
[INFO] frobbed toml for commiebstrd/cryptopals_rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/commiebstrd/cryptopals_rs/Cargo.toml
[INFO] crate commiebstrd/cryptopals_rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting commiebstrd/cryptopals_rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/commiebstrd/cryptopals_rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9cb8d2feca455882ce614dbd08bbaaeced01dc7644889b662ca7b4dbf2471173
[INFO] running `"docker" "start" "-a" "9cb8d2feca455882ce614dbd08bbaaeced01dc7644889b662ca7b4dbf2471173"`
[INFO] [stderr]     Checking hex_d_hex v1.0.1
[INFO] [stderr]     Checking cryptopals v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `hex_d_hex::dhex`
[INFO] [stderr]  --> src/challenges/chal4.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use hex_d_hex::dhex;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `challenges::chal4::challenge4`
[INFO] [stderr]   --> src/main.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 | use challenges::chal4::challenge4;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]   --> src/main.rs:37:4
[INFO] [stderr]    |
[INFO] [stderr] 37 |             3 => challenge3(),
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unreachable_patterns)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: static item is never used: `DECODED`
[INFO] [stderr]  --> src/challenges/chal4.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | static DECODED: &'static str = "";
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: static item is never used: `KEY`
[INFO] [stderr]  --> src/challenges/chal4.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | static KEY: &'static str = "";
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: static item is never used: `ENCODED`
[INFO] [stderr]  --> src/challenges/chal4.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | static ENCODED: &'static str = "";
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `challenge4`
[INFO] [stderr]  --> src/challenges/chal4.rs:7:1
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub fn challenge4() -> bool {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/args.rs:14:7
[INFO] [stderr]    |
[INFO] [stderr] 14 |         let ref program = args[0].clone();
[INFO] [stderr]    |         ----^^^^^^^^^^^------------------- help: try: `let program = &args[0].clone();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/args.rs:36:25
[INFO] [stderr]    |
[INFO] [stderr] 36 |             for c in chals.split(",") {
[INFO] [stderr]    |                                  ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:11:27
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn char_hashmap(chars:&Vec<u8>) -> HashMap<&u8,usize> {
[INFO] [stderr]    |                           ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:38:22
[INFO] [stderr]    |
[INFO] [stderr] 38 | pub fn eq_len_xor(pt:&Vec<u8>, key:&Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                      ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:38:36
[INFO] [stderr]    |
[INFO] [stderr] 38 | pub fn eq_len_xor(pt:&Vec<u8>, key:&Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                                    ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:47:27
[INFO] [stderr]    |
[INFO] [stderr] 47 | pub fn vec_byte_xor(chars:&Vec<u8>, key:u8) -> Vec<u8> {
[INFO] [stderr]    |                           ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:51:26
[INFO] [stderr]    |
[INFO] [stderr] 51 | pub fn chi_squared(chars:&Vec<u8>) -> f64 {
[INFO] [stderr]    |                          ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: some ranges overlap
[INFO] [stderr]   --> src/utils.rs:67:4
[INFO] [stderr]    |
[INFO] [stderr] 67 |             32...126 => { ignored+=1; continue; }, // numbers, puctuation
[INFO] [stderr]    |             ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_overlapping_arm)] on by default
[INFO] [stderr] note: overlaps with this
[INFO] [stderr]   --> src/utils.rs:65:4
[INFO] [stderr]    |
[INFO] [stderr] 65 |             65...90 => freqmap.entry(*c-65).or_insert(engfreq[(*c-65) as usize]), // lower
[INFO] [stderr]    |             ^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:84:36
[INFO] [stderr]    |
[INFO] [stderr] 84 | pub fn brute_single_byte_xor(chars:&Vec<u8>) -> u8 {
[INFO] [stderr]    |                                    ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: some ranges overlap
[INFO] [stderr]   --> src/challenges/chal3.rs:20:4
[INFO] [stderr]    |
[INFO] [stderr] 20 |             32...126 => true, // numbers, puctuation
[INFO] [stderr]    |             ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: overlaps with this
[INFO] [stderr]   --> src/challenges/chal3.rs:18:4
[INFO] [stderr]    |
[INFO] [stderr] 18 |             65...90 => true, // lower
[INFO] [stderr]    |             ^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/challenges/chal3.rs:27:2
[INFO] [stderr]    |
[INFO] [stderr] 27 |     checkvec.contains(&false) == false
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!checkvec.contains(&false)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `hex_d_hex::dhex`
[INFO] [stderr]  --> src/challenges/chal4.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use hex_d_hex::dhex;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `challenges::chal4::challenge4`
[INFO] [stderr]   --> src/main.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 | use challenges::chal4::challenge4;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:21:2
[INFO] [stderr]    |
[INFO] [stderr] 21 |       match args.set_args(MAXCHALS) {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 22 | |         Some(e) => { e.handle_error(); return },
[INFO] [stderr] 23 | |         None => { },
[INFO] [stderr] 24 | |     };
[INFO] [stderr]    | |_____^ help: try this: `if let Some(e) = args.set_args(MAXCHALS) { e.handle_error(); return }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/main.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     if args.challenges.contains(&true) == false {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!args.challenges.contains(&true)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: some ranges overlap
[INFO] [stderr]   --> src/main.rs:36:4
[INFO] [stderr]    |
[INFO] [stderr] 36 |             3 => challenge3(),
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr] note: overlaps with this
[INFO] [stderr]   --> src/main.rs:37:4
[INFO] [stderr]    |
[INFO] [stderr] 37 |             3 => challenge3(),
[INFO] [stderr]    |             ^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]   --> src/main.rs:37:4
[INFO] [stderr]    |
[INFO] [stderr] 37 |             3 => challenge3(),
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unreachable_patterns)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: static item is never used: `DECODED`
[INFO] [stderr]  --> src/challenges/chal4.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | static DECODED: &'static str = "";
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: static item is never used: `KEY`
[INFO] [stderr]  --> src/challenges/chal4.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | static KEY: &'static str = "";
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: static item is never used: `ENCODED`
[INFO] [stderr]  --> src/challenges/chal4.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | static ENCODED: &'static str = "";
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/args.rs:14:7
[INFO] [stderr]    |
[INFO] [stderr] 14 |         let ref program = args[0].clone();
[INFO] [stderr]    |         ----^^^^^^^^^^^------------------- help: try: `let program = &args[0].clone();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/args.rs:36:25
[INFO] [stderr]    |
[INFO] [stderr] 36 |             for c in chals.split(",") {
[INFO] [stderr]    |                                  ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:11:27
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn char_hashmap(chars:&Vec<u8>) -> HashMap<&u8,usize> {
[INFO] [stderr]    |                           ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:38:22
[INFO] [stderr]    |
[INFO] [stderr] 38 | pub fn eq_len_xor(pt:&Vec<u8>, key:&Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                      ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:38:36
[INFO] [stderr]    |
[INFO] [stderr] 38 | pub fn eq_len_xor(pt:&Vec<u8>, key:&Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                                    ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:47:27
[INFO] [stderr]    |
[INFO] [stderr] 47 | pub fn vec_byte_xor(chars:&Vec<u8>, key:u8) -> Vec<u8> {
[INFO] [stderr]    |                           ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:51:26
[INFO] [stderr]    |
[INFO] [stderr] 51 | pub fn chi_squared(chars:&Vec<u8>) -> f64 {
[INFO] [stderr]    |                          ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: some ranges overlap
[INFO] [stderr]   --> src/utils.rs:67:4
[INFO] [stderr]    |
[INFO] [stderr] 67 |             32...126 => { ignored+=1; continue; }, // numbers, puctuation
[INFO] [stderr]    |             ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_overlapping_arm)] on by default
[INFO] [stderr] note: overlaps with this
[INFO] [stderr]   --> src/utils.rs:65:4
[INFO] [stderr]    |
[INFO] [stderr] 65 |             65...90 => freqmap.entry(*c-65).or_insert(engfreq[(*c-65) as usize]), // lower
[INFO] [stderr]    |             ^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:84:36
[INFO] [stderr]    |
[INFO] [stderr] 84 | pub fn brute_single_byte_xor(chars:&Vec<u8>) -> u8 {
[INFO] [stderr]    |                                    ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: some ranges overlap
[INFO] [stderr]   --> src/challenges/chal3.rs:20:4
[INFO] [stderr]    |
[INFO] [stderr] 20 |             32...126 => true, // numbers, puctuation
[INFO] [stderr]    |             ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: overlaps with this
[INFO] [stderr]   --> src/challenges/chal3.rs:18:4
[INFO] [stderr]    |
[INFO] [stderr] 18 |             65...90 => true, // lower
[INFO] [stderr]    |             ^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/challenges/chal3.rs:27:2
[INFO] [stderr]    |
[INFO] [stderr] 27 |     checkvec.contains(&false) == false
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!checkvec.contains(&false)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:21:2
[INFO] [stderr]    |
[INFO] [stderr] 21 |       match args.set_args(MAXCHALS) {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 22 | |         Some(e) => { e.handle_error(); return },
[INFO] [stderr] 23 | |         None => { },
[INFO] [stderr] 24 | |     };
[INFO] [stderr]    | |_____^ help: try this: `if let Some(e) = args.set_args(MAXCHALS) { e.handle_error(); return }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/main.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     if args.challenges.contains(&true) == false {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!args.challenges.contains(&true)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: some ranges overlap
[INFO] [stderr]   --> src/main.rs:36:4
[INFO] [stderr]    |
[INFO] [stderr] 36 |             3 => challenge3(),
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr] note: overlaps with this
[INFO] [stderr]   --> src/main.rs:37:4
[INFO] [stderr]    |
[INFO] [stderr] 37 |             3 => challenge3(),
[INFO] [stderr]    |             ^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.68s
[INFO] running `"docker" "inspect" "9cb8d2feca455882ce614dbd08bbaaeced01dc7644889b662ca7b4dbf2471173"`
[INFO] running `"docker" "rm" "-f" "9cb8d2feca455882ce614dbd08bbaaeced01dc7644889b662ca7b4dbf2471173"`
[INFO] [stdout] 9cb8d2feca455882ce614dbd08bbaaeced01dc7644889b662ca7b4dbf2471173