[INFO] updating cached repository commercetools/products-csv-merger
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/commercetools/products-csv-merger
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/commercetools/products-csv-merger" "work/ex/clippy-test-run/sources/stable/gh/commercetools/products-csv-merger"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/commercetools/products-csv-merger'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/commercetools/products-csv-merger" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/commercetools/products-csv-merger"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/commercetools/products-csv-merger'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d42bd6e076c0e41b11d6e20c4b890a5c0f15468c
[INFO] sha for GitHub repo commercetools/products-csv-merger: d42bd6e076c0e41b11d6e20c4b890a5c0f15468c
[INFO] validating manifest of commercetools/products-csv-merger on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of commercetools/products-csv-merger on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing commercetools/products-csv-merger
[INFO] finished frobbing commercetools/products-csv-merger
[INFO] frobbed toml for commercetools/products-csv-merger written to work/ex/clippy-test-run/sources/stable/gh/commercetools/products-csv-merger/Cargo.toml
[INFO] started frobbing commercetools/products-csv-merger
[INFO] finished frobbing commercetools/products-csv-merger
[INFO] frobbed toml for commercetools/products-csv-merger written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/commercetools/products-csv-merger/Cargo.toml
[INFO] crate commercetools/products-csv-merger has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting commercetools/products-csv-merger against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/commercetools/products-csv-merger:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f54b736dbeb9683d1415d8df0ca11738c035f02a0522511d49f6236cd48c8700
[INFO] running `"docker" "start" "-a" "f54b736dbeb9683d1415d8df0ca11738c035f02a0522511d49f6236cd48c8700"`
[INFO] [stderr]     Checking memchr v1.0.1
[INFO] [stderr]     Checking csv-core v0.1.2
[INFO] [stderr]     Checking csv v1.0.0-beta.3
[INFO] [stderr]     Checking products-merger v1.4.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `writeln!(t, "")`
[INFO] [stderr]   --> src/main.rs:59:25
[INFO] [stderr]    |
[INFO] [stderr] 59 |                         writeln!(t, "")?;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(t)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::writeln_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(t, "")`
[INFO] [stderr]   --> src/main.rs:59:25
[INFO] [stderr]    |
[INFO] [stderr] 59 |                         writeln!(t, "")?;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(t)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::writeln_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/main.rs:150:8
[INFO] [stderr]     |
[INFO] [stderr] 150 |     Ok(wtr.write_record(&to_write)?)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/main.rs:150:8
[INFO] [stderr]     |
[INFO] [stderr] 150 |     Ok(wtr.write_record(&to_write)?)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 150 |     Ok(())
[INFO] [stderr]     |        ^^
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 150 |     Ok(())
[INFO] [stderr]     |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/main.rs:201:31
[INFO] [stderr]     |
[INFO] [stderr] 201 |     while let Some(variant) = all_records.next() {
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^ help: try: `for variant in all_records { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:223:77
[INFO] [stderr]     |
[INFO] [stderr] 223 |                                           m.get("name.de").map(|n| n.clone()).unwrap_or(
[INFO] [stderr]     |  _____________________________________________________________________________^
[INFO] [stderr] 224 | |                                             unknown.clone(),
[INFO] [stderr] 225 | |                                         )
[INFO] [stderr]     | |_________________________________________^ help: try this: `unwrap_or_else(|| unknown.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:223:41
[INFO] [stderr]     |
[INFO] [stderr] 223 |                                         m.get("name.de").map(|n| n.clone()).unwrap_or(
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `m.get("name.de").cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/main.rs:201:31
[INFO] [stderr]     |
[INFO] [stderr] 201 |     while let Some(variant) = all_records.next() {
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^ help: try: `for variant in all_records { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:251:45
[INFO] [stderr]     |
[INFO] [stderr] 251 |                                         |m| m.get(key).map(|n| n.clone()),
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `m.get(key).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:223:77
[INFO] [stderr]     |
[INFO] [stderr] 223 |                                           m.get("name.de").map(|n| n.clone()).unwrap_or(
[INFO] [stderr]     |  _____________________________________________________________________________^
[INFO] [stderr] 224 | |                                             unknown.clone(),
[INFO] [stderr] 225 | |                                         )
[INFO] [stderr]     | |_________________________________________^ help: try this: `unwrap_or_else(|| unknown.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:223:41
[INFO] [stderr]     |
[INFO] [stderr] 223 |                                         m.get("name.de").map(|n| n.clone()).unwrap_or(
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `m.get("name.de").cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:251:45
[INFO] [stderr]     |
[INFO] [stderr] 251 |                                         |m| m.get(key).map(|n| n.clone()),
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `m.get(key).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.26s
[INFO] running `"docker" "inspect" "f54b736dbeb9683d1415d8df0ca11738c035f02a0522511d49f6236cd48c8700"`
[INFO] running `"docker" "rm" "-f" "f54b736dbeb9683d1415d8df0ca11738c035f02a0522511d49f6236cd48c8700"`
[INFO] [stdout] f54b736dbeb9683d1415d8df0ca11738c035f02a0522511d49f6236cd48c8700