[INFO] updating cached repository collinmurch/snip [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/collinmurch/snip [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/collinmurch/snip" "work/ex/clippy-test-run/sources/stable/gh/collinmurch/snip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/collinmurch/snip'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/collinmurch/snip" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/collinmurch/snip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/collinmurch/snip'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6541718e62b9a55646ea9cd5bf7088a6e84964eb [INFO] sha for GitHub repo collinmurch/snip: 6541718e62b9a55646ea9cd5bf7088a6e84964eb [INFO] validating manifest of collinmurch/snip on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of collinmurch/snip on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing collinmurch/snip [INFO] finished frobbing collinmurch/snip [INFO] frobbed toml for collinmurch/snip written to work/ex/clippy-test-run/sources/stable/gh/collinmurch/snip/Cargo.toml [INFO] started frobbing collinmurch/snip [INFO] finished frobbing collinmurch/snip [INFO] frobbed toml for collinmurch/snip written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/collinmurch/snip/Cargo.toml [INFO] crate collinmurch/snip has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting collinmurch/snip against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/collinmurch/snip:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2fbb1eb88a554ee0e5b6eda1ceec676bce1acb91155e8934488470c7bfe6f3d4 [INFO] running `"docker" "start" "-a" "2fbb1eb88a554ee0e5b6eda1ceec676bce1acb91155e8934488470c7bfe6f3d4"` [INFO] [stderr] Checking isatty v0.1.8 [INFO] [stderr] Checking snip v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | return Ok(Arguments{text, flag, delimiter}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Arguments{text, flag, delimiter})` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | return Ok(Arguments{text, flag, delimiter}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Arguments{text, flag, delimiter})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return new; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `flag` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | flag: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | return Ok(Arguments{text, flag, delimiter}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Arguments{text, flag, delimiter})` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | return Ok(Arguments{text, flag, delimiter}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Arguments{text, flag, delimiter})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return new; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `flag` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | flag: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.76s [INFO] running `"docker" "inspect" "2fbb1eb88a554ee0e5b6eda1ceec676bce1acb91155e8934488470c7bfe6f3d4"` [INFO] running `"docker" "rm" "-f" "2fbb1eb88a554ee0e5b6eda1ceec676bce1acb91155e8934488470c7bfe6f3d4"` [INFO] [stdout] 2fbb1eb88a554ee0e5b6eda1ceec676bce1acb91155e8934488470c7bfe6f3d4