[INFO] updating cached repository coll/kgb
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/coll/kgb
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/coll/kgb" "work/ex/clippy-test-run/sources/stable/gh/coll/kgb"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/coll/kgb'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/coll/kgb" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coll/kgb"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coll/kgb'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 68b596841d901af76e7c84c74860943b8368eddc
[INFO] sha for GitHub repo coll/kgb: 68b596841d901af76e7c84c74860943b8368eddc
[INFO] validating manifest of coll/kgb on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of coll/kgb on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing coll/kgb
[INFO] finished frobbing coll/kgb
[INFO] frobbed toml for coll/kgb written to work/ex/clippy-test-run/sources/stable/gh/coll/kgb/Cargo.toml
[INFO] started frobbing coll/kgb
[INFO] finished frobbing coll/kgb
[INFO] frobbed toml for coll/kgb written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coll/kgb/Cargo.toml
[INFO] crate coll/kgb has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting coll/kgb against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/coll/kgb:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 13df75f762185288d98bf194ac3d0397baea457e17c9585dcb06b8915c447ef0
[INFO] running `"docker" "start" "-a" "13df75f762185288d98bf194ac3d0397baea457e17c9585dcb06b8915c447ef0"`
[INFO] [stderr]     Checking toml v0.4.6
[INFO] [stderr]     Checking backtrace v0.3.9
[INFO] [stderr]     Checking globset v0.4.0
[INFO] [stderr]     Checking comrak v0.2.13
[INFO] [stderr]     Checking handlebars v1.0.0
[INFO] [stderr]     Checking failure v0.1.1
[INFO] [stderr]     Checking nya v1.0.0
[INFO] [stderr]     Checking assert_cli v0.6.2
[INFO] [stderr]     Checking config v0.9.0
[INFO] [stderr]     Checking kgb v0.0.10 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/hbars/mod.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 |     file_struct
[INFO] [stderr]     |     ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/hbars/mod.rs:120:23
[INFO] [stderr]     |
[INFO] [stderr] 120 |       let file_struct = SimpleFile {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 121 | |         name: name_to_html(&file.name),
[INFO] [stderr] 122 | |         content: hbars.render(tname, &meta).unwrap(),
[INFO] [stderr] 123 | |         rel_path: relpath,
[INFO] [stderr] 124 | |         metadata: file.metadata.clone(),
[INFO] [stderr] 125 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/hbars/mod.rs:126:5
[INFO] [stderr]     |
[INFO] [stderr] 126 |     file_struct
[INFO] [stderr]     |     ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/hbars/mod.rs:120:23
[INFO] [stderr]     |
[INFO] [stderr] 120 |       let file_struct = SimpleFile {
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 121 | |         name: name_to_html(&file.name),
[INFO] [stderr] 122 | |         content: hbars.render(tname, &meta).unwrap(),
[INFO] [stderr] 123 | |         rel_path: relpath,
[INFO] [stderr] 124 | |         metadata: file.metadata.clone(),
[INFO] [stderr] 125 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's keys
[INFO] [stderr]   --> src/hbars/mod.rs:42:40
[INFO] [stderr]    |
[INFO] [stderr] 42 |                     for (locale, _) in &ctxmap {
[INFO] [stderr]    |                                        ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]    |
[INFO] [stderr] 42 |                     for locale in ctxmap.keys() {
[INFO] [stderr]    |                         ^^^^^^    ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/hbars/mod.rs:101:12
[INFO] [stderr]     |
[INFO] [stderr] 101 |     tname: &String,
[INFO] [stderr]     |            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/hbars/mod.rs:103:13
[INFO] [stderr]     |
[INFO] [stderr] 103 |     locale: &String,
[INFO] [stderr]     |             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's keys
[INFO] [stderr]   --> src/hbars/mod.rs:42:40
[INFO] [stderr]    |
[INFO] [stderr] 42 |                     for (locale, _) in &ctxmap {
[INFO] [stderr]    |                                        ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]    |
[INFO] [stderr] 42 |                     for locale in ctxmap.keys() {
[INFO] [stderr]    |                         ^^^^^^    ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/hbars/mod.rs:101:12
[INFO] [stderr]     |
[INFO] [stderr] 101 |     tname: &String,
[INFO] [stderr]     |            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/hbars/mod.rs:103:13
[INFO] [stderr]     |
[INFO] [stderr] 103 |     locale: &String,
[INFO] [stderr]     |             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 12.67s
[INFO] running `"docker" "inspect" "13df75f762185288d98bf194ac3d0397baea457e17c9585dcb06b8915c447ef0"`
[INFO] running `"docker" "rm" "-f" "13df75f762185288d98bf194ac3d0397baea457e17c9585dcb06b8915c447ef0"`
[INFO] [stdout] 13df75f762185288d98bf194ac3d0397baea457e17c9585dcb06b8915c447ef0