[INFO] updating cached repository cohama/rsplot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/cohama/rsplot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/cohama/rsplot" "work/ex/clippy-test-run/sources/stable/gh/cohama/rsplot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/cohama/rsplot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/cohama/rsplot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cohama/rsplot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cohama/rsplot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bdafc98ceeffe73ffbe3a928868b7728db215e9e [INFO] sha for GitHub repo cohama/rsplot: bdafc98ceeffe73ffbe3a928868b7728db215e9e [INFO] validating manifest of cohama/rsplot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cohama/rsplot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cohama/rsplot [INFO] finished frobbing cohama/rsplot [INFO] frobbed toml for cohama/rsplot written to work/ex/clippy-test-run/sources/stable/gh/cohama/rsplot/Cargo.toml [INFO] started frobbing cohama/rsplot [INFO] finished frobbing cohama/rsplot [INFO] frobbed toml for cohama/rsplot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/cohama/rsplot/Cargo.toml [INFO] crate cohama/rsplot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cohama/rsplot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/cohama/rsplot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a47d3b9f69d7e62757f27e7954e1d7c6202112b529caf61e6531f1c9004b0e17 [INFO] running `"docker" "start" "-a" "a47d3b9f69d7e62757f27e7954e1d7c6202112b529caf61e6531f1c9004b0e17"` [INFO] [stderr] Compiling gio v0.1.3 [INFO] [stderr] Compiling gdk-pixbuf v0.1.3 [INFO] [stderr] Compiling gdk v0.5.3 [INFO] [stderr] Compiling gtk v0.1.3 [INFO] [stderr] Compiling gio-sys v0.3.4 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.3.4 [INFO] [stderr] Compiling pango-sys v0.3.4 [INFO] [stderr] Compiling gdk-sys v0.3.4 [INFO] [stderr] Compiling gtk-sys v0.3.4 [INFO] [stderr] Checking glib-sys v0.3.4 [INFO] [stderr] Checking cairo-sys-rs v0.3.4 [INFO] [stderr] Checking gobject-sys v0.3.4 [INFO] [stderr] Checking glib v0.1.3 [INFO] [stderr] Checking atk-sys v0.3.4 [INFO] [stderr] Checking pango v0.1.3 [INFO] [stderr] Checking cairo-rs v0.1.3 [INFO] [stderr] Checking rsplot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/prelude.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | let m = self.conf.axis_margin_px as f64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/prelude.rs:207:21 [INFO] [stderr] | [INFO] [stderr] 207 | let (x, y) = self.f2p(p.0, p.1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/prelude.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | let (x, y) = self.f2p(p.0, p.1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/prelude.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | let m = self.conf.axis_margin_px as f64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/prelude.rs:207:21 [INFO] [stderr] | [INFO] [stderr] 207 | let (x, y) = self.f2p(p.0, p.1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/prelude.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | let (x, y) = self.f2p(p.0, p.1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `prelude::Plot` [INFO] [stderr] --> src/prelude.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Plot { [INFO] [stderr] 20 | | let _ = gtk::init(); [INFO] [stderr] 21 | | let window = Window::new(WindowType::Toplevel); [INFO] [stderr] 22 | | window.set_title("rsplot"); [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for prelude::Plot { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/prelude.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | let ref fs: Vec<_> = funcs; [INFO] [stderr] | ----^^^^^^----------------- help: try: `let fs: &Vec<_> = &funcs;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/prelude.rs:104:30 [INFO] [stderr] | [INFO] [stderr] 104 | let points = (0..precision+1).map(|i| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(0..=precision)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/prelude.rs:105:47 [INFO] [stderr] | [INFO] [stderr] 105 | (xaxis.to - xaxis.from) / (precision as f64) * i as f64 + xaxis.from [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(precision)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/prelude.rs:105:68 [INFO] [stderr] | [INFO] [stderr] 105 | (xaxis.to - xaxis.from) / (precision as f64) * i as f64 + xaxis.from [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/prelude.rs:173:23 [INFO] [stderr] | [INFO] [stderr] 173 | let (w, h) = (self.width as f64, self.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/prelude.rs:173:42 [INFO] [stderr] | [INFO] [stderr] 173 | let (w, h) = (self.width as f64, self.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/prelude.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | let m = self.conf.axis_margin_px as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.conf.axis_margin_px)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prelude.rs:202:39 [INFO] [stderr] | [INFO] [stderr] 202 | pub fn draw_points(&self, points: &Vec<(f64, f64)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(f64, f64)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prelude.rs:214:37 [INFO] [stderr] | [INFO] [stderr] 214 | pub fn draw_line(&self, points: &Vec<(f64, f64)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(f64, f64)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `prelude::Plot` [INFO] [stderr] --> src/prelude.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Plot { [INFO] [stderr] 20 | | let _ = gtk::init(); [INFO] [stderr] 21 | | let window = Window::new(WindowType::Toplevel); [INFO] [stderr] 22 | | window.set_title("rsplot"); [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for prelude::Plot { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/prelude.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | let ref fs: Vec<_> = funcs; [INFO] [stderr] | ----^^^^^^----------------- help: try: `let fs: &Vec<_> = &funcs;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/prelude.rs:104:30 [INFO] [stderr] | [INFO] [stderr] 104 | let points = (0..precision+1).map(|i| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(0..=precision)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/prelude.rs:105:47 [INFO] [stderr] | [INFO] [stderr] 105 | (xaxis.to - xaxis.from) / (precision as f64) * i as f64 + xaxis.from [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(precision)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/prelude.rs:105:68 [INFO] [stderr] | [INFO] [stderr] 105 | (xaxis.to - xaxis.from) / (precision as f64) * i as f64 + xaxis.from [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/prelude.rs:173:23 [INFO] [stderr] | [INFO] [stderr] 173 | let (w, h) = (self.width as f64, self.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/prelude.rs:173:42 [INFO] [stderr] | [INFO] [stderr] 173 | let (w, h) = (self.width as f64, self.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/prelude.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | let m = self.conf.axis_margin_px as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.conf.axis_margin_px)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prelude.rs:202:39 [INFO] [stderr] | [INFO] [stderr] 202 | pub fn draw_points(&self, points: &Vec<(f64, f64)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(f64, f64)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prelude.rs:214:37 [INFO] [stderr] | [INFO] [stderr] 214 | pub fn draw_line(&self, points: &Vec<(f64, f64)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(f64, f64)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:7:34 [INFO] [stderr] | [INFO] [stderr] 7 | let points = (0..20).map(|x| (3*x - 20) as f64).map(|x| (x, -0.02 * x * x + 8.0)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(3*x - 20)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:7:34 [INFO] [stderr] | [INFO] [stderr] 7 | let points = (0..20).map(|x| (3*x - 20) as f64).map(|x| (x, -0.02 * x * x + 8.0)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(3*x - 20)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 39.99s [INFO] running `"docker" "inspect" "a47d3b9f69d7e62757f27e7954e1d7c6202112b529caf61e6531f1c9004b0e17"` [INFO] running `"docker" "rm" "-f" "a47d3b9f69d7e62757f27e7954e1d7c6202112b529caf61e6531f1c9004b0e17"` [INFO] [stdout] a47d3b9f69d7e62757f27e7954e1d7c6202112b529caf61e6531f1c9004b0e17