[INFO] updating cached repository coeuvre/flappy-bird-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/coeuvre/flappy-bird-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/coeuvre/flappy-bird-rs" "work/ex/clippy-test-run/sources/stable/gh/coeuvre/flappy-bird-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/coeuvre/flappy-bird-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/coeuvre/flappy-bird-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coeuvre/flappy-bird-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coeuvre/flappy-bird-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 93c48089482eba43ef0683ac6502feafe2127173 [INFO] sha for GitHub repo coeuvre/flappy-bird-rs: 93c48089482eba43ef0683ac6502feafe2127173 [INFO] validating manifest of coeuvre/flappy-bird-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of coeuvre/flappy-bird-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing coeuvre/flappy-bird-rs [INFO] finished frobbing coeuvre/flappy-bird-rs [INFO] frobbed toml for coeuvre/flappy-bird-rs written to work/ex/clippy-test-run/sources/stable/gh/coeuvre/flappy-bird-rs/Cargo.toml [INFO] started frobbing coeuvre/flappy-bird-rs [INFO] finished frobbing coeuvre/flappy-bird-rs [INFO] frobbed toml for coeuvre/flappy-bird-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coeuvre/flappy-bird-rs/Cargo.toml [INFO] crate coeuvre/flappy-bird-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting coeuvre/flappy-bird-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/coeuvre/flappy-bird-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb53977b43ca6ade9d1b2a255df69779767afecf056bf73420ea2e9f2db64ac9 [INFO] running `"docker" "start" "-a" "bb53977b43ca6ade9d1b2a255df69779767afecf056bf73420ea2e9f2db64ac9"` [INFO] [stderr] Compiling flapply_bird v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking glutin v0.10.1 [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/gfx/image/mod.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | let n = self.stbi.n as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/gfx/image/mod.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | let p = self.stbi.data.offset(offset as isize); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/gfx/image/mod.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | let n = self.stbi.n as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/gfx/image/mod.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | let p = self.stbi.data.offset(offset as isize); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gfx/program/draw_texture.rs:210:23 [INFO] [stderr] | [INFO] [stderr] 210 | const VERTEX_SHADER: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gfx/program/draw_texture.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 229 | const FRAGMENT_SHADER: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/gfx/program/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gfx/program/draw_texture.rs:210:23 [INFO] [stderr] | [INFO] [stderr] 210 | const VERTEX_SHADER: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/gfx/program/draw_texture.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 229 | const FRAGMENT_SHADER: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/gfx/program/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ctx` [INFO] [stderr] --> src/gfx/mod.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | ctx: *mut GlContext, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `w` [INFO] [stderr] --> src/gfx/mod.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | w: u32, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `h` [INFO] [stderr] --> src/gfx/mod.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | h: u32, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/gfx/program/draw_texture.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | 0 as *const c_void, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/gfx/program/draw_texture.rs:194:66 [INFO] [stderr] | [INFO] [stderr] 194 | gl::DrawElements(gl::TRIANGLES, 6, gl::UNSIGNED_INT, 0 as *const c_void); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gfx/program/mod.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | if is_success != gl::TRUE as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gfx/program/mod.rs:52:26 [INFO] [stderr] | [INFO] [stderr] 52 | if is_success != gl::TRUE as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:32:41 [INFO] [stderr] | [INFO] [stderr] 32 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 33 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 34 | | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 35 | | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] ... | [INFO] [stderr] 43 | | _ => (), [INFO] [stderr] 44 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 33 | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 34 | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] 35 | glutin::WindowEvent::KeyboardInput { input, .. } => { [INFO] [stderr] 36 | if input.virtual_keycode == Some(glutin::VirtualKeyCode::Escape) { [INFO] [stderr] 37 | running = false; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ctx` [INFO] [stderr] --> src/gfx/mod.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | ctx: *mut GlContext, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `w` [INFO] [stderr] --> src/gfx/mod.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | w: u32, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `h` [INFO] [stderr] --> src/gfx/mod.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | h: u32, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/gfx/program/draw_texture.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | 0 as *const c_void, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/gfx/program/draw_texture.rs:194:66 [INFO] [stderr] | [INFO] [stderr] 194 | gl::DrawElements(gl::TRIANGLES, 6, gl::UNSIGNED_INT, 0 as *const c_void); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gfx/program/mod.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | if is_success != gl::TRUE as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/gfx/program/mod.rs:52:26 [INFO] [stderr] | [INFO] [stderr] 52 | if is_success != gl::TRUE as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:32:41 [INFO] [stderr] | [INFO] [stderr] 32 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 33 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 34 | | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 35 | | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] ... | [INFO] [stderr] 43 | | _ => (), [INFO] [stderr] 44 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 33 | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 34 | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] 35 | glutin::WindowEvent::KeyboardInput { input, .. } => { [INFO] [stderr] 36 | if input.virtual_keycode == Some(glutin::VirtualKeyCode::Escape) { [INFO] [stderr] 37 | running = false; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.26s [INFO] running `"docker" "inspect" "bb53977b43ca6ade9d1b2a255df69779767afecf056bf73420ea2e9f2db64ac9"` [INFO] running `"docker" "rm" "-f" "bb53977b43ca6ade9d1b2a255df69779767afecf056bf73420ea2e9f2db64ac9"` [INFO] [stdout] bb53977b43ca6ade9d1b2a255df69779767afecf056bf73420ea2e9f2db64ac9