[INFO] updating cached repository coderbot16/cem [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/coderbot16/cem [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/coderbot16/cem" "work/ex/clippy-test-run/sources/stable/gh/coderbot16/cem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/coderbot16/cem'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/coderbot16/cem" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coderbot16/cem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coderbot16/cem'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7b0b76420ebb77006d681f38aa4c4aa16f6baa61 [INFO] sha for GitHub repo coderbot16/cem: 7b0b76420ebb77006d681f38aa4c4aa16f6baa61 [INFO] validating manifest of coderbot16/cem on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of coderbot16/cem on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing coderbot16/cem [INFO] finished frobbing coderbot16/cem [INFO] frobbed toml for coderbot16/cem written to work/ex/clippy-test-run/sources/stable/gh/coderbot16/cem/Cargo.toml [INFO] started frobbing coderbot16/cem [INFO] finished frobbing coderbot16/cem [INFO] frobbed toml for coderbot16/cem written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/coderbot16/cem/Cargo.toml [INFO] crate coderbot16/cem has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting coderbot16/cem against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/coderbot16/cem:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 29a3d844885068820c9c3b45b765bf4f277012824c9245bd92bf60c676d830f9 [INFO] running `"docker" "start" "-a" "29a3d844885068820c9c3b45b765bf4f277012824c9245bd92bf60c676d830f9"` [INFO] [stderr] Checking cgmath v0.16.0 [INFO] [stderr] Checking cem v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | pub const MAGIC: u32 = 0x464D5353; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x464D_5353` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | pub const MAGIC: u32 = 0x464D5353; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x464D_5353` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/v2.rs:61:6 [INFO] [stderr] | [INFO] [stderr] 61 | if self.materials.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.materials.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/v2.rs:65:6 [INFO] [stderr] | [INFO] [stderr] 65 | if self.lod_levels.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.lod_levels.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/v2.rs:69:6 [INFO] [stderr] | [INFO] [stderr] 69 | if self.frames.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.frames.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/v2.rs:242:18 [INFO] [stderr] | [INFO] [stderr] 242 | pub fn write(&self, w: &mut W) -> io::Result<()> where W: Write { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/v2.rs:61:6 [INFO] [stderr] | [INFO] [stderr] 61 | if self.materials.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.materials.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/v2.rs:65:6 [INFO] [stderr] | [INFO] [stderr] 65 | if self.lod_levels.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.lod_levels.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/v2.rs:69:6 [INFO] [stderr] | [INFO] [stderr] 69 | if self.frames.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.frames.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/v2.rs:242:18 [INFO] [stderr] | [INFO] [stderr] 242 | pub fn write(&self, w: &mut W) -> io::Result<()> where W: Write { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/encode.rs:61:56 [INFO] [stderr] | [INFO] [stderr] 61 | w.write_u8(if char < '\u{256}' { char as u8 } else { '?' as u8 })?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'?' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/encode.rs:61:56 [INFO] [stderr] | [INFO] [stderr] 61 | w.write_u8(if char < '\u{256}' { char as u8 } else { '?' as u8 })?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'?' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/report.rs:35:71 [INFO] [stderr] | [INFO] [stderr] 35 | let radius_eq = (collider.radius - frame.collider.radius).abs() < 0.0000005; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.000_000_5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/report.rs:35:71 [INFO] [stderr] | [INFO] [stderr] 35 | let radius_eq = (collider.radius - frame.collider.radius).abs() < 0.0000005; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.000_000_5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.01s [INFO] running `"docker" "inspect" "29a3d844885068820c9c3b45b765bf4f277012824c9245bd92bf60c676d830f9"` [INFO] running `"docker" "rm" "-f" "29a3d844885068820c9c3b45b765bf4f277012824c9245bd92bf60c676d830f9"` [INFO] [stdout] 29a3d844885068820c9c3b45b765bf4f277012824c9245bd92bf60c676d830f9